[Pkg-mozext-commits] [firebug] 48/82: Comment fixes

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to tag fbtest-1.11.2
in repository firebug.

commit b2865ed0ed6576ab0eaf82b887d6ccc9ac201343
Author: Simon Lindholm <simon.lindholm10 at gmail.com>
Date:   Wed Jan 2 23:25:22 2013 +0100

    Comment fixes
---
 extension/content/firebug/console/closureInspector.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/extension/content/firebug/console/closureInspector.js b/extension/content/firebug/console/closureInspector.js
index a03472b..831af93 100644
--- a/extension/content/firebug/console/closureInspector.js
+++ b/extension/content/firebug/console/closureInspector.js
@@ -72,7 +72,7 @@ var ClosureInspector =
                 return undefined;
 
             // The variable is either optimized away or actually set to undefined.
-            // Optimized-away ones are apparantly not settable, so try to detect
+            // Optimized-away ones are apparently not settable, so try to detect
             // them by that (it seems rather safe).
             scope.setVariable(name, 0);
             if (scope.getVariable(name) === undefined)
@@ -129,7 +129,6 @@ var ClosureInspector =
                 names.push("constructor");
             }
 
-            // XXX keep a Map of scopes, and take the highest container of the first one or the (first) deepest one or something
             for (var i = 0; i < names.length; ++i)
             {
                 // We assume that the first own property, or the first
@@ -137,6 +136,10 @@ var ClosureInspector =
                 // that is a function with some scope (i.e., it is interpreted,
                 // JSScript-backed, and without optimized-away scope) shares
                 // this scope with 'obj'.
+                // (Since, in the current implementation, Firefox seems to give
+                // all functions in a particular scope (except self-contained
+                // ones) the same environment, the first is as good as any,
+                // and it's probably near the definition of 'obj').
 
                 var name = names[i];
                 try

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/firebug.git