[Pkg-mozext-commits] [tabmixplus] 59/123: Changeset 77e3810f7efc, revels hidden bug. setting 'tabmix-show-newtabbutton' attribute with empty string instead of null, to remove the attribute, make the 2 new-tab-button visible

David Prévot taffit at moszumanska.debian.org
Wed Sep 17 21:16:27 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit 88e327c504c0efab3dcf126ca55cf533aa4e09c5
Author: onemen <tabmix.onemen at gmail.com>
Date:   Mon Sep 1 00:26:09 2014 +0300

    Changeset 77e3810f7efc, revels hidden bug. setting 'tabmix-show-newtabbutton' attribute with empty string instead of null, to remove the attribute, make the 2 new-tab-button visible
---
 chrome/content/tabmix.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/chrome/content/tabmix.js b/chrome/content/tabmix.js
index b0a7243..49ba3a0 100644
--- a/chrome/content/tabmix.js
+++ b/chrome/content/tabmix.js
@@ -56,7 +56,7 @@ Tabmix.beforeSessionStoreInit = function TMP_beforeSessionStoreInit(aPromise) {
 
   TabmixSessionManager.init(aPromise);
 
-  // if we call this functions erlier we get this warning:
+  // if we call these functions earlier we get this warning:
   // XUL box for _moz_generated_content_before element contained an inline #text child
   // by calling getBoundingClientRect
   Tabmix.getButtonsHeight();
@@ -142,7 +142,7 @@ Tabmix.getAfterTabsButtonsWidth = function TMP_getAfterTabsButtonsWidth() {
     if (stripIsHidden)
       tabBar.visible = true;
     let tabsToolbar = document.getElementById("TabsToolbar");
-    let showButton = tabsToolbar.getAttribute("tabmix-show-newtabbutton");
+    let currentButtonVisibility = tabsToolbar.getAttribute("tabmix-show-newtabbutton");
     this.setItem(tabsToolbar, "tabmix-show-newtabbutton", "aftertabs-force");
     // save tabsNewtabButton width
     let lwtheme = !this.isVersion(280) && document.getElementById("main-window").getAttribute("lwtheme");
@@ -168,7 +168,7 @@ Tabmix.getAfterTabsButtonsWidth = function TMP_getAfterTabsButtonsWidth() {
       if (openNewPrivateTabRect.right > openNewTabRect.right)
         this.tabsNewtabButton = openNewPrivateTab;
     }
-    this.setItem(tabsToolbar, "tabmix-show-newtabbutton", showButton);
+    this.setItem(tabsToolbar, "tabmix-show-newtabbutton", currentButtonVisibility || null);
     if (stripIsHidden)
       tabBar.visible = false;
   }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list