[Pkg-mozext-commits] [tabmixplus] 87/123: Selected tab sometimes not scroll to view when there are many rows and pinned tab

David Prévot taffit at moszumanska.debian.org
Wed Sep 17 21:16:30 UTC 2014


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository tabmixplus.

commit 2f2ac429df4a97d2e26e4c67e50299331301378d
Author: onemen <tabmix.onemen at gmail.com>
Date:   Sat Sep 6 12:12:18 2014 +0300

    Selected tab sometimes not scroll to view when there are many rows and pinned tab
---
 chrome/content/session/session.js | 1 +
 chrome/content/tab/scrollbox.xml  | 5 +++++
 chrome/content/tabmix.js          | 4 +---
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/chrome/content/session/session.js b/chrome/content/session/session.js
index 975a9b7..231f174 100644
--- a/chrome/content/session/session.js
+++ b/chrome/content/session/session.js
@@ -1099,6 +1099,7 @@ if (container == "error") { Tabmix.log("wrapContainer error path " + path + "\n"
          case "sessionstore-browser-state-restored":
             // session restored update buttons state
             TMP_ClosedTabs.setButtonDisableState();
+            gBrowser.ensureTabIsVisible(gBrowser.selectedTab, true);
          case "browser-window-change-state":
             this.toggleRecentlyClosedWindowsButton();
             break;
diff --git a/chrome/content/tab/scrollbox.xml b/chrome/content/tab/scrollbox.xml
index 288b3a2..a9708bb 100644
--- a/chrome/content/tab/scrollbox.xml
+++ b/chrome/content/tab/scrollbox.xml
@@ -458,6 +458,11 @@
             if (tab.hasAttribute("tabmix-firstTabInRow"))
               tab.removeAttribute("tabmix-firstTabInRow");
           }
+
+          // if a smoothScroll is in progress call ensureElementIsVisible again
+          // the amountToScroll changed when we changed firstTabInRow
+          if (this._scrollTarget)
+            this.ensureElementIsVisible(this._scrollTarget, true)
         ]]></body>
       </method>
 
diff --git a/chrome/content/tabmix.js b/chrome/content/tabmix.js
index eb7b679..79dc5ab 100644
--- a/chrome/content/tabmix.js
+++ b/chrome/content/tabmix.js
@@ -645,9 +645,7 @@ var TMP_eventListener = {
     Tabmix.restoreTabState(tab);
     TabmixSessionManager.restoreHistoryComplete(tab);
 
-    if (gBrowser.tabContainer.overflow &&
-        !gBrowser.tabContainer.mTabstrip.isElementVisible(gBrowser.selectedTab))
-      gBrowser.ensureTabIsVisible(gBrowser.selectedTab, false);
+    gBrowser.ensureTabIsVisible(gBrowser.selectedTab, false);
 
     // don't mark new tab as unread
     var url = tab.linkedBrowser.currentURI.spec;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/tabmixplus.git



More information about the Pkg-mozext-commits mailing list