[Pkg-mozext-commits] [adblock-plus] 10/22: Issue 2236 - Worked around JsDoc bug with inline annotations

David Prévot taffit at moszumanska.debian.org
Wed Apr 1 19:35:10 UTC 2015


This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository adblock-plus.

commit d5484abe65b31d0df845dcc4d8a1018e1b395503
Author: Sebastian Noack <sebastian at adblockplus.org>
Date:   Mon Mar 30 16:10:54 2015 +0200

    Issue 2236 - Worked around JsDoc bug with inline annotations
---
 lib/contentPolicy.js   |  4 +++-
 lib/objectTabs.js      |  9 +++++++--
 lib/requestNotifier.js |  5 ++++-
 lib/utils.js           | 10 ++++++++--
 4 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/lib/contentPolicy.js b/lib/contentPolicy.js
index f614d76..9b11b9d 100644
--- a/lib/contentPolicy.js
+++ b/lib/contentPolicy.js
@@ -308,8 +308,10 @@ let Policy = exports.Policy =
 
   /**
    * Asynchronously re-checks filters for given nodes.
+   * @param {Node[]} nodes
+   * @param {RequestEntry} entry
    */
-  refilterNodes: function(/**Node[]*/ nodes, /**RequestEntry*/ entry)
+  refilterNodes: function(nodes, entry)
   {
     // Ignore nodes that have been blocked already
     if (entry.filter && !(entry.filter instanceof WhitelistFilter))
diff --git a/lib/objectTabs.js b/lib/objectTabs.js
index 6834377..b45dc6d 100644
--- a/lib/objectTabs.js
+++ b/lib/objectTabs.js
@@ -226,8 +226,10 @@ var objTabs =
 
   /**
    * Makes the tab element visible.
+   * @param {Element} element
+   * @param {RequestEntry} data
    */
-  _showTab: function(/**Element*/ element, /**RequestEntry*/ data)
+  _showTab: function(element, data)
   {
     let {UI} = require("ui");
     if (!UI.overlay)
@@ -420,8 +422,11 @@ var objTabs =
 
   /**
    * Called whenever a timer fires.
+   * @param {nsISupport} subject
+   * @param {string} topic
+   * @param {string} data
    */
-  observe: function(/**nsISupport*/ subject, /**String*/ topic, /**String*/ data)
+  observe: function(subject, topic, data)
   {
     if (subject == this.positionTimer)
     {
diff --git a/lib/requestNotifier.js b/lib/requestNotifier.js
index 492317a..8b9ca30 100644
--- a/lib/requestNotifier.js
+++ b/lib/requestNotifier.js
@@ -135,8 +135,11 @@ RequestNotifier.prototype =
 
   /**
    * Notifies listener about a new request.
+   * @param {Window} wnd
+   * @param {Node} node
+   * @param {RequestEntry} entry
    */
-  notifyListener: function(/**Window*/ wnd, /**Node*/ node, /**RequestEntry*/ entry)
+  notifyListener: function(wnd, node, entry)
   {
     this.listener.call(this.listenerObj, wnd, node, entry, this.scanComplete);
   },
diff --git a/lib/utils.js b/lib/utils.js
index 597b36c..34084ee 100644
--- a/lib/utils.js
+++ b/lib/utils.js
@@ -215,8 +215,10 @@ let Utils = exports.Utils =
    * Posts an action to the event queue of the current thread to run it
    * asynchronously. Any additional parameters to this function are passed
    * as parameters to the callback.
+   * @param {function} callback
+   * @param {object} thisPtr
    */
-  runAsync: function(/**Function*/ callback, /**Object*/ thisPtr)
+  runAsync: function(callback, thisPtr)
   {
     let params = Array.prototype.slice.call(arguments, 2);
     let runnable = {
@@ -400,8 +402,12 @@ let Utils = exports.Utils =
 
   /**
    * Verifies RSA signature. The public key and signature should be base64-encoded.
+   * @param {string} key
+   * @param {string} signature
+   * @param {string} data
+   * @return {boolean}
    */
-  verifySignature: function(/**String*/ key, /**String*/ signature, /**String*/ data) /**Boolean*/
+  verifySignature: function(key, signature, data)
   {
     if (!Utils.crypto)
       return false;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/adblock-plus.git



More information about the Pkg-mozext-commits mailing list