[Pkg-mozext-commits] [adblock-plus-element-hiding-helper] 344/483: Topic 8918 - Don't keep a persistent selection element around, it delays compartment GC

[David Prévot]

This is an automated email from the git hooks/post-receive script.

taffit pushed a commit to branch master
in repository adblock-plus-element-hiding-helper.

commit a5c09779f8572d6c78074e8671600cb11501dfe4
Author: Wladimir Palant <trev at adblockplus.org>
Date:   Thu Dec 8 09:07:56 2011 +0100

    Topic 8918 - Don't keep a persistent selection element around, it delays compartment GC
---
 modules/Aardvark.jsm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/modules/Aardvark.jsm b/modules/Aardvark.jsm
index 5f417f9..bb91597 100644
--- a/modules/Aardvark.jsm
+++ b/modules/Aardvark.jsm
@@ -79,8 +79,7 @@ var Aardvark =
     this.browser.contentWindow.focus();
   
     let doc = this.browser.contentDocument;
-    if (!this.boxElem)
-      this.boxElem = E("ehh-elementmarker").firstChild;
+    this.boxElem = doc.importNode(E("ehh-elementmarker").firstChild.cloneNode(true));
   
     this.initHelpBox();
   
@@ -388,8 +387,6 @@ var Aardvark =
     else
       label.className = "label onTop";
     
-    if (this.boxElem.ownerDocument != doc)
-      this.boxElem = doc.importNode(this.boxElem, true);
     doc.documentElement.appendChild(this.boxElem);
 
     this.paintNode = doc.defaultView;
@@ -575,13 +572,14 @@ var Aardvark =
     this.browser.removeEventListener("keypress", this.onKeyPress, true);
     this.browser.removeEventListener("mousemove", this.onMouseMove, true);
     this.browser.contentWindow.removeEventListener("pagehide", this.onPageHide, true);
-  
+
     this.anchorElem = null;
     this.selectedElem = null;
     this.window = null;
     this.browser = null;
     this.commentElem = null;
     this.lockedAnchor = null;
+    this.boxElem = null;
     E = function(id) null;
     return false;
   },

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-mozext/adblock-plus-element-hiding-helper.git