Bug#833771: nspr FTCBFS: does not honour DEB_BUILD_OPTIONS=nocheck

Helmut Grohne helmut at subdivi.de
Mon Aug 8 15:15:15 UTC 2016


Source: nspr
Version: 2:4.12-3
Severity: important
Justification: fails to cross build but built before
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

Hi Mike,

Thank you for enabling the test suite and thus improving the quality of
nspr. Unfortunately, it is also being run during cross builds that set
DEB_BUILD_OPTIONS=nocheck. Thus cross builds fail. Please add support
for DEB_BUILD_OPTIONS=nocheck. I am proposing the attached patch to
implement it.

Helmut
-------------- next part --------------
diff --minimal -Nru nspr-4.12/debian/changelog nspr-4.12/debian/changelog
--- nspr-4.12/debian/changelog	2016-08-08 04:04:39.000000000 +0200
+++ nspr-4.12/debian/changelog	2016-08-08 15:44:02.000000000 +0200
@@ -1,3 +1,10 @@
+nspr (2:4.12-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Honour DEB_BUILD_OPTIONS=nocheck. Closes: #-1
+
+ -- Helmut Grohne <helmut at subdivi.de>  Mon, 08 Aug 2016 15:43:51 +0200
+
 nspr (2:4.12-3) unstable; urgency=medium
 
   * debian/control, debian/libnspr4.symbols, debian/libnspr4-0d*: Remove the
diff --minimal -Nru nspr-4.12/debian/rules nspr-4.12/debian/rules
--- nspr-4.12/debian/rules	2016-08-08 04:04:39.000000000 +0200
+++ nspr-4.12/debian/rules	2016-08-08 15:43:41.000000000 +0200
@@ -76,6 +76,7 @@
 	dh_makeshlibs -a -- -c4
 
 override_dh_auto_test:
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 	$(MAKE) -C nspr/pr/tests
 	$(MAKE) -C nspr/lib/tests
 	# Skip gethost because it needs DNS, and thus networking
@@ -84,6 +85,7 @@
 	cd nspr/pr/tests && grep -v '^\(fdcach\|gethost\|peek\|socket\|vercheck\)$$' ./runtests.sh | sh
 	cd nspr/lib/tests && ./base64t
 	cd nspr/lib/tests && ./string
+endif
 
 ifneq (,$(DEB_HOST_MULTIARCH))
 override_dh_gencontrol:


More information about the pkg-mozilla-maintainers mailing list