[Pkg-mutt-maintainers] mutt-1.6.2, or neomutt?

[Kevin J. McCarthy]

On Sun, Aug 14, 2016 at 07:17:44PM +0300, Faidon Liambotis wrote:
> On Mon, Aug 08, 2016 at 02:24:46PM -0700, Kevin J. McCarthy wrote:
> I just uploaded a 1.6.2-2 that contains these three commits. I also
> briefly touched base with Richard and he said he has imported this into
> the neomutt git, so they'll make it on the next neomutt release as well.

That's great.  Thank you!

> > This is definitely in your purview, but I personally would feel better
> > to see the patches separated.  At the least, it gives me something to
> > look at and evaluate applying individually.
> 
> My understanding is that Richard is going through a lot of extra hoops
> to provide all the neomutt patches into separate git branches and
> separate broken-out unified diffs, precisely so that they can be
> upstream material. Is that not an accurate understanding?

Ah.  You may be right.  Previously, I'd gotten used to looking at distro
patch files, but maybe I need to take a closer look at this once I get
1.7 out.  I did get the starting point for the sidebar from one of his
branches, but I haven't spent a lot of time looking at his site yet.

> > A concern I have is that it feels like NeoMutt has taken about _every_
> > patch out there and merged it.  Perhaps some of them should have been
> > merged a long time ago, but I'm concerned others shouldn't have been
> > (and should not be).  I'm also concerned that once exposed to Debian
> > users, some may turn into another "nntp patch" that can never be taken
> > away.  So this is yet another reason I'd feel better if you had them
> > broken down and knew exactly what features you were adding.
> 
> That is definitely a legitimate concern. Do you know already of any
> specific patches that you have doubts over?

Not anything specific yet.  The sidebar, for instance, didn't just add a
sidebar.  It also changed how the buffy-check worked, and in fact did so
incorrectly.  Merging it took a fair amount of work to fix and to
separate the "sidebar" feature, from the "enhanced buffy" feature (which
is now controlled by $mail_check_stats and $mail_check_stats_interval).

Also, recently someone on mutt-dev submitted a patch series adding
mail-stats to the browser in directory mode.  I didn't accept it,
because with the enhanced buffy, it made more sense to grab the info
from there.  That way it also worked for all kinds of mailboxes.

I need to actually start looking at the patches, but these are the kinds
of things I worry about.  Sometimes the basic idea is okay, but the
implementation is not the right way to go about it.  If the idea is
really good, then it's worth it to fix and get it right, but perhaps
not!

-Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-mutt-maintainers/attachments/20160814/59623565/attachment.sig>