[Pkg-mutt-maintainers] Bug#860176: mutt: segfaults when trying to show a progress bar

[Alberto Garcia]

Package: mutt
Version: 1.7.2-1
Severity: normal
Tags: patch

Hi,

mutt crashes when I'm trying to pipe messages through an external
program because 228671-pipe-mime.patch (from Debian bug #569279) needs
to be updated.

This is the code:

   int imap_fetch_message (CONTEXT *ctx, MESSAGE *msg, int msgno)
   {
     /* ... */
     progress_t progressbar, *pbar;
     /* ... */
     if (!isendwin())
     {
       mutt_progress_init (&progressbar, _("Fetching message..."),
                           MUTT_PROGRESS_SIZE, NetInc, bytes);
       pbar = &progressbar;
     }
     else
       pbar = NULL;
     if (imap_read_literal (msg->fp, idata, bytes, &progressbar) < 0)
     /* ... */
   }

As you can see the code is passing &progressbar to imap_read_literal()
but chances are that that variable has not been uninitialized.

Simply replacing &progressbar with pbar in that call and refreshing
the patch fixes the problem.

Berto

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mutt depends on:
ii  libassuan0        2.4.3-2
ii  libc6             2.24-9
ii  libcomerr2        1.43.4-2
ii  libgnutls30       3.5.8-3
ii  libgpg-error0     1.26-2
ii  libgpgme11        1.8.0-3+b2
ii  libgssapi-krb5-2  1.15-1
ii  libidn11          1.33-1
ii  libk5crypto3      1.15-1
ii  libkrb5-3         1.15-1
ii  libncursesw5      6.0+20161126-1
ii  libnotmuch4       0.23.7-3
ii  libsasl2-2        2.1.27~101-g0780600+dfsg-3
ii  libtinfo5         6.0+20161126-1
ii  libtokyocabinet9  1.4.48-11+b1

Versions of packages mutt recommends:
ii  libsasl2-modules  2.1.27~101-g0780600+dfsg-3
ii  locales           2.24-9
ii  mime-support      3.60

Versions of packages mutt suggests:
ii  aspell                                     0.60.7~20110707-3+b2
ii  ca-certificates                            20161130
ii  exim4-daemon-light [mail-transport-agent]  4.88-5
ii  gnupg                                      2.1.18-6
ii  ispell                                     3.4.00-5
pn  mixmaster                                  <none>
ii  openssl                                    1.1.0e-1
pn  urlview                                    <none>

Versions of packages mutt is related to:
ii  mutt  1.7.2-1

-- no debconf information