[Pkg-mutt-maintainers] Bug#860176: Bug#860176: mutt: segfaults when trying to show a progress bar

[Antonio Radici]

On Wed, Apr 12, 2017 at 05:52:33PM +0300, Alberto Garcia wrote:
> Package: mutt
> Version: 1.7.2-1
> Severity: normal
> Tags: patch
> 
> Hi,
> 
> mutt crashes when I'm trying to pipe messages through an external
> program because 228671-pipe-mime.patch (from Debian bug #569279) needs
> to be updated.
> 
> This is the code:
> 
>    int imap_fetch_message (CONTEXT *ctx, MESSAGE *msg, int msgno)
>    {
>      /* ... */
>      progress_t progressbar, *pbar;
>      /* ... */
>      if (!isendwin())
>      {
>        mutt_progress_init (&progressbar, _("Fetching message..."),
>                            MUTT_PROGRESS_SIZE, NetInc, bytes);
>        pbar = &progressbar;
>      }
>      else
>        pbar = NULL;
>      if (imap_read_literal (msg->fp, idata, bytes, &progressbar) < 0)
>      /* ... */
>    }
> 
> As you can see the code is passing &progressbar to imap_read_literal()
> but chances are that that variable has not been uninitialized.
> 
> Simply replacing &progressbar with pbar in that call and refreshing
> the patch fixes the problem.
> 

This sounds like a bug that should be fixed before stretch is released, I'll
submit your patch on Monday.