[Pkg-nethack-devel] Re: Why does SCORE_ON_BOTL affect save/bones files?

[Pat Rankin]

>From Joshua Kwan <joshk@triplehelix.org>:
> Excerpt from makedefs.c:
>
> #ifdef SCORE_ON_BOTL
>                       | (1L << 21)
> #endif
>
> affecting version.feature_set. Should it really be doing so? AFAIK
> having your score on the bottom line will not cause savefile/bones
> inconsistencies.
>
> This is re: Debian bug #139764. <http://bugs.debian.org/139764>

     You need to look at include/flag.h too.  The flags structure is
written to the save file; adding or removing any fields turns a save
file into junk.  It doesn't affect bones files, but nethack's sanity
checking for data files isn't fine-grained enough to deal with that.

     Probably the flag variables for the showexp and showscore options
should be included unconditionally so that toggling either EXP_ON_BOTL
or SCORE_ON_BOTL or both won't cause trouble; there'd be no harm in
having one or two unused booleans when those features aren't enabled.
But such a change can't be made to 3.4.x without throwing away existing
files; it will have to wait for a more substantial version update.