[Pkg-owncloud-commits] [owncloud-client] 23/70: Updater: Free tmp variable that might point to temp malloced memory

Sandro Knauß hefee-guest at moszumanska.debian.org
Tue Jul 1 10:21:19 UTC 2014


This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit d0c992c991064f9b5e1162848f8b9d79bf26ef29
Author: Klaas Freitag <freitag at owncloud.com>
Date:   Fri Jun 20 10:41:01 2014 +0200

    Updater: Free tmp variable that might point to temp malloced memory
    
    This fixes Coverity CID 12900
---
 csync/src/csync_update.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/csync/src/csync_update.c b/csync/src/csync_update.c
index 3ec6b19..455800b 100644
--- a/csync/src/csync_update.c
+++ b/csync/src/csync_update.c
@@ -274,6 +274,9 @@ static int _csync_detect_update(CSYNC *ctx, const char *file,
     } else {
         enum csync_vio_file_type_e tmp_vio_type = CSYNC_VIO_FILE_TYPE_UNKNOWN;
 
+        /* tmp might point to malloc mem, so free it here before reusing tmp  */
+        SAFE_FREE(tmp);
+
         /* check if it's a file and has been renamed */
         if (ctx->current == LOCAL_REPLICA) {
             CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE, "Checking for rename based on inode # %" PRId64 "", (uint64_t) fs->inode);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git



More information about the Pkg-owncloud-commits mailing list