[Pkg-owncloud-commits] [owncloud-client] 24/70: Fix use-after-free in QNAM propagator

[Sandro Knauß]

This is an automated email from the git hooks/post-receive script.

hefee-guest pushed a commit to branch master
in repository owncloud-client.

commit 6b041b084612ff3759eefc19da85c86318d4053c
Author: Daniel Molkentin <danimo at owncloud.com>
Date:   Fri Jun 20 10:34:07 2014 +0200

    Fix use-after-free in QNAM propagator
    
    This fixes Coverity CID 12929
---
 src/mirall/propagator_qnam.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mirall/propagator_qnam.cpp b/src/mirall/propagator_qnam.cpp
index 589f6b8..303034d 100644
--- a/src/mirall/propagator_qnam.cpp
+++ b/src/mirall/propagator_qnam.cpp
@@ -231,10 +231,9 @@ void PropagateUploadFileQNAM::startNextChunk()
         connect(_job, SIGNAL(uploadProgress(qint64,qint64)), this, SLOT(slotUploadProgress(qint64,qint64)));
         _job->start();
     } else {
-        delete device;
-
         qDebug() << "ERR: Could not open upload file: " << device->errorString();
         done( SyncFileItem::NormalError, device->errorString() );
+        delete device;
         return;
     }
 }

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-owncloud/owncloud-client.git