[php-maint] FW: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_compile.c zend_compile.h zend_execute.c zend_execute.h zend_hash.c zend_hash.h zend_language_parser.y zend_object_handlers.c zend_vm_def.h zend_vm_execute.h /tests bug35106.phpt b

[Ralph Schindler]

Hey Andi,
   This was actually one of my pet peeves as well even before 1.0.  The 
original bug report is here:

http://framework.zend.com/issues/browse/ZF-507

If at all possible, I would like to see the coding standards doc at

http://framework.zend.com/wiki/display/ZFDEV/PHP+Coding+Standard+(draft)

formalized (it still says draft on the wiki).  If you'd like to 
coordinate some effort on formalizing that doc so that we can have 
sample file and class docblocks in the "Coding Standards" page and I am 
more than willing to help cleanup the whole production library to 
reflect such changes before 1.1.

I also have a few requests that we add to the docblocks that I'll add to 
the issue.  If we are gonna do a sweep of the codebase, we might as well 
add all the things that should be there, not just the proper license 
information. See issue above for comprehensive list.

-ralph



Andi Gutmans wrote:
> Hi Sean,
> 
> Thanks for looking into this.
> Seems there's definitely an oversight there. All pieces of Zend Framework are licensed under the New BSD license. Here's our fixed license URL although we'll probably make the bogus one redirect (http://framework.zend.com/license ).
> Will fix the bugglets in the coming days.
> 
> Best,
> 
> Andi
> 
>> -----Original Message-----
>> From: sean finney [mailto:seanius at debian.org]
>> Sent: Sunday, September 09, 2007 2:52 AM
>> To: Raphael Geissert
>> Cc: Andi Gutmans; pkg-php-maint at lists.alioth.debian.org
>> Subject: Re: [php-maint] FW: [ZEND-ENGINE-CVS] cvs:
>> ZendEngine2(PHP_5_2) / zend_compile.c zend_compile.h zend_execute.c
>> zend_execute.h zend_hash.c zend_hash.h zend_language_parser.y
>> zend_object_handlers.c zend_vm_def.h zend_vm_execute.h /tests
>> bug35106.phpt b
>>
>> hi raphael, andi,
>>
>> On Sunday 09 September 2007 01:51:48 am Raphael Geissert wrote:
>>> Hi Sean,
>>>
>>> I've already talked to Anibal and there's no problem. These are all
>>> the php-related packages I've pending:
>>>
>>> http://mentors.debian.net/debian/pool/main/l/libphp-amf/libphp-
>> amf_1.2.6-1.
>>> dsc
>>>
>>> http://mentors.debian.net/debian/pool/main/z/zend-framework/zend-
>> framew
>>> ork_
>>> 1.0.1-1.dsc
>> cool!  i haven't actually tried the package out only because i'm not
>> horribly familiar (i.e. at all) with the zend framework, but it passes
>> lintian without any warnings, and looks good from a quick overview.
>>
>> i also checked the licensing, as that's been an issue in the past with
>> other debianized packages of php/pear stuff.  I don't see any
>> significant problems with that here though, since pretty much
>> everything seems  to be under a BSD style license instead of the php v3
>> license.
>>
>> *however*, there are a few exceptions to the above, which need to get
>> fixed before i could sign off on it.  i would count an email from
>> someone at zend saying, "oh, that was an oversight/typo/omission" or
>> "you can use this new bsd license for that too" as "fixed", assuming
>> that some day it will actually be fixed.
>>
>> - many of the files refer to the license at
>> 	http://www.zend.com/license/framework/1_0.txt
>>   which 404's for me.  i'm guessing that these haven't been updated
>>   to the "new-bsd" license?  grep puts the number of files at around
>> 120, so
>>   i won't bother trying to list them here.
>> - one file:
>> 	./demos/Zend/Gdata/Blogger.php:
>>   seems to still use the PHP license.  i don't think this is ought to
>> be a
>>   problem, but the ftp-master (the gatekeepers for new software in
>>   debian) take a particularly hard line on this license and it may
>> require
>>   arguing/justifying later on if they decide to get picky.
>> - also, many of the files refer to the file LICENSE as having the
>> copyright
>>   info, when it is in fact LICENSE.txt.  hardly worth mentioning, but
>> since
>>   i was already looking i might as well mention it :)
>>
>> so, if someone from zend could follow up on these issues, and if you
>> could put their statements following up on the issue in
>> ./debian/copyright, i'd be happy to sign off on it.
>>
>> oh, btw, i've added you to the pkg-php alioth group now, so you should
>> have svn access.  i'll send another email about that shortly.
>>
>>
>> 	sean
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-php-maint
>