[php-maint] php-imagick uploaded to mentors

[Guillaume Delacour]

Raphael Geissert a écrit :
> Hi,
> 
> On 14 March 2010 10:48, Guillaume Delacour <gui at iroqwa.org> wrote:
>> Hello,
>>
>> I have uploaded the php-imagick-3.0.0~rc1 on mentors with severals
>> improvements (pointed out by Ivan, by me and bug reporters).
>>
> 
> Taking a look at the package, there are some minor issues:

Thanks for this.

> 
> * Please don't use tarballs inside tarballs. This makes diff'ing
> upstream code changes unnecessarily more complex.

I've dropped the tarball.mk class to manage the upstream source as a dir.

> 
> debian/control:
> * is Ola Lundqvist still really going to co-maint the package?

I don't think so, he is just the previous co-maintainer (uploader ?) of
the package. I've removed it from Uploader field for now.

> 
> debian/*post{inst,rm}:
> * The module enabling/disabling is unnecessary and will be handled
> later with the inclusion of the extensions manager.

I just discovered your proposal on the extension manager. I don't know
if i have to adapt the package to use it now...

> * I really don't understand why ucf is used in the first place, but
> that's "fine."

Previous postinstallation of previous maintainers.

> 
> debian/rules:
>> patch: apply-patches
> useless because the apply-patches target doesn't exist

Deleted

> * Not sure it is worth adding all the phpX stuff, but well...
>   - if you are still going ahead with it, then:
>   a) the calls to phpize also need versioned
>   b) phpize --clean only needs to be called during the clean target
Done
>   c) you can't use DEB_SRCDIR directly, as adding another dependency
> on configure_for_php% would overwrite what the previous one did. This
> is not what you want
> * If you are using cdbs why don't you just use its autotools class?

I'm not very familiar with cdbs, and i don't know if it is a good thing
 to have a different packaging method than other php related packages.
I would prefer to have an example for another module for php-imagick
packaging, any advices ?

> 
> debian/TODO:
> * The re2c warning is useless for anything but php itself. So, no, you
> don't need to do anything about it.

Ok, i've deleted the file :)

> 
> debian/watch:
> * You need to mangle the upstream versions, otherwise it reports:
> Newest version on remote site is 3.0.0b2, local version is 3.0.0~rc1

I lacked time to try to fix it some days ago and learn a bit more on
uscan/watch; i modified it to:

version=3
opts="uversionmangle=s/RC/rc/,dversionmangle=s/~//" \
	http://pecl.php.net/package/imagick /get/imagick-(.+)\.tgz

and it seems to be ok.

> 
> Cheers,


-- 
Guillaume Delacour

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20100324/ddee306f/attachment.pgp>