[php-maint] Alioth group membership / git access

[John Morrissey]

On Wed, Oct 20, 2010 at 11:05:01AM +0800, Thomas Goirand wrote:
> On 10/18/2010 11:07 PM, John Morrissey wrote:
> > Also, the only copyright notice in Net_DNS is for Eric Kilfoil
> > <eric at ypass.net>. Those who have worked on the PEAR module are listed as
> > "maintainers." Should I keep the single 'Upstream Authors' section in
> > debian/copyright and list all of them
> 
> Yes, you should *always* list everyone. Don't care too much about what
> you see in a copyright notice, as in general, people tend to forget code
> that they grabbed. Have a look in every single source file, use
> something like "grep -r -i \(c\) *" and such to make sure you see every
> copyright in all files, etc.

I went through all three packages and double-checked the copyright
information on all files. I had one change to make for php-net-dns.

> > I left this as CDBS since the previous maintainer used it, since I
> > imagined it was bad form to change the build system completely in the
> > first upload after adopting.
> 
> I didn't have a look much on this package because it was a CDBS. Now I
> had a quick look in your debian/changelog. IMHO, you should replace:
> 
> * New maintainer. (Closes: #529687)
> 
> by:
> 
> * Adopting package (Closes: #529687).
> 
> And because of it, you don't need:
> 
> * Remove Ola Lundqvist <opal at debian.org> as uploader, with his OK.
> 
> You should make one statement per modification, and it's obvious that if
> you are adopting the package, you are now the maintainer

Changed.

> > I'll get rid of CDBS and move it to debhelper.
> 
> This was *not* a requirement, it's just that I don't do CDBS stuff, and
> that you would need somebody else to review it. You can switch to
> debhelper *if you want* to do it.

nod. I wouldn't offer if I didn't want to. :-)

I think these packages should be pretty solid at this point; would you take
another look at them, please?

http://horde.net/~jwm/debian/php-crypt-blowfish_1.1.0rc2-1.dsc
http://horde.net/~jwm/debian/php-net-dns_1.0.5-1.dsc
http://horde.net/~jwm/debian/php-services-weather_1.4.5-1.dsc

-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__