[php-maint] Bug#618680: Bug#618680: php-image-barcode: Uses depreciated methods

Tobias Frost tobi at frost.de
Tue Jul 19 17:48:26 UTC 2011


Am Montag, den 18.07.2011, 12:14 +0200 schrieb Martin Schulze:

Well, I only use the return-to-webbrowser feature....

Looking back, I can only quote the one who wrote the patch:
See http://pear.php.net/bugs/bug.php?id=10594.


However, looking at the code I have to assume that you are right.
It should probably be...

> +	       return null;
>          } else {
> +            return $img;
> -           $img = null;
>          }
> +     return $img;

Tobi

> Hi!

> I wonder if you are aware that this patch effectively results in the
> function returning NULL when $bSendToBrowser is set to false (e.g. if
> the programmer would like to store the image into a file instead of
> sending it to the browser directly).
> 
> Regards,
> 
> 	Joey
> 






More information about the pkg-php-maint mailing list