[php-maint] Bug#618680: Bug#618680: php-image-barcode: Uses depreciated methods
Martin Schulze
joey at infodrom.org
Tue Jul 19 20:21:45 UTC 2011
Hi!
Tobias Frost wrote:
> Am Montag, den 18.07.2011, 12:14 +0200 schrieb Martin Schulze:
>
> Well, I only use the return-to-webbrowser feature....
>
> Looking back, I can only quote the one who wrote the patch:
> See http://pear.php.net/bugs/bug.php?id=10594.
>
>
> However, looking at the code I have to assume that you are right.
> It should probably be...
>
> > + return null;
> > } else {
> > + return $img;
> > - $img = null;
> > }
> > + return $img;
That looks a lot better to me.
(the final return seems to be never reached btw.)
Regards,
Joey
--
Whenever you meet yourself you're in a time loop or in front of a mirror.
Please always Cc to me when replying to me on the lists.
More information about the pkg-php-maint
mailing list