[php-maint] Bug#618680: Bug#618680: php-image-barcode: Uses depreciated methods

[Tobias Frost]

Am Dienstag, den 19.07.2011, 22:21 +0200 schrieb Martin Schulze:

> That looks a lot better to me.
> 
> (the final return seems to be never reached btw.)

No, this one is reached when $bSendToBrowser is true. It is needed, as 
the function has to return a reference! (This is the bug reported in the
first place)

However, as $img is destroyed, it would indeed make more sense to return
null in this case, not $img. 
BUT this will again emit the warning from php [see below], so I think
returning an invalid reference is in this case less evil.


Notice: Only variable references should be returned by reference
in /usr/share/php/Image/Barcode.php on line 115



> Regards,
> 
> 	Joey
>