[php-maint] PHPUnit testers wanted (2nd query)

[Thomas Goirand]

On 03/01/2011 02:51 PM, Olivier Berger wrote:
> Hi.
> 
> Noone seems to care... anyone, again ?
> 
> Thanks in advance.

Hi Olivier,

Thanks for the great amount of time you seemed to take to package
phpunit. I started reviewing php-text-template, as I think it's best to
go from the leaf of the dependencies, and slowly go to the big one
needing them all (I also work this way when building my own packages).

Let me start...

Trying to build php-text-template, using:

git-buildpackage --git-upstream-branch=upstream --git-debian-branch=master

it fails with the following message:

dh_testdir
touch build-stamp
/usr/bin/pear -v -v -v \
		package package.xml
Error: Unknown channel "pear.phpunit.de"
Parsing of package.xml from file "package.xml" failed
Cannot package, errors in package file
make: *** [build] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
debuild: fatal error at line 1325:
dpkg-buildpackage -rfakeroot -D -us -uc -i -I failed
debuild -i -I returned 29
Couldn't run 'debuild -i -I'

Am I mistaking with the branch names? If so, then maybe you should
consider using "upstream-sid" and "debian-sid" as branch names, as it
appears that this is the standard that other members of pkg-php are
using (so I used it too for my own packages...).

By the way, php-text-template has other issues:
- It doesn't depend on php-pear
- there's a useless configure: target in debian/rules
- I don't understand why you commented the rm -rf in your debian/rules
- debian/control has a wrong Vcs-Git (it should be the URL in Alioth).
Note that many many users are doing the same mistake, and I did as well
at the beginning...
- your long description is even shorter than the short one
- your debian/dirs file is useless since pear will install things there
- I would suggest that your debian/copyright file uses the machine
readable format (it's currently a candidate, so it's only a (strong)
suggestion for the moment)
- You shouldn't be using debian/install, but pear to install stuff.
Something like this would do:

$(PEAR) install -f -n -R debian/$(package) $(pear_pkg)/package.xml

(and then the rm -rf are making sense...)
- Your debian/README.Debian doesn't give any information (especially
since the Homepage field is set correctly)
- The stuff in your debian/README.source shouldn't be that, IMHO. Also,
if you just clonned from upstream, it would be nice to tell when, and
what sha256

Finally, it would be really great if you could avoid having too many
entries in your git log. For now, a single entry for the debian folder
should be enough (and it should be reasonably easy to collapse them all
into a unique one). This is to make it more easy to dig for issues later
on, and avoid huge time when doing "git pull".

Let me know what you think of the above. I can continue to work with you
on this package, have it finalized, and then we can move to the next
one. What do you think?

Hoping that the above helps,

Cheers,

Thomas