[php-maint] PHPUnit testers wanted (2nd query)

[Arthur Gautier]

On Tue, Mar 01, 2011 at 07:34:48PM +0800, Thomas Goirand wrote:
 
> Hi Olivier,
> 
> Thanks for the great amount of time you seemed to take to package
> phpunit. I started reviewing php-text-template, as I think it's best to
> go from the leaf of the dependencies, and slowly go to the big one
> needing them all (I also work this way when building my own packages).
> 
> Let me start...
> 
> Trying to build php-text-template, using:
> 
> git-buildpackage --git-upstream-branch=upstream --git-debian-branch=master
> 
> it fails with the following message:
> 
> dh_testdir
> touch build-stamp
> /usr/bin/pear -v -v -v \
> 		package package.xml
> Error: Unknown channel "pear.phpunit.de"
> Parsing of package.xml from file "package.xml" failed
> Cannot package, errors in package file
> make: *** [build] Error 1
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
> debuild: fatal error at line 1325:
> dpkg-buildpackage -rfakeroot -D -us -uc -i -I failed
> debuild -i -I returned 29
> Couldn't run 'debuild -i -I'
> 
I think this is the issue i had with php-timer and i did fix here:
http://git.debian.org/?p=pkg-php/php-timer.git;a=blob;f=debian/rules;h=570bfe466fa920faba9886a9980c7901e007c415;hb=HEAD

The problem is : phpunit uses it's own pear channel, and you need to add
it to your local installation to pear against the package.

I will try to fix other packages like so.

> [...]
> By the way, php-text-template has other issues:
> - It doesn't depend on php-pear
> - there's a useless configure: target in debian/rules
> - I don't understand why you commented the rm -rf in your debian/rules
> - debian/control has a wrong Vcs-Git (it should be the URL in Alioth).
> Note that many many users are doing the same mistake, and I did as well
> at the beginning...
I think this's my bad
> - your long description is even shorter than the short one
> - your debian/dirs file is useless since pear will install things there
> - I would suggest that your debian/copyright file uses the machine
> readable format (it's currently a candidate, so it's only a (strong)
> suggestion for the moment)
this ? http://dep.debian.net/deps/dep5/
> - You shouldn't be using debian/install, but pear to install stuff.
> Something like this would do:
> 
> $(PEAR) install -f -n -R debian/$(package) $(pear_pkg)/package.xml
> 
> (and then the rm -rf are making sense...)
Thanks for the tip, i'd duplicated pattern of phpunit packaging. So it
have an error there too.
> [...]
> Finally, it would be really great if you could avoid having too many
> entries in your git log. For now, a single entry for the debian folder
> should be enough (and it should be reasonably easy to collapse them all
> into a unique one). This is to make it more easy to dig for issues later
> on, and avoid huge time when doing "git pull".
Splitting in atomic commits permits to have a more descriptive summary
about every changes. And git pulling time could be avoided by running
git pack-refs on git hook post-update.

-- 
Arthur Gautier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20110302/e09c37f6/attachment-0001.pgp>