[php-maint] PHPUnit testers wanted (2nd query)

[Arthur Gautier]

On Wed, Mar 02, 2011 at 12:47:31PM +0100, Arthur Gautier wrote:
> On Tue, Mar 01, 2011 at 07:34:48PM +0800, Thomas Goirand wrote:
>  
> > Hi Olivier,
> > 
> > Thanks for the great amount of time you seemed to take to package
> > phpunit. I started reviewing php-text-template, as I think it's best to
> > go from the leaf of the dependencies, and slowly go to the big one
> > needing them all (I also work this way when building my own packages).
> > 
> > Let me start...
> > 
> > Trying to build php-text-template, using:
> > 
> > git-buildpackage --git-upstream-branch=upstream --git-debian-branch=master
> > 
> > it fails with the following message:
> > 
> > dh_testdir
> > touch build-stamp
> > /usr/bin/pear -v -v -v \
> > 		package package.xml
> > Error: Unknown channel "pear.phpunit.de"
> > Parsing of package.xml from file "package.xml" failed
> > Cannot package, errors in package file
> > make: *** [build] Error 1
> > dpkg-buildpackage: error: debian/rules build gave error exit status 2
> > debuild: fatal error at line 1325:
> > dpkg-buildpackage -rfakeroot -D -us -uc -i -I failed
> > debuild -i -I returned 29
> > Couldn't run 'debuild -i -I'
> > 
> I think this is the issue i had with php-timer and i did fix here:
> http://git.debian.org/?p=pkg-php/php-timer.git;a=blob;f=debian/rules;h=570bfe466fa920faba9886a9980c7901e007c415;hb=HEAD
> 
> The problem is : phpunit uses it's own pear channel, and you need to add
> it to your local installation to pear against the package.
> 
> I will try to fix other packages like so.
> 
Just pushed fixes for it on : 
 - php-timer, 
 - php-text-template
 - php-token-steam

May you should test it.

There is still one problem with it: we need internet connection in order
to discover the phpunit pear channel (pear.phpunit.de). May i should
provide the .channels/pear.phpunit.de.reg file to avoid this issue. Is
it correct ? is there any other way i didn't see ?
> > [...]
> > By the way, php-text-template has other issues:
> > - It doesn't depend on php-pear
It's now fixed
> > - there's a useless configure: target in debian/rules
I switched debian/rules to cdbs, there is no configure target anymore
> > - I don't understand why you commented the rm -rf in your debian/rules
Neither rm-rfs
> > - debian/control has a wrong Vcs-Git (it should be the URL in Alioth).
> > Note that many many users are doing the same mistake, and I did as well
> > at the beginning...
> I think this's my bada
Fixed in packages :
 - php-timer,
 - php-codecoverage,
 - php-token-stream,
 - php-text-template
> > - your long description is even shorter than the short one
Somehow fixed, the package doesn't provide much functionalities, so not
much to describe.
> > - your debian/dirs file is useless since pear will install things there
I think i need them for cdbs (correct me if i'm wrong)
> > - I would suggest that your debian/copyright file uses the machine
> > readable format (it's currently a candidate, so it's only a (strong)
> > suggestion for the moment)
> this ? http://dep.debian.net/deps/dep5/
Not done yet, 
> > - You shouldn't be using debian/install, but pear to install stuff.
> > Something like this would do:
> > 
> > $(PEAR) install -f -n -R debian/$(package) $(pear_pkg)/package.xml
> > 
To work around pear.phpunit.de channel issue, i needed to change the
php_dir options in pear so i can't use pear install.
By the way, one should use $(PEAR) install -P (and not -R) as describe
in the pear documentation.
> > (and then the rm -rf are making sense...)
> Thanks for the tip, i'd duplicated pattern of phpunit packaging. So it
> have an error there too.
No rm-rfs anymore, cdbs packaging. See upthere


Could you please retest again packages ?

Thank you

-- 
Arthur Gautier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-maint/attachments/20110302/6230a3cc/attachment.pgp>