[php-maint] RFS: php-imagick

[Thomas Goirand]

On 01/03/2012 05:18 AM, Guillaume Delacour wrote:
> Le mardi 03 janvier 2012 à 04:50 +0800, Thomas Goirand a écrit :
>> On 01/03/2012 01:31 AM, Guillaume Delacour wrote:
>>> Hello team,
>>>
>>> I request an uploader for the php5-imagick package that fix a FTBFS due
>>> to changes in ltmain.sh (that was already documented in debian/rules).
>>>
>>> Thanks in advance.
>>
>> Hi Guillaume,
>>
>> Can you give me the link to your .dsc file?
> 
> Absolutely, i forgot to mention it in my previous mail:
> 
> http://mentors.debian.net/debian/pool/main/p/php-imagick/php-imagick_3.1.0~rc1-1.dsc

Hi,

I had a look to your Git repository, and it's kind of weird. The
"master" branch is the one that contains the debian folder, and there's
an "upstream" branch. Normally, we do "master" that would contain the
upstream code, and "debian" as the one holding the Debian folder. I know
it's just conventions, so it doesn't matter much, but it's quite
confusing. Also, I would suggest you to add a debian/gbp.conf file with
content as follow:

[DEFAULT]
upstream-branch = upstream
debian-branch = master

[git-buildpackage]
export-dir = ../build-area/

Since we're a team, I did upload that gbp.conf in your master branch in
alioth! :)

Apart from that, your debian/changelog doesn't close #652200. Please fix
it, then I'll sponsor the upload. If it's a fix from upstrea, then
simply write: New upstream release (Closes: #652200).

It'd be also great if #568349 was fixed. It's not really hard to check
if you've got write access to a file before writing it... has upstream
fixed that, and if not, has it been reported? And what about #610666?

Thomas Goirand (zigo)