[php-maint] Bug#828843: Bug#828843: sessionclean: please add "-xtype f" to find arguments

Ondřej Surý ondrej at sury.org
Tue Jun 28 15:23:29 UTC 2016


Control: tags -1 +wontfix

Hi Clément,

I don't think this is a good idea, as it will cause find to access each
physical file, compare:

newfstatat(AT_FDCWD, "/proc/26840/fd", {st_mode=S_IFDIR|0500, st_size=0,
...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "0", {st_mode=S_IFLNK|0500, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "1", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "2", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "3", {st_mode=S_IFLNK|0500, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "4", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "5", {st_mode=S_IFLNK|0700, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0

and

newfstatat(AT_FDCWD, "/proc/26840/fd", {st_mode=S_IFDIR|0500, st_size=0,
...}, AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "/proc/26840/fd", {st_mode=S_IFDIR|0500, st_size=0,
...}, 0) = 0
newfstatat(AT_FDCWD, "0", {st_mode=S_IFLNK|0500, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "0", {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 3),
...}, 0) = 0
newfstatat(AT_FDCWD, "1", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "1", {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 3),
...}, 0) = 0
newfstatat(AT_FDCWD, "2", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "2", {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 3),
...}, 0) = 0
newfstatat(AT_FDCWD, "3", {st_mode=S_IFLNK|0500, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "3", {st_mode=S_IFIFO|0600, st_size=0, ...}, 0) = 0
newfstatat(AT_FDCWD, "4", {st_mode=S_IFLNK|0300, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "4", {st_mode=S_IFIFO|0600, st_size=0, ...}, 0) = 0
newfstatat(AT_FDCWD, "5", {st_mode=S_IFLNK|0700, st_size=64, ...},
AT_SYMLINK_NOFOLLOW) = 0
newfstatat(AT_FDCWD, "5", {st_mode=S_IFSOCK|0777, st_size=0, ...}, 0) =
0

This would cause some serious performance degradation.

However the new sessionclean script has 2>/dev/null redirection, so it
might also solve this kind of messages.

Cheers,
-- 
Ondřej Surý <ondrej at sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Knot Resolver (https://www.knot-resolver.cz/) – secure, privacy-aware,
fast DNS(SEC) resolver
Vše pro chleba (https://vseprochleba.cz) – Potřeby pro pečení chleba
všeho druhu

On Tue, Jun 28, 2016, at 14:36, Clément Hermann wrote:
> Package: php5-common
> Version: 5.6.22+dfsg-1
> Severity: normal
> 
> Hi,
> 
> in some cases (here: joyent smartos LX zone), there could be broken
> links in /proc/<pid>/fd. On LX zones, for instance, deleted files still
> show a fd link but no destination (on a proper linux kernel, it would
> say "deleted: <path to deleted file>").
> 
> This causes (harmless) errors in the session clean script cron job. It's
> easy to fix by adding "-xtype f" to the find command arguments, to
> prevent find to take broken link into account.
> 
> Thanks !
> 
> -- 
> Clément (nodens)
> 
> -- Package-specific info:
> ==== Additional PHP 5 information ====
> 
> ++++ PHP 5 SAPI (php5query -S): ++++
> 
> ++++ PHP 5 Extensions (php5query -M -v): ++++
> 
> ++++ Configuration files: ++++
> **** /etc/php5/mods-available/pdo.ini ****
> extension=pdo.so
> 
> **** /etc/php5/mods-available/opcache.ini ****
> zend_extension=opcache.so
> 
> 
> -- System Information:
> Debian Release: stretch/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.5.0-2-amd64 (SMP w/4 CPU cores)
> Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages php5-common depends on:
> ii  libc6   2.22-11
> ii  lsof    4.89+dfsg-0.1
> ii  psmisc  22.21-2.1+b1
> ii  sed     4.2.2-7.1
> ii  ucf     3.0036
> 
> php5-common recommends no packages.
> 
> Versions of packages php5-common suggests:
> pn  php5-user-cache  <none>
> 
> Versions of packages php5-cli depends on:
> ii  libbz2-1.0        1.0.6-8
> ii  libc6             2.22-11
> ii  libcomerr2        1.43-3
> ii  libdb5.3          5.3.28-11
> ii  libedit2          3.1-20150325-1+b1
> ii  libgssapi-krb5-2  1.14.2+dfsg-1
> ii  libk5crypto3      1.14.2+dfsg-1
> ii  libkrb5-3         1.14.2+dfsg-1
> ii  libmagic1         1:5.25-2
> ii  libonig2          5.9.6-1
> ii  libpcre3          2:8.38-3.1
> pn  libqdbm14         <none>
> ii  libssl1.0.2       1.0.2h-1
> ii  libxml2           2.9.3+dfsg1-1.2
> ii  mime-support      3.60
> pn  php5-json         <none>
> ii  tzdata            2016d-2
> ii  ucf               3.0036
> ii  zlib1g            1:1.2.8.dfsg-2+b1
> 
> Versions of packages php5-cli recommends:
> pn  php5-readline  <none>
> 
> Versions of packages php5-cli suggests:
> pn  php-pear  <none>
> 
> Versions of packages libapache2-mod-php5 depends on:
> pn  apache2                             <none>
> ii  apache2-bin [apache2-api-20120211]  2.4.20-2
> ii  libbz2-1.0                          1.0.6-8
> ii  libc6                               2.22-11
> ii  libcomerr2                          1.43-3
> ii  libdb5.3                            5.3.28-11
> ii  libgssapi-krb5-2                    1.14.2+dfsg-1
> ii  libk5crypto3                        1.14.2+dfsg-1
> ii  libkrb5-3                           1.14.2+dfsg-1
> ii  libmagic1                           1:5.25-2
> ii  libonig2                            5.9.6-1
> ii  libpcre3                            2:8.38-3.1
> pn  libqdbm14                           <none>
> ii  libssl1.0.2                         1.0.2h-1
> ii  libstdc++6                          6.1.1-5
> ii  libxml2                             2.9.3+dfsg1-1.2
> ii  mime-support                        3.60
> pn  php5-cli                            <none>
> pn  php5-json                           <none>
> ii  tzdata                              2016d-2
> ii  ucf                                 3.0036
> ii  zlib1g                              1:1.2.8.dfsg-2+b1
> 
> Versions of packages libapache2-mod-php5 suggests:
> pn  php-pear  <none>
> 
> -- no debconf information
> 
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint



More information about the pkg-php-maint mailing list