[php-maint] [Pkg-sysvinit-devel] Bug#816503: invoke-rc.d: action reopen-logs is unknown, but proceeding anyway.

[Steve Langasek]

Control: reassign -1 php5-fpm

On Wed, Mar 02, 2016 at 12:45:41PM +0100, Florent B wrote:
> I have a problem on Wheezy servers using logrotate & php5-fpm packages.

> I think the problem is in /usr/sbin/invoke-rc.d file, that's why I report
> it for sysv-rc package.

> When we use a custom /usr/sbin/policy-rc.d script like this one:

> #!/bin/sh
> if [ "$1" = "service-to-not-restart-automatically" ]
> then
>         exit 101
> else
>         exit 0
> fi

> PHP5-FPM logrotate action is reporting an error :

> invoke-rc.d: action reopen-logs is unknown, but proceeding anyway.

> I think this code in /usr/sbin/invoke-rc.d is causing this :

> ## sanity checks and just-in-case warnings.
> case ${ACTION} in
>     start|stop|force-stop|restart|reload|force-reload|status)
>         ;;
>     *)
>         if test "x${POLICYHELPER}" != x && test -x "${POLICYHELPER}" ; then
>             printerror action ${ACTION} is unknown, but proceeding anyway.
>         fi
>         ;;
> esac

> Why printing an error if policy helper script is executable ? I don't
> understand the logic.

Because calling 'invoke-rc.d $foo reopen-logs' is an incorrect use of the
interface.  The invoke-rc.d interface is a) for use in dpkg maintainer
scripts (not from arbitrary scripts included in the package), and b) for
standard init script targets (which 'reopen-logs' is not) that policy-rc.d
can conceivably know about.

Reassigning to php5-fpm.  However, it appears that this issue has also been
fixed in later versions of the php5-fpm package (/etc/logrotate.d/php5-fpm
now invokes '/usr/lib/php5/php5-fpm-reopenlogs' instead of calling
invoke-rc.d).  I'll leave it to the maintainer to close/dupe this bug as
appropriate.

> Action "reopen-logs" is handled by php5-fpm init script.
> 
> Versions of packages :
> 
> $ apt-cache policy php5-fpm logrotate
> php5-fpm:
>   Installed: 5.4.45-0+deb7u2
>   Candidate: 5.4.45-0+deb7u2
> logrotate:
>   Installed: 3.8.1-4
>   Candidate: 3.8.1-4
> 
> I hope I gived enough information about this "bug".
> 
> Tell me if some information are missing.
> 
> Thank you.
> 
> Florent
> 
> -- System Information:
> Debian Release: 7.9
>   APT prefers oldstable-updates
>   APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
> Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages sysv-rc depends on:
> ii  debconf [debconf-2.0]  1.5.49
> ii  insserv                1.14.0-5
> ii  sysvinit-utils         2.88dsf-41+deb7u1
> 
> Versions of packages sysv-rc recommends:
> ii  lsb-base  4.1+Debian8+deb7u1
> 
> Versions of packages sysv-rc suggests:
> pn  bum           <none>
> pn  sysv-rc-conf  <none>
> 
> -- no debconf information
> 
> _______________________________________________
> Pkg-sysvinit-devel mailing list
> Pkg-sysvinit-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel
> 

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org