[Pkg-postgresql-public] postgresql-common testsuite improvements

[Martin Pitt]

Hello Peter,

Peter Eisentraut [2012-07-24 15:32 +0300]:
>       * The tests check that /var/run/postgresql is empty. But pgbouncer
>         uses that as well, so it needs to be stopped as well.  (requires
>         fix for #681978)

Looks fine to me, please commit.

>       * I suppose pgpool and maybe other programs would be affected as
>         well.  Where do we stop?  Is there a smarter way to do this?

There are certainly lots of situations where some tests would fail.
That's quite deliberate -- I'd rather have it that way and investigate
what's wrong than not checking a lot of things which could go wrong
even in very controlled environments. They are robust enough to mostly
survive an autopkgtest run in a minimal environment [1] now.

I guess if you get a test case failure on existing stuff there, you
could just stop the extra service manually and re-run?

>       * Tests that examine the behavior of the pg_ctl -c option fail if
>         the environment already has unlimited core files set.  So reset
>         that for the tests.

Thanks, please commit.

>       * Allow passing tests on the command line
>         (example: ./testsuite ./t/040_*), so you don't need to run the
>         whole thing all the time.

I usually run "perl t/040_upgrade.t" for that directly, which also
skips the second run with the tight umask. But this is harmless and
convenient, so +1 from me. Please commit.

All of these look appropriate to get into Wheezy as well. Current bzr
has two rather important fixes which I want to get into Wheezy, so
I'll see to doing an upload RSN.

Thanks!

Martin


[1] https://jenkins.qa.ubuntu.com/view/Quantal/view/AutoPkg%20Test/job/quantal-adt-postgresql-common/


-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)