[Pkg-postgresql-public] postgresql-common testsuite improvements

[Peter Eisentraut]

On ons, 2012-07-25 at 06:48 +0200, Martin Pitt wrote:
> >       * The tests check that /var/run/postgresql is empty. But pgbouncer
> >         uses that as well, so it needs to be stopped as well.  (requires
> >         fix for #681978)
> 
> Looks fine to me, please commit.

I have left this out for now, because the mentioned bug is still
pending.

> >       * Tests that examine the behavior of the pg_ctl -c option fail if
> >         the environment already has unlimited core files set.  So reset
> >         that for the tests.
> 
> Thanks, please commit.

Done.  (It would be nicer to put this into the test Perl code, but
ulimit in Perl seems to be rather difficult.)

> >       * Allow passing tests on the command line
> >         (example: ./testsuite ./t/040_*), so you don't need to run the
> >         whole thing all the time.
> 
> I usually run "perl t/040_upgrade.t" for that directly, which also
> skips the second run with the tight umask. But this is harmless and
> convenient, so +1 from me. Please commit.

Done.

> All of these look appropriate to get into Wheezy as well. Current bzr
> has two rather important fixes which I want to get into Wheezy, so
> I'll see to doing an upload RSN.

nothing pending from me

> [1] https://jenkins.qa.ubuntu.com/view/Quantal/view/AutoPkg%20Test/job/quantal-adt-postgresql-common/

Nice!