[Pkg-postgresql-public] Bug#635748: [pgadmin3] Does not respect system background colors in "Object browser"

[Rimas Kudelis]

Hi Guillaume,

I just want to say that your patch doesn't quite work as expected. 
Instead of just using system default colour unless custom colour is set, 
Pgadmin actually stores that default colour in server configuration, and 
always sets it explicitly. This isn't a problem until you change the 
theme you use, but once you do (like I switched from light to dark 
theme), all your servers are suddently using a colour that is no longer 
the default.

I think the correct behavior would be not to store colour in the 
configuration unless the user sets it explicitly. This way, even if 
PgAdmin stores the default upon initial creation, the user could clear 
that setting manually and it would then always be treated as empty 
instead of being reset to the default colour on first run. Ideally, it 
would even be possible to disable custom colour via a checkbox or 
something like that.

I made a small patch, which prevents storing the empty setting. However, 
it is incomplete due to the server dialog now erring upon load, because 
it actually expects a colour value. I believe this should be easy to fix 
for someone familiar with the code though.

I'm attaching this half-baked patch. Feel free to apply it if PgAdmin is 
still to be supported for some time.

Cheers,
Rimas Kudelis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pgadmin_use_default_colour.diff
Type: text/x-patch
Size: 1578 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-postgresql-public/attachments/20160917/a3bcbb2c/attachment-0001.bin>