[Pkg-protobuf-devel] protobuf 3 dependencies

[Andrew Pollock]

Hi,

Robert's pointed out that the protobuf upstream autogen.sh sucks down gmock

https://github.com/google/protobuf/blob/master/autogen.sh#L30-L38

This isn't workable long term, because packages should be buildable
without Internet access.

gmock's moved around a bit, and is now part of the Google Test project
at https://github.com/google/googletest and doesn't seem to have any
tarball releases.

I think ultimately gmock should be packaged and referenced as a build
dependency for the protobuf package. For grins, I tried to package the
1.7.0 release that autogen.sh sucks down, but out of the box, that's
not how it rolls:

Making install in gtest
make[2]: Entering directory '/home/apollock/debian/gmock/gmock-1.7.0/gtest'
make[3]: Entering directory '/home/apollock/debian/gmock/gmock-1.7.0/gtest'
echo "'make install' is dangerous and not supported. Instead, see
README for how to integrate Google Test into your build system."
'make install' is dangerous and not supported. Instead, see README for
how to integrate Google Test into your build system.
false
Makefile:1351: recipe for target 'install-exec-local' failed
make[3]: *** [install-exec-local] Error 1
make[3]: Leaving directory '/home/apollock/debian/gmock/gmock-1.7.0/gtest'
Makefile:1190: recipe for target 'install-am' failed
make[2]: *** [install-am] Error 2
make[2]: Leaving directory '/home/apollock/debian/gmock/gmock-1.7.0/gtest'
Makefile:753: recipe for target 'install-recursive' failed
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory '/home/apollock/debian/gmock/gmock-1.7.0'
dh_auto_install: make -j1 install
DESTDIR=/home/apollock/debian/gmock/gmock-1.7.0/debian/tmp
AM_UPDATE_INFO_DIR=no returned exit code 2
debian/rules:22: recipe for target 'binary' failed
make: *** [binary] Error 2

If I'm understanding correctly how gmock gets used, it's exactly as a
build dependency, so it should be able to be installed like any other
-dev package would, and then protobuf can use it accordingly.

I think as a way forward in the interim, we just don't run any tests
as part of the package build process...

Thoughts?

regards

Andrew