[Pkg-sql-ledger-discussion] Review of ledgersmb 1.3.10-1

[Robert James Clay]

Raphael,

   Sorry about the delay with this;  had some other things I needed to
work on. 

On Thu, 2012-01-19 at 14:48 -0500, Raphael Hertzog wrote:

> IMO you should install /etc/apache2/conf.d/ledgersmb-httpd.conf as
> "conffile" managed by dpkg and be done with it.

    And that should be taken care of by putting it in
d/ledgersmb.install, right?    


> Another weird thing to investigate: debian/patches/05_confdir.patch
> doesn't modify the $templates variable yet it probably should since
> you install templates in /etc/ledgersmb/templates and not in
> /usr/share/ledgersmb/.

   I don't know why they put that there (/var/lib/ledgersmb seems more
correct to me...) but regardless, that variable should be getting
updated for the debian install like the rest of the paths.  I'll need to
investigate this some more.


> 	[ ! -e LedgerSMB/Assets ] || rmdir LedgerSMB/Assets
> 	[ ! -e LedgerSMB/Entity ] || rmdir LedgerSMB/Entity
> 
> Why not just "rm -rf LedgerSMB/Assets LedgerSMB/Entity"
>  or "rmdir --ignore-fail-on-non-empty LedgerSMB/Assets LedgerSMB/Entity" ?

    Those are empty left over directories that, IIRC, upstream has not
gotten around to removing so I don't expect them to show up with
anything in them.  And they're separate directories and I'm used to
handling such things separately.  OTOH;  if any of that changes, that
part of the script would need to be changed anyway...


> override_dh_auto_clean:
>         dh_auto_clean
>         rm -f ledgersmb.conf
>         rm -f ledgersmb-httpd.conf
> 
> Put ledgersmb.conf & ledgersmb-httpd.conf in debian/clean and let
> dh_clean drop the files for you.

   I've tried a change for that but I'm not sure I did it correctly: I
don't see dh_clean actually running in the test builds I did after the
change & I thought it was one of the ones that dh runs automatically.
Need to investigate that some more.





Jame