[Pkg-sql-ledger-discussion] Review of ledgersmb 1.3.10-1

[Raphael Hertzog]

Hi,

On Tue, 14 Feb 2012, Robert James Clay wrote:
> On Thu, 2012-01-19 at 14:48 -0500, Raphael Hertzog wrote:
> 
> > IMO you should install /etc/apache2/conf.d/ledgersmb-httpd.conf as
> > "conffile" managed by dpkg and be done with it.
> 
>     And that should be taken care of by putting it in
> d/ledgersmb.install, right?    

Yes, debhelper marks any file shipped in /etc as conffile.

> > Another weird thing to investigate: debian/patches/05_confdir.patch
> > doesn't modify the $templates variable yet it probably should since
> > you install templates in /etc/ledgersmb/templates and not in
> > /usr/share/ledgersmb/.
> 
>    I don't know why they put that there (/var/lib/ledgersmb seems more
> correct to me...) but regardless, that variable should be getting
> updated for the debian install like the rest of the paths.  I'll need to
> investigate this some more.

If editing those files is the usual way to modify the templates, then
/etc seems correct since you want to preserve modifications made by the
user.

But it's true that for sql-ledger, the files are never modified, instead
they are copied in a another directory where they are modified. In that
case /etc seems useless and sql-ledger uses thus
/var/lib/sql-ledger/templates.

> > override_dh_auto_clean:
> >         dh_auto_clean
> >         rm -f ledgersmb.conf
> >         rm -f ledgersmb-httpd.conf
> > 
> > Put ledgersmb.conf & ledgersmb-httpd.conf in debian/clean and let
> > dh_clean drop the files for you.
> 
>    I've tried a change for that but I'm not sure I did it correctly: I
> don't see dh_clean actually running in the test builds I did after the
> change & I thought it was one of the ones that dh runs automatically.
> Need to investigate that some more.

$ dh clean --no-act
   dh_testdir
   dh_auto_clean
   dh_clean

It's called at the start of the build process (and at the end if you
specify -tc to dpkg-buildpackage/debuild).

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/