[pkg-squid-devel] Fwd: Bug#767256: unblock: squid3/3.4.8-2

Santiago Garcia Mantinan manty at debian.org
Thu Oct 30 22:27:52 UTC 2014


Hi!

> > A few comments from reviewing the changes:
> > - changelog says bashisms when afaict it meant kshism (the script used
> >  /bin/ksh)

Well, I wrote bashishms because the script could run on bash perfectly like
it was written even though it forced /bin/ksh

> > - the 'grep "Processing:" | sed s/.*Processing:\ // |' pattern in a few
> >  places has a useless use of grep and unquoted shell glob
> > - calling dpkg-statoverride from an init script seems kinda wrong
> >  (though that was there before).

I think we shall fix a couple of things more, for example, today I upgraded
one of my machines: Unpacking squid3-common (3.4.8-2) over (3.3.8-1.2) ...

And the result was that the squid -k parse output was shown on my screen.

I hadn't tested these changes on my machine after your commit, but afaik the
squid -k check didn't do that, so... how must we check the config?

Regards.
-- 
Manty/BestiaTester -> http://manty.net



More information about the pkg-squid-devel mailing list