[pkg-squid-devel] Fwd: Bug#767256: unblock: squid3/3.4.8-2

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 31/10/2014 11:27 a.m., Santiago Garcia Mantinan wrote:
> Hi!
> 
>>> A few comments from reviewing the changes: - changelog says
>>> bashisms when afaict it meant kshism (the script used 
>>> /bin/ksh)
> 
> Well, I wrote bashishms because the script could run on bash
> perfectly like it was written even though it forced /bin/ksh
> 
>>> - the 'grep "Processing:" | sed s/.*Processing:\ // |' pattern
>>> in a few places has a useless use of grep and unquoted shell
>>> glob - calling dpkg-statoverride from an init script seems
>>> kinda wrong (though that was there before).
> 
> I think we shall fix a couple of things more, for example, today I
> upgraded one of my machines: Unpacking squid3-common (3.4.8-2) over
> (3.3.8-1.2) ...
> 
> And the result was that the squid -k parse output was shown on my
> screen.

What output in particular?
 It is intentional that you get FATAL messages from the parse - if any
are found.


I only get this -z output that has always been present:

Setting up squid3 (3.4.8-2) ...
Creating Squid HTTP proxy 3.x spool directory structure
2014/10/30 19:44:55 kid1| Set Current Directory to /var/spool/squid3
2014/10/30 19:44:55 kid1| Creating missing swap directories
2014/10/30 19:44:55 kid1| No cache_dir stores are configured.


Nothing on the init script actions which should all be doing -k parse...

root at debian:/src/squid# /etc/init.d/squid3 start
[ ok ] Starting squid3 (via systemctl): squid3.service.
root at debian:/src/squid# /etc/init.d/squid3 stop
[ ok ] Stopping squid3 (via systemctl): squid3.service.
root at debian:/src/squid# /etc/init.d/squid3 restart
[ ok ] Restarting squid3 (via systemctl): squid3.service.
root at debian:/src/squid# /etc/init.d/squid3 start
[ ok ] Starting squid3 (via systemctl): squid3.service.
root at debian:/src/squid# /etc/init.d/squid3 restart
[ ok ] Restarting squid3 (via systemctl): squid3.service.


With a bumped package version and intentionally broken config file I
get this:

dpkg --install squid3_3.4.8-3_i386.deb
(Reading database ... 110573 files and directories currently installed.)
Preparing to unpack squid3_3.4.8-3_i386.deb ...
Unpacking squid3 (3.4.8-3) over (3.4.8-2) ...
Setting up squid3 (3.4.8-3) ...
Installing new version of config file
/etc/resolvconf/update-libc.d/squid3 ...
Creating Squid HTTP proxy 3.x spool directory structure
2014/10/30 19:54:58| /etc/squid3/squid.conf:2 unrecognized: 'foo'
dpkg: error processing package squid3 (--install):
 subprocess installed post-installation script returned error exit
status 1
Processing triggers for man-db (2.7.0.2-2) ...
Errors were encountered while processing:
 squid3

... exactly as intended. Manual fix is required.


With obsolete options that should be handled nicely I get this:

dpkg --install squid3_3.4.8-3_i386.deb
(Reading database ... 110573 files and directories currently installed.)
Preparing to unpack squid3_3.4.8-3_i386.deb ...
Unpacking squid3 (3.4.8-3) over (3.4.8-3) ...
Setting up squid3 (3.4.8-3) ...
Creating Squid HTTP proxy 3.x spool directory structure
2014/10/30 19:59:22| ERROR: Directive 'error_map' is obsolete.
2014/10/30 19:59:23 kid1| ERROR: Directive 'error_map' is obsolete.
2014/10/30 19:59:23 kid1| Set Current Directory to /var/spool/squid3
2014/10/30 19:59:23 kid1| Creating missing swap directories
2014/10/30 19:59:23 kid1| No cache_dir stores are configured.
Processing triggers for man-db (2.7.0.2-2) ...

But these displayed are all from the -z execution, not the -k parse
checking.


We could quieten it a little bit by making it log to syslog, or not
running -z at all if there are no cache_dir. But that is just polish
and a change from previous packages operation.

Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUUv+tAAoJELJo5wb/XPRjadoIAIFl/guSzFw7zlCn3vwVGobR
nWiP16vFlbwYOrWsFo8bawaJV2GMvWP9ickfx+sxtBypv5WCXzye+n6b9+ye+KE2
Am6nToPgbbYfgG22KahFfse0cK4/Su8FIMb58pyvzFg/Yd6KrV3TV3ZnwOj2BYkh
oGUqUqNPj8qLJb0CEkp5jpDwW0WQ8ZodHwx4a8rjxq+qsyBSEyRFgPoVmFOg6pQC
DeF6VQ6W241L87kFokODlGxrJ9uLn5nOqU0lPYX0we26g0xSiHiv6kAbrpV60I7A
UdamohDbUetwdfPoRCyxmU47JXAassDBtTG4hn/A2w3f+bf58jGPLMY5r+e5b+0=
=Ddnk
-----END PGP SIGNATURE-----