Bug#356894: [Swig-devel] Swig 1.3.28 and current CVS breaks subversion bindings

Loïc Minier lool+sf at via.ecp.fr
Thu Mar 23 22:42:16 UTC 2006


        Hi,

On Wed, Mar 22, 2006, Marcelo Matus wrote:
> http://search.cpan.org/~clkao/SVN-Mirror-0.68/lib/SVN/Mirror.pm
> which call the 'set_path' method passing 'lock' as an array instead of 
> the expected "char *" value.
>        my @lock = $SVN::Core::VERSION ge '1.2.0' ? (undef) : ();
>        $reporter->set_path ('', $start, @lock, 0);
[...]
> I guess Jason could tell us more about what would be the expected result 
> in this case,
> ie, a 'char *' string is expected, but an array is passed.

 The problem was with the last argument, not lock, but pool, which
 should be undef and not 0.  I've uploaded a fixed Debian package and
 mailed the attached patch to the author.

   Bye,

-- 
Loïc Minier <lool at dooz.org>
Current Earth status:   NOT DESTROYED
-------------- next part --------------
--- libsvn-mirror-perl-0.68/debian/changelog
+++ libsvn-mirror-perl-0.68/debian/changelog
@@ -1,3 +1,13 @@
+libsvn-mirror-perl (0.68-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Use undef instead of 0 to pass a NULL to svn_ra_reporter2_t.set_path's
+    pool argument which now fails in stricted SWIG bindings and rendered SVK
+    unusable. (Closes: #356894, #357194)
+    [lib/SVN/Mirror/Ra.pm]
+
+ -- Loic Minier <lool at dooz.org>  Thu, 23 Mar 2006 22:20:06 +0100
+
 libsvn-mirror-perl (0.68-1) unstable; urgency=low
 
   * New upstream version.
--- libsvn-mirror-perl-0.68.orig/lib/SVN/Mirror/Ra.pm
+++ libsvn-mirror-perl-0.68/lib/SVN/Mirror/Ra.pm
@@ -521,7 +521,7 @@
             my $reporter =
                 $ra->do_update ($rev, $editor->{target} || '', 1, $editor);
 	    my @lock = $SVN::Core::VERSION ge '1.2.0' ? (undef) : ();
-            $reporter->set_path ('', $start, @lock, 0);
+            $reporter->set_path ('', $start, @lock, undef);
 
             $reporter->finish_report ();
         } else {


More information about the pkg-subversion-maintainers mailing list