[Pkg-tpctl-devel] Re: status of the thinkpad-source package

[Eduard Bloch]

#include <hallo.h>
* martin f krafft [Sun, Jul 30 2006, 08:02:47PM]:
> [Eduard, you are on CC because we need module-assistant help. Read on.]
> 
> Hi,
> 
> Thomas Hood contacted me today and told me that the thinkpad-source
> package in SVN fails to build. This is correct, and the reason is
> simply that I ran out of time adding module-assistant support (which
> is a MAJOR PITA!), and Clint Adams wanted to take a look, so
> I checked in broken code and did not make a branch as I should have.

module-assistant support? After you redefine the rules as you like it
(or actually not), yeah, sure. The first thing burning in my eyes:

What do you try to achieve with stamp files if they have no meaning and
are apparently not removed in the *clean rules?

> However, when I run kdist_build, which causes kdist_config to be run
> and all modules to be compiled, module-assistant calls
> 
>   /usr/bin/make -f debian/rules kdist_clean kdist_config binary-modules
> 
> and for some reason, make says
> 
>   make[1]: Nothing to be done for `kdist_config'.

Your kdist_config rule is "not well designed":

configure-stamp: debian/control debian/postinst debian/postrm

What should it be good for? Every time one of the files change,
configure-stamp shall ge generated? Ok, but if none of them changes and
package is just rebuilt?

You assume that the premisses would be triggered as soon as these files
are changed somewhere in the process, but you should not try to cheat
with make in a such way. It tracks the real dependencies using the state
in the beginning and NOT some temporary state that may be established
during the processing.

> I am CC'ing Eduard on this mail in the hope that he can come to my
> rescue, because quite frankly, I've lost days to module-assistant
> and cannot spend any more on this. Eduard, you can find the code in
> SVN:
> 
>   svn+ssh://svn.debian.org/srv/svn.debian.org/svn/pkg-tpctl/thinkpad/trunk

There is no orig tarball and your copyright file does not show me a
download location. Sorry, WTF?

> Anyway, now you all know what's up and hopefully Eduard can help.
> 
> The code is 6.0-1 already, but I have not looked at any bugs or the
> changes suggested by Thomas Hood.

I do not see what this hocus pocus should be good for. Sorry, guys, I do
not like what you do (or someone did before you). I suggest you make the
stuff work FIRST and then reconsider what cosmetic changes are good for
_before_ doing them. Eg.  what is a changelog good for if it does not
document changes? (unlike the source' package changelog).

Eduard.
-- 
Meckern ist immer leichter, als von anderen angemeckert zu werden.
		-- Wolfgang Bötsch