[Pkg-utopia-devel] pmount stuff

Martin Pitt martin@piware.de
Thu, 28 Oct 2004 14:15:51 +0200


--GID0FwUMdk1T2AWN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Sjoerd!

Sjoerd Simons [2004-10-28 12:42 +0200]:
> On Thu, Oct 28, 2004 at 09:00:20AM +0200, Martin Pitt wrote:
> > >     * It seems that pmount just tries various filesystems, but g-v-m =
already
> > >       knows the filesystem type from hal. Probably would be nice if w=
e could
> > >       give this info to pmount (i think trying several types causes a=
t least
> > >       kernel warnings)
> >=20
> > I can add such an option, if it is desired.
>=20
> I think it would be an improvement, but it's your choice ofcourse :)

added to my TODO list.

> >     if( mounted && expect && uid > 0 && (uid_t) uid !=3D getuid() ) {
> >         fprintf( stderr, "Error: device %s was not mounted by you\n", d=
evice );
> >         return 0;
> >     }
>=20
> Oh didn't expect device_mounted to also check uid :) But this is buggy.. =
If the
> drive is mounted by root (like it was in my tests), anyone is allowed to
> umount.

Oh, right. Thanks for catching this!

> g-v-m for umount is plain wrong imho, we talked about this once :).. I'll=
 send
> a mail to linux-hotplug-devel, what their opinions are about a hotplug sc=
ript
> that runs umount -l (that's what it's about, right)

This would be even better, of course. I think Debian and Ubuntu could
implement this without kernel support. I completely forgot about the
possibility of a hotplug script...

> The only downside is that when a k-v-m (or any other volume manager) is
> packaged, it should also be patched to pass extra options instead of anot=
her
> mount command. Which means extra work, because in the ideal case every vo=
lume
> manager in debian would do basically the same (wrt to mounting) and keepi=
ng
> stuff in sync is tiresome.. Ubuntu ofcourse doesn't have this problem :)

Well, we do have the problem, there are many folks that use Ubuntu
with KDE. In general you are right, but I really want to avoid
dependencies of pmount that are not strictly necessary. The code must
be kept small and without much communication to other things, since it
runs as root.=20

> For now, as soon as the group thing is solved i'll push pmount in g-v-m :=
)..

Oh, great! Please wait for the new upstream version, when I fixed
these issues.

Martin

--=20
Martin Pitt                       http://www.piware.de
Ubuntu Developer            http://www.ubuntulinux.org
Debian GNU/Linux Developer       http://www.debian.org

--GID0FwUMdk1T2AWN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBgOL3DecnbV4Fd/IRAkFCAKC+lYaAqNJlbJ0wxXzJk1VBC3K4uwCghcKU
3G7OiTWi2wCR9w79gGaRF0E=
=l1hB
-----END PGP SIGNATURE-----

--GID0FwUMdk1T2AWN--