Bug#411697: vim maintainer scripts switch on "$1" when they shouldn't

[Stefano Zacchiroli]

tags 411697 + moreinfo help
thanks

On Tue, Feb 20, 2007 at 02:28:44PM +0000, Ian Jackson wrote:
> Many of the vim maintainer scripts only do their processing if the
> invocation context is the most normal one that the script author is
> expecting.  For example, in the postinst of vim_7.0-164+3_i386.deb, we
<snip>
> dpkg's invocations of these scripts are carefully planned so that the
> right behaviour is generally for each script to do the same thing no
> matter why it was called, so for most ordinary situations the right
> thing for a maintainer script is to ignore $1.

Thanks for this inspection.

> I haven't examined in detail all of the maintainer scripts in the vim
> packages, so I can't say with confidence that all of these tests of $1
> are wrong, but all of the ones I have seen seem wrong to me.  The

Could you please list the ones you have found and you believe are wrong
(better if with some motivations) so that we can discuss them?

> If I am currently addressing the person who wrote these scripts

I think the person who originally wrote the scripts is no longer in the
maintenance team of vim, and we, people currently maintaining it,
probably inherited some bad habits from the scripts who were there when
we took over the maintenance.

If you are willing to spend some time, maybe together with some of us,
to thoroughly inspect the scripts spotting where the discrimination upon
$1 are useless/wrong, then that would be much appreciated!

Many thanks in advance,
Cheers.

-- 
Stefano Zacchiroli -*- Computer Science PhD student @ Uny Bologna, Italy
zack@{cs.unibo.it,debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?    /\    All one has to do is hit the
(15:57:15)  Bac: no, la demo scema    \/    right keys at the right time
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-vim-maintainers/attachments/20070220/bd1a4840/attachment.pgp