Bug#503757: vim-runtime: 7.2.049-2 is still failing

James Vega jamessan at jamessan.com
Sat Jan 10 02:46:30 UTC 2009

On Tue, Dec 23, 2008 at 02:23:12PM +0100, Matthijs Kooijman wrote:
> AFAICU, the diversion should not be removed until after the file is
> removed by vim-runtime (ie, in the postinst upgrade and postrm scripts,
> I think?). This would also allow vim-runtime to be upgraded when
> vim-tiny is still installed, and properly restore
> /usr/share/vim/vim71/doc/help.txt to the vim-tiny version.
> I did a quick implementation of this scheme (removing the old diversions
> in postinst configure, see attachment), which solved my upgrading
> problems. This still leaves the vim-tiny versions of help.txt and tags
> littering /usr/share/vim/vim71/, but that makes sense, since the cause
> of the problem seems to be that the vim-tiny files didn't get removed
> properly.

Indeed, this does look to work well.  Thanks for the analysis and patch.

> In other words, removing the diversions later makes the vim-runtime
> package a lot more robust. Removing any .vim-tiny versions that make
> dpkg-divert --remove fail doesn't seem to be the right approach here.

I'm only removing them when vim-tiny isn't installed -- i.e., if they're
left over from previous mishandling of the switch to diversions.

> Note that I don't remove the check_diversion function from preinst in
> my patch (I don't fully know what it does or why it exists either), but
> following the above reasoning I think it might be a bad approach as
> well.

As mentioned, check_diversion only tries to ensure that we're in a
consistent state due to previous mishandling of diversions.  There were
corner-cases where vim-tiny wasn't installed but there were still
diversions setup as if it were.

GPG Key: 1024D/61326D40 2003-09-02 James Vega <jamessan at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-vim-maintainers/attachments/20090109/b56a79ee/attachment.pgp 

More information about the pkg-vim-maintainers mailing list