[Pkg-virtualbox-devel] [RFR] templates://virtualbox-ose/{virtualbox-ose.templates}

[Christian Perrier]

Please find, for review, the debconf templates and packages descriptions for the virtualbox-ose source package.

This review will last from Tuesday, January 15, 2008 to Friday, January 25, 2008.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../virtualbox-ose.old/debian/virtualbox-ose.templates	2008-01-09 13:56:27.748673230 +0100
+++ debian/virtualbox-ose.templates	2008-01-09 20:11:16.613017090 +0100
@@ -3,6 +3,6 @@
 Default: false
 _Description: Proceed with virtualbox-ose upgrade despite losing snapshots?
  You are currently upgrading virtualbox-ose to a new upstream version. All
- snapshots will be discarded by this upgrade, because snapshots are version
- specific.
+ snapshots will be discarded by this upgrade, because snapshots are 
+ version-specific.

Just attach words with an hyphen
 
--- ../virtualbox-ose.old/debian/control	2008-01-09 13:56:27.748673230 +0100
+++ debian/control	2008-01-09 20:17:22.094727280 +0100
@@ -17,24 +17,25 @@
 Conflicts: virtualbox
 Replaces: virtualbox
 Provides: virtualbox
-Description: PC virtualization solution
- VirtualBox is a free x86 virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
+Description: x86 virtualization solution - binaries

Common "general description - specific description" style

+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
  Linux, FreeBSD, DOS, OpenBSD and others.

Use "x86" consistently, over "PC" which is really vague.

  .
- This packages contains the Open Source Edition of VirtualBox.
+ This package provides the binaries for the Open Source Edition of
+ VirtualBox.

Standardize on "this package provides" which we promote in other packages.

Also correct a grammar error.
 
 Package: virtualbox-ose-dbg
 Section: devel
 Priority: extra
 Architecture: amd64 i386
 Depends: virtualbox-ose (= ${binary:Version})
-Description: PC virtualization solution (debug)
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
+Description: x86 virtualization solution - debugging symbols
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
  Linux, FreeBSD, DOS, OpenBSD and others.
  .
- This packages contains the debugging symbols for the Open Source Edition of
+ This package provides the debugging symbols for the Open Source Edition of
  VirtualBox.
 
 Package: virtualbox-ose-source
@@ -43,37 +44,37 @@
 Conflicts: virtualbox-source
 Replaces: virtualbox-source
 Provides: virtualbox-source
-Description: Source for the VirtualBox module
+Description: x86 virtualization solution - kernel module source
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
+ Linux, FreeBSD, DOS, OpenBSD and others.
+ .
  This package provides the source code for the virtualbox kernel module.
  The virtualbox-ose package is also required in order to make use of these
- modules. Kernel source or headers are required to compile this module.
- .
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
- Linux, FreeBSD, DOS, OpenBSD and others.
+ modules. Kernel sources or headers are required to compile this module.

Put the general description first
 
The remaining changes are just repeats of those....


-------------- next part --------------
Template: virtualbox-ose/upstream_version_change
Type: boolean
Default: false
_Description: Proceed with virtualbox-ose upgrade despite losing snapshots?
 You are currently upgrading virtualbox-ose to a new upstream version. All
 snapshots will be discarded by this upgrade, because snapshots are 
 version-specific.

-------------- next part --------------
--- ../virtualbox-ose.old/debian/virtualbox-ose.templates	2008-01-09 13:56:27.748673230 +0100
+++ debian/virtualbox-ose.templates	2008-01-09 20:11:16.613017090 +0100
@@ -3,6 +3,6 @@
 Default: false
 _Description: Proceed with virtualbox-ose upgrade despite losing snapshots?
  You are currently upgrading virtualbox-ose to a new upstream version. All
- snapshots will be discarded by this upgrade, because snapshots are version
- specific.
+ snapshots will be discarded by this upgrade, because snapshots are 
+ version-specific.
 
--- ../virtualbox-ose.old/debian/control	2008-01-09 13:56:27.748673230 +0100
+++ debian/control	2008-01-09 20:17:22.094727280 +0100
@@ -17,24 +17,25 @@
 Conflicts: virtualbox
 Replaces: virtualbox
 Provides: virtualbox
-Description: PC virtualization solution
- VirtualBox is a free x86 virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
+Description: x86 virtualization solution - binaries
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
  Linux, FreeBSD, DOS, OpenBSD and others.
  .
- This packages contains the Open Source Edition of VirtualBox.
+ This package provide the binaries for the Open Source Edition of
+ VirtualBox.
 
 Package: virtualbox-ose-dbg
 Section: devel
 Priority: extra
 Architecture: amd64 i386
 Depends: virtualbox-ose (= ${binary:Version})
-Description: PC virtualization solution (debug)
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
+Description: x86 virtualization solution - debugging symbols
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
  Linux, FreeBSD, DOS, OpenBSD and others.
  .
- This packages contains the debugging symbols for the Open Source Edition of
+ This package provides the debugging symbols for the Open Source Edition of
  VirtualBox.
 
 Package: virtualbox-ose-source
@@ -43,37 +44,37 @@
 Conflicts: virtualbox-source
 Replaces: virtualbox-source
 Provides: virtualbox-source
-Description: Source for the VirtualBox module
+Description: x86 virtualization solution - kernel module source
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
+ Linux, FreeBSD, DOS, OpenBSD and others.
+ .
  This package provides the source code for the virtualbox kernel module.
  The virtualbox-ose package is also required in order to make use of these
- modules. Kernel source or headers are required to compile this module.
- .
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
- Linux, FreeBSD, DOS, OpenBSD and others.
+ modules. Kernel sources or headers are required to compile this module.
 
 Package: virtualbox-ose-guest-source
 Architecture: all
 Depends: debhelper (>= 5), dpatch, module-assistant, bzip2, kbuild
-Description: Source for the VirtualBox Guest Addition module
+Description: x86 virtualization solution - guest addition module source
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
+ Linux, FreeBSD, DOS, OpenBSD and others.
+ .
  This package provides the source code for the virtualbox guest addition kernel
- modules.  The virtualbox-ose-guest package is also required in order to make
- use of these modules. Kernel source or headers are required to compile these
+ modules. The virtualbox-ose-guest package is also required in order to make
+ use of these modules. Kernel sources or headers are required to compile these
  modules.
- .
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
- Linux, FreeBSD, DOS, OpenBSD and others.
 
 Package: virtualbox-ose-guest-utils
 Architecture: i386
 Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
 Recommends: virtualbox-ose-guest-modules
 Suggests: virtualbox-ose-guest-source
-Description: PC virtualization solution - guest utils
- VirtualBox is a free PC virtualization solution allowing you to run a wide
- range of PC operating systems on your Linux system. This includes Windows,
+Description: x86 virtualization solution - guest utilities
+ VirtualBox is a free x86 virtualization solution allowing to run a wide
+ range of x86 operating systems on a Linux system. This includes Windows,
  Linux, FreeBSD, DOS, OpenBSD and others.
  .
- This packages contains the guest utilities of the Open Source Edition of
- VirtualBox. These utilities are supposed to be run inside the virtual machine.
+ This package provides the guest utilities of the Open Source Edition of
+ VirtualBox. These utilities are meant to be run inside the virtual machine.
-------------- next part --------------
Source: virtualbox-ose
Section: misc
Priority: extra
Maintainer: Debian Virtualbox Team  <pkg-virtualbox-devel at lists.alioth.debian.org>
Uploaders: Philipp Hug <debian at hug.cx>, Marvin Stark <marv at der-marv.de>, Michael Meskes <meskes at debian.org>, Patrick Winnertz <winnie at debian.org>, Daniel Baumann <daniel at debian.org>, Hilko Bengen <bengen at debian.org>
Build-Depends: debhelper (>= 5), dpatch, bcc, bzip2, g++-multilib [amd64], iasl, kbuild, libacl1-dev, libasound-dev, libhal-dev, libidl-dev, libqt3-mt-dev, libsdl1.2-dev, libxalan110-dev, uuid-dev, xalan, xsltproc, yasm, libpulse-dev, po-debconf (>= 0.5.0)
Standards-Version: 3.7.3
Homepage: http://www.virtualbox.org/
Vcs-Svn: svn://svn.debian.org/svn/pkg-virtualbox/trunk
Vcs-Browser: http://svn.debian.org/wsvn/pkg-virtualbox/trunk

Package: virtualbox-ose
Architecture: amd64 i386
Depends: ${shlibs:Depends}, ${misc:Depends}, adduser
Recommends: virtualbox-ose-modules
Suggests: virtualbox-ose-source
Conflicts: virtualbox
Replaces: virtualbox
Provides: virtualbox
Description: x86 virtualization solution - binaries
 VirtualBox is a free x86 virtualization solution allowing to run a wide
 range of x86 operating systems on a Linux system. This includes Windows,
 Linux, FreeBSD, DOS, OpenBSD and others.
 .
 This package provides the binaries for the Open Source Edition of
 VirtualBox.

Package: virtualbox-ose-dbg
Section: devel
Priority: extra
Architecture: amd64 i386
Depends: virtualbox-ose (= ${binary:Version})
Description: x86 virtualization solution - debugging symbols
 VirtualBox is a free x86 virtualization solution allowing to run a wide
 range of x86 operating systems on a Linux system. This includes Windows,
 Linux, FreeBSD, DOS, OpenBSD and others.
 .
 This package provides the debugging symbols for the Open Source Edition of
 VirtualBox.

Package: virtualbox-ose-source
Architecture: all
Depends: debhelper (>= 5), dpatch, module-assistant, bzip2, kbuild
Conflicts: virtualbox-source
Replaces: virtualbox-source
Provides: virtualbox-source
Description: x86 virtualization solution - kernel module source
 VirtualBox is a free x86 virtualization solution allowing to run a wide
 range of x86 operating systems on a Linux system. This includes Windows,
 Linux, FreeBSD, DOS, OpenBSD and others.
 .
 This package provides the source code for the virtualbox kernel module.
 The virtualbox-ose package is also required in order to make use of these
 modules. Kernel sources or headers are required to compile this module.

Package: virtualbox-ose-guest-source
Architecture: all
Depends: debhelper (>= 5), dpatch, module-assistant, bzip2, kbuild
Description: x86 virtualization solution - guest addition module source
 VirtualBox is a free x86 virtualization solution allowing to run a wide
 range of x86 operating systems on a Linux system. This includes Windows,
 Linux, FreeBSD, DOS, OpenBSD and others.
 .
 This package provides the source code for the virtualbox guest addition kernel
 modules. The virtualbox-ose-guest package is also required in order to make
 use of these modules. Kernel sources or headers are required to compile these
 modules.

Package: virtualbox-ose-guest-utils
Architecture: i386
Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
Recommends: virtualbox-ose-guest-modules
Suggests: virtualbox-ose-guest-source
Description: x86 virtualization solution - guest utilities
 VirtualBox is a free x86 virtualization solution allowing to run a wide
 range of x86 operating systems on a Linux system. This includes Windows,
 Linux, FreeBSD, DOS, OpenBSD and others.
 .
 This package provides the guest utilities of the Open Source Edition of
 VirtualBox. These utilities are meant to be run inside the virtual machine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-virtualbox-devel/attachments/20080115/ccdda025/attachment.pgp