[Pkg-virtualbox-devel] () constructs in rules and exports

[Michael Meskes]

On Wed, Jul 02, 2008 at 05:17:14PM +0200, Loïc Minier wrote:
>  but AFAIK, make already spawns a subshell for each line of commands of
>  a target, so it seems the () are not used.

I think you're right.

>  I'm tempted to drop them, but I prefer checking here if I'm missing an
>  use case for the subshell.

However, I do not see a major advantage in droppoing them. I don't mind
seeing the subshells there.

>  I'd also find it more cautious to export such vars like LANG as my test
>  indicate that only some env vars are actually passed down:
> ...
>  So LANG is special but we'd best no rely on this.

I don't think it's special. The difference might be that there was
alreday a variable LANG in the environment, but no variable foo. Do we
want to export LANG in this construct if it hasn't been defined before?

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes at jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!