[Pkg-virtualbox-devel] () constructs in rules and exports

[Loïc Minier]

On Mon, Jul 07, 2008, Michael Meskes wrote:
> On Wed, Jul 02, 2008 at 05:17:14PM +0200, Loïc Minier wrote:
> >  but AFAIK, make already spawns a subshell for each line of commands of
> >  a target, so it seems the () are not used.
> 
> I think you're right.
> 
> >  I'm tempted to drop them, but I prefer checking here if I'm missing an
> >  use case for the subshell.
> 
> However, I do not see a major advantage in droppoing them. I don't mind
> seeing the subshells there.

 If not useful, these are a distraction IMHO.

> >  I'd also find it more cautious to export such vars like LANG as my test
> >  indicate that only some env vars are actually passed down:
> > ...
> >  So LANG is special but we'd best no rely on this.
> 
> I don't think it's special. The difference might be that there was
> alreday a variable LANG in the environment, but no variable foo. Do we
> want to export LANG in this construct if it hasn't been defined before?

 (I meant special in that it doesn't need to be exported, so it is
 special in this regard. :-)  I think I'll add an explicit export to
 avoid any issue with this feature.

   Thanks,
-- 
Loïc Minier