[Pkg-virtualbox-devel] Bug#699141:

[Dmitry Smirnov]

On Wed, 18 Jun 2014 16:02:27 Gianfranco Costamagna wrote:
> Sorry, the script is get-orig-source.sh
> 
> I didn't include it in debian/rules file, to keep things clean (in my
> opinion, since this script isn't used when building or cleaning the
> package).
> 
> Do you think I should add it again in rules file?

Yes, I think it will be better. This way whoever will be rebuilding your 
package would be able to fetch upstream source archive using standard way as 
described in policy. It is a good thing and it saves time that otherwise 
somebody would spend trying to figure out how to use yet another non-
conformant script to get source archive.


> Googling around I found many get-orig-source.sh scripts, all those packages
> are bugged then? I wrote it in this way starting from another debian
> package!

Yes there are packages that do not comply and IMHO it is a best practice to 
use get-orig-source target from "rules". However it is not mandatory so 
technically speaking those packages are not buggy -- just not following the 
best practice.


> let me know if I need to merge it back in rules file

This is up to you -- as maintainer you can do as you wish. :)

-- 
All the best,
 Dmitry Smirnov.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-virtualbox-devel/attachments/20140702/c6a459e3/attachment.sig>