[Pkg-virtualbox-devel] Bug#699141:

[Gianfranco Costamagna]

Il Mercoledì 2 Luglio 2014 11:42, Dmitry Smirnov <onlyjob at debian.org> ha scritto:


>
>
>On Wed, 18 Jun 2014 16:02:27 Gianfranco Costamagna wrote:
>> Sorry, the script is get-orig-source.sh
>> 
>> I didn't include it in debian/rules file, to keep things clean (in my
>> opinion, since this script isn't used when building or cleaning the
>> package).
>> 
>> Do you think I should add it again in rules file?
>
>Yes, I think it will be better. This way whoever will be rebuilding your 
>package would be able to fetch upstream source archive using standard way as 
>described in policy. It is a good thing and it saves time that otherwise 
>somebody would spend trying to figure out how to use yet another non-
>conformant script to get source archive.
>
>
>> Googling around I found many get-orig-source.sh scripts, all those packages
>> are bugged then? I wrote it in this way starting from another debian
>> package!
>
>Yes there are packages that do not comply and IMHO it is a best practice to 
>use get-orig-source target from "rules". However it is not mandatory so 
>technically speaking those packages are not buggy -- just not following the 
>best practice.
>
>
>> let me know if I need to merge it back in rules file
>
>This is up to you -- as maintainer you can do as you wish. :)
>

Hi again Dmitry,

I think I fixed in the best way this problem, since I didn't found a proper way to call get-orig-source with the uscan parameters I add the uscan call in the "rules get-orig-source" target

so now you can run
./debian/rules get-orig-source or directly uscan, with exactly the same behaviour.

I think this is the best way, compliant with policy and not breaking the existing update procedure.

I hope you agree, I committed it here

http://anonscm.debian.org/gitweb/?p=pkg-virtualbox/virtualbox.git;a=commitdiff;h=cb88c2a13a0fe8336831b3d63082fda348c02c4b


And will be fixed in the next upload

Cheers!

Gianfranco


>-- 
>All the best,
>
>Dmitry Smirnov.
>
>