[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.16-1409-g5afdf4d
abarth at webkit.org
abarth at webkit.org
Thu Dec 3 13:37:22 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 66667576b8f008e78a3258ff7ed4c27825c746c2
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Nov 16 10:45:32 2009 +0000
2009-11-16 Adam Barth <abarth at webkit.org>
Reviewed by Eric Seidel.
Fix silly copy-and-paste code. I am a terrible coder.
* Scripts/modules/bugzilla.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index f68faa3..3cfcd67 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -2,6 +2,14 @@
Reviewed by Eric Seidel.
+ Fix silly copy-and-paste code. I am a terrible coder.
+
+ * Scripts/modules/bugzilla.py:
+
+2009-11-16 Adam Barth <abarth at webkit.org>
+
+ Reviewed by Eric Seidel.
+
Implement a StyleQueue
https://bugs.webkit.org/show_bug.cgi?id=31537
diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py
index f221c53..f30dda3 100644
--- a/WebKitTools/Scripts/modules/bugzilla.py
+++ b/WebKitTools/Scripts/modules/bugzilla.py
@@ -283,10 +283,8 @@ class Bugzilla:
commit_queue_patches.append(attachment)
return commit_queue_patches
- def fetch_bug_ids_from_commit_queue(self):
- commit_queue_url = self.bug_server_url + "buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=commit-queue%2B"
-
- page = urllib2.urlopen(commit_queue_url)
+ def _fetch_bug_ids_advanced_query(self, query):
+ page = urllib2.urlopen(query)
soup = BeautifulSoup(page)
bug_ids = []
@@ -297,6 +295,14 @@ class Bugzilla:
return bug_ids
+ def fetch_bug_ids_from_commit_queue(self):
+ commit_queue_url = self.bug_server_url + "buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=commit-queue%2B"
+ return self._fetch_bug_ids_advanced_query(commit_queue_url)
+
+ def fetch_bug_ids_from_review_queue(self):
+ review_queue_url = self.bug_server_url + "buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review?"
+ return self._fetch_bug_ids_advanced_query(review_queue_url)
+
def fetch_patches_from_commit_queue(self, reject_invalid_patches=False):
patches_to_land = []
for bug_id in self.fetch_bug_ids_from_commit_queue():
@@ -304,20 +310,6 @@ class Bugzilla:
patches_to_land += patches
return patches_to_land
- def fetch_bug_ids_from_review_queue(self):
- review_queue_url = self.bug_server_url + "buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review?"
-
- page = urllib2.urlopen(review_queue_url)
- soup = BeautifulSoup(page)
-
- bug_ids = []
- # Grab the cells in the first column (which happens to be the bug ids)
- for bug_link_cell in soup('td', "first-child"): # tds with the class "first-child"
- bug_link = bug_link_cell.find("a")
- bug_ids.append(bug_link.string) # the contents happen to be the bug id
-
- return bug_ids
-
def fetch_patches_from_review_queue(self, limit):
patches_to_review = []
for bug_id in self.fetch_bug_ids_from_review_queue():
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list