[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-34-g43a6bb2
Gustavo Noronha Silva
gustavo.noronha at collabora.co.uk
Wed Oct 7 06:26:10 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 3fce9fab1569abc4188bb2396a66da67e6001eca
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 21 21:50:07 2009 +0000
2009-09-21 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: JS error drilling down childless node.
No need to dispatch double click twice - it is already handled
in TreeElement.treeElementDoubleClicked.
https://bugs.webkit.org/show_bug.cgi?id=22144
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 34eafb2..2debab5 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,403 +1,3 @@
-2009-09-24 Alexey Proskuryakov <ap at apple.com>
-
- Reviewed by Darin Adler and Sam Weinig.
-
- Onclick not fired for an element copied with cloneContents() or cloneNode()
- https://bugs.webkit.org/show_bug.cgi?id=25130
-
- The change here is that JS event listeners don't keep a reference to a global object from
- where they were created, and instead take it as a parameter when parsing source code. Also,
- the listener creation won't fail just because it happens for an element in a frameless
- document.
- Thus, moving nodes between documents no longer results in having incorrect registered
- lazy event listeners on them.
-
- Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html
- fast/events/attribute-listener-cloned-from-frameless-doc-context.html
- fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
- fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
- fast/events/attribute-listener-extracted-from-frameless-doc-context.html
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject.
- (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for
- getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner.
- (WebCore::JSEventListener::markJSFunction): Don't mark the global object.
- (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext.
- (WebCore::JSEventListener::reportError): Ditto.
-
- * bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference
- to JSDOMGlobalObject.
-
- * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener
- creation was split between this function and ScriptEventListener; moved it here, as JS
- global object can be different now.
-
- * bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL,
- which can not be determined at parsing time.
-
- * bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code
- for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests
- expect that errors are logged at document parsing time, and because I don't know what other
- side effects moving it vould have.
-
- * dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext,
- because JSC needs a global context here.
-
- * bindings/js/JSAbstractWorkerCustom.cpp:
- (WebCore::JSAbstractWorker::addEventListener):
- (WebCore::JSAbstractWorker::removeEventListener):
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- (WebCore::JSDOMApplicationCache::addEventListener):
- (WebCore::JSDOMApplicationCache::removeEventListener):
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::addEventListener):
- (WebCore::JSDOMWindow::removeEventListener):
- * bindings/js/JSEventSourceCustom.cpp:
- (WebCore::JSEventSource::addEventListener):
- (WebCore::JSEventSource::removeEventListener):
- * bindings/js/JSMessagePortCustom.cpp:
- (WebCore::JSMessagePort::addEventListener):
- (WebCore::JSMessagePort::removeEventListener):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::addEventListener):
- (WebCore::JSNode::removeEventListener):
- * bindings/js/JSSVGElementInstanceCustom.cpp:
- (WebCore::JSSVGElementInstance::addEventListener):
- (WebCore::JSSVGElementInstance::removeEventListener):
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::addEventListener):
- (WebCore::JSWorkerContext::removeEventListener):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::addEventListener):
- (WebCore::JSXMLHttpRequest::removeEventListener):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::addEventListener):
- (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- * bindings/objc/ObjCEventListener.h:
- * bindings/objc/ObjCEventListener.mm:
- (WebCore::ObjCEventListener::handleEvent):
- * bindings/scripts/CodeGeneratorJS.pm:
- * dom/EventTarget.cpp:
- (WebCore::EventTarget::fireEventListeners):
- * inspector/InspectorDOMAgent.cpp:
- (WebCore::InspectorDOMAgent::handleEvent):
- * inspector/InspectorDOMAgent.h:
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::handleEvent):
- * inspector/InspectorDOMStorageResource.h:
- * loader/ImageDocument.cpp:
- (WebCore::ImageEventListener::handleEvent):
- * svg/animation/SVGSMILElement.cpp:
- (WebCore::ConditionEventListener::handleEvent):
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::reportException):
- Don't pass global object to JSEventListener::create(), which no longer needs it.
- Note that some of these functions still have an early return for null global object, which
- can probably be removed in a later patch.
- Pass ScriptExecutionContext to EventListener methods that now need it.
-
-2009-09-25 Enrica Casucci <enrica at apple.com>
-
- Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=29740
- <rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line
-
- Change the way style is preserved when inserting a new paragraph.
- The original code handled insertion at the beginning and at the end of a paragraph as special
- cases. The newly created paragraph contained a set of nodes generated starting from the
- computed style of the insertion node. This approach has two problems:
- 1. if the insertion node has a non opaque background color and one of the parent element did have
- a solid background color the new paragraph did not have the element with the solid color in the tree.
- 2. in some circumstances it generated more markup than the original paragraph had (a span with bold, italic,
- background color and some font attribute was being reproduced as span + bold + italic + font as separate tags.
- The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the
- paragraph where the insertion point is.
-
- Test: editing/inserting/insert-bg-font.html
-
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock): retrieves the list of all the ancestors
- between the insert node and the outer block.
- (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock): uses the list of ancestors to recreate
- in the new paragraph the same element hierarchy present in the starting paragraph.
- (WebCore::InsertParagraphSeparatorCommand::doApply): changed the code to handle the general case of insertion
- in the middle of the paragraph to use the new methods. Changed the handling of the insertion at the beginning and
- at the end of the paragraph to use the new methods instead of applying the calculated style.
- * editing/InsertParagraphSeparatorCommand.h: added methods getAncestorsInsideBlock and cloneHierarchyUnderNewBlock.
-
-2009-09-25 Patrick Mueller <Patrick_Mueller at us.ibm.com>
-
- Reviewed by Timothy Hatcher.
-
- Content-type parameters not taken into account when building form-data
- https://bugs.webkit.org/show_bug.cgi?id=28970
-
- existing manual test case extended with new tests
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/ResourceView.js:
- (WebInspector.ResourceView.prototype._refreshFormData):
- (WebInspector.ResourceView.prototype._refreshParms):
- * manual-tests/inspector/display-form-data.html:
-
-2009-09-25 Yuan Song <song.yuan at ericsson.com>
-
- Reviewed by Darin Adler.
-
- https://bugs.webkit.org/show_bug.cgi?id=14566
-
- Raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value.
-
- Test: fast/js/invalid-domain-change-throws-exception.html
-
- * dom/Document.cpp:
- (WebCore::Document::setDomain):
- * dom/Document.h:
- * dom/Document.idl:
-
-2009-09-25 Adam Barth <abarth at webkit.org>
-
- Reviewed by Dimitri Glazkov.
-
- [V8] Teach ScheduledAction::execute about isolated worlds
- https://bugs.webkit.org/show_bug.cgi?id=27703
-
- When setTimeout is called with a string argument in an isolated
- world, we now compile the string in the isolated world.
-
- Last time we tried this change, we got a lot of crashes. This
- time we're using a fresh local handle as our context to avoid
- trouble if the peristent handle gets disposed before we leave
- the context.
-
- Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html
-
- * bindings/v8/ScheduledAction.cpp:
- (WebCore::ScheduledAction::execute):
-
-2009-09-25 Paul Godavari <paul at chromium.org>
-
- Reviewed by Darin Fisher.
-
- Fix a regression in Mac Chromium popup menus, where the user's
- selection was ignored and the popup became unresponsive.
- https://bugs.webkit.org/show_bug.cgi?id=29726
-
- The fix is to notify the popup's client that the popup was hidden,
- even if the popup has no parent.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupListBox::hidePopup):
-
-2009-09-25 Alexander Pavlov <apavlov at chromium.org>
-
- Reviewed by Dan Bernstein.
-
- Enable Pasteboard::writePlainText for Chromium and fix code style nits.
- https://bugs.webkit.org/show_bug.cgi?id=29734
-
- * platform/chromium/PasteboardChromium.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::writePlainText):
- (WebCore::Pasteboard::writeURL):
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writeSelection):
- (WebCore::Pasteboard::writePlainText):
- (WebCore::Pasteboard::writeURL):
- * platform/qt/PasteboardQt.cpp:
- (WebCore::Pasteboard::writePlainText):
-
-2009-09-25 Yongjun Zhang <yongjun.zhang at nokia.com>
-
- Reviewed by Ariya Hidayat.
-
- https://bugs.webkit.org/show_bug.cgi?id=28876
- [Qt] reduce peak memory consumption of text decoding.
-
- Chop large input buffer into small buffers to reduce peak memory
- during decoding.
-
- * platform/text/qt/TextCodecQt.cpp:
- (WebCore::TextCodecQt::decode):
-
-2009-09-24 Jon Honeycutt <jhoneycutt at apple.com>
-
- Add a mechanism for automatically halting plug-ins.
-
- Reviewed by Oliver Hunt and Alice Liu.
-
- * GNUmakefile.am:
-
- * WebCore.base.exp:
- Update export of Page constructor.
-
- * WebCore.gypi:
-
- * WebCore.pro:
-
- * WebCore.vcproj/WebCore.vcproj:
- Add PluginHalter.{h,cpp}, PluginHalterClient.h, and
- HaltablePlugin.h.
-
- * WebCore.xcodeproj/project.pbxproj:
- Add files to Mac project.
-
- * loader/EmptyClients.h:
- Added an empty PluginHalterClient.
- (WebCore::EmptyPluginHalterClient::shouldHaltPlugin):
- Return false.
-
- * page/PluginHalter.cpp: Added.
- (WebCore::PluginHalter::PluginHalter):
- (WebCore::PluginHalter::didStartPlugin):
- Add the object to the plug-in set. If this is the only item in the set,
- set m_oldestStartTime to this object's time, and start the timer.
- (WebCore::PluginHalter::didStopPlugin):
- Remove the plug-in from the set.
- (WebCore::PluginHalter::timerFired):
- Find the cut-off time as the current time minus the allowed run time;
- plug-ins older than this may be halted. Iterate over the plug-ins. Find
- the object with the oldest start time that is too young to be halted;
- we'll use its start time to set the timer's next fire time. For all
- plug-ins that are candidates to be halted, call the
- PluginHalterClient's shouldHaltPlugin(). If this function returns true,
- call the plug-in's halt() function. Remove these objects from the set
- of tracked plug-ins. Call startTimerIfNecessary() to restart the timer.
- (WebCore::PluginHalter::startTimerIfNecessary):
- If the timer is set to fire, or the set of tracked plug-ins is empty,
- return early. Set the timer to fire after the oldest plug-in has run
- for the allowed run time.
-
- * page/PluginHalter.h: Added.
- (WebCore::PluginHalter::setPluginAllowedRunTime):
-
- * page/PluginHalterClient.h: Added.
- (WebCore::PluginHalterClient::~PluginHalterClient):
-
- * page/Page.cpp:
- (WebCore::Page::Page):
- Initialize m_pluginHalterClient. Call pluginHalterEnabledStateChanged()
- to create the PluginHalter if necessary.
- (WebCore::Page::pluginHalterEnabledStateChanged):
- If plug-in halting is enabled, create the PluginHalter. If it is
- disabled, clear it.
- (WebCore::Page::pluginAllowedRunTimeChanged):
- If there is a plug-in halter, call its setPluginAllowedRunTime().
- (WebCore::Page::didStartPlugin):
- If there is a plug-in halter, call its didStartPlugin().
- (WebCore::Page::didStopPlugin):
- If there is a plug-in halter, call its didStopPlugin().
-
- * page/Page.h:
- Add a parameter to the Page constructor for the PluginHalterClient.
- Added declarations for didStartPlugin() and didStopPlugin(), which are
- called when HaltablePlugins are added to or removed from the page. Adds
- pluginAllowedRunTimeChanged() and pluginHalterEnabledStateChanged() to
- notify the Page when these settings are changed. Added members to hold
- the PluginHalter and the PluginHalterClient.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setPluginHalterEnabled):
- If the enabled state has changed, call the Page's
- pluginHalterEnabledStateChanged().
- (WebCore::Settings::setPluginAllowedRunTime):
- Call the Page's pluginAllowedRunTimeChanged().
-
- * page/Settings.h:
- (WebCore::Settings::pluginHalterEnabled):
- (WebCore::Settings::pluginAllowedRunTime):
-
- * page/HaltablePlugin.h: Added. Defines an interface for plug-ins that
- can be automatically halted.
- (WebCore::HaltablePlugin::~HaltablePlugin):
-
- * svg/graphics/SVGImage.cpp:
- (WebCore::SVGImage::dataChanged):
- Pass a dummy PluginHalterClient.
-
-2009-09-24 Simon Fraser <simon.fraser at apple.com>
-
- Reviewed by Dan Bernstein.
-
- REGRESSION: webkit-transform scale no longer works properly in nightly build
- https://bugs.webkit.org/show_bug.cgi?id=29730
-
- When the initial or final state of a scale animation does not specify a transform,
- use a default scale of 1, rather than zero.
-
- Test: compositing/transitions/scale-transition-no-start.html
-
- * platform/graphics/mac/GraphicsLayerCA.mm:
- (WebCore::getTransformFunctionValue):
-
-2009-09-24 John Gregg <johnnyg at google.com>
-
- Reviewed by Eric Seidel.
-
- isEnabled switch for notifications (experimental) in Page Settings
- https://bugs.webkit.org/show_bug.cgi?id=28930
-
- Adds a run-time flag in Settings object that controls whether
- to expose desktop notifications.
-
- No new test, but test code also modified to set this preference.
-
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore::Settings::setExperimentalNotificationsEnabled):
- * page/Settings.h:
- (WebCore::Settings::experimentalNotificationsEnabled):
-
-2009-09-24 Dan Bernstein <mitz at apple.com>
-
- Reviewed by Sam Weinig.
-
- Fix <rdar://problem/7162000> Crash while trying to
- calculate the horizontal position of image
-
- Test: fast/inline-block/relative-positioned-rtl-crash.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Corrected an
- isInline() test to isRenderInline(). This is similar to r41259.
-
-2009-09-24 Jessie Berlin <jberlin at webkit.org>
-
- Reviewed by Timothy Hatcher.
-
- Fix expanding profile call stacks being broken after sorting.
- https://bugs.webkit.org/show_bug.cgi?id=26423
-
- * inspector/front-end/ProfileDataGridTree.js:
- (WebInspector.ProfileDataGridNode.prototype.sort):
- Set shouldRefreshChildren to true on collapsed nodes with children so that expanding it
- causes the children to be placed in the right positions.
-
-2009-09-24 Geoffrey Garen <ggaren at apple.com>
-
- Reviewed by Stephanie Lewis.
-
- Fixed sudden termination console spew due to too many calls to
- enableSuddenTermination.
-
- <rdar://problem/7063125> 10A410: Safari logging enableSuddenTermination errors
-
- * page/DOMWindow.cpp:
- (WebCore::removeUnloadEventListener):
- (WebCore::removeAllUnloadEventListeners):
- (WebCore::removeBeforeUnloadEventListener):
- (WebCore::removeAllBeforeUnloadEventListeners): Only
- enableSuddenTermination if the set of listeners is empty *and* this
- window was in the set. Otherwise, a no-op will cause us to enableSuddenTermination.
-
2009-09-24 Carol Szabo <carol.szabo at nokia.com>
Reviewed by Alexey Proskuryakov.
diff --git a/WebCore/inspector/front-end/ElementsTreeOutline.js b/WebCore/inspector/front-end/ElementsTreeOutline.js
index 08ba1c2..d8c4d89 100644
--- a/WebCore/inspector/front-end/ElementsTreeOutline.js
+++ b/WebCore/inspector/front-end/ElementsTreeOutline.js
@@ -31,7 +31,6 @@
WebInspector.ElementsTreeOutline = function() {
this.element = document.createElement("ol");
this.element.addEventListener("mousedown", this._onmousedown.bind(this), false);
- this.element.addEventListener("dblclick", this._ondblclick.bind(this), false);
this.element.addEventListener("mousemove", this._onmousemove.bind(this), false);
this.element.addEventListener("mouseout", this._onmouseout.bind(this), false);
@@ -186,16 +185,6 @@ WebInspector.ElementsTreeOutline.prototype = {
return element;
},
- _ondblclick: function(event)
- {
- var element = this._treeElementFromEvent(event);
-
- if (!element || !element.ondblclick)
- return;
-
- element.ondblclick(element, event);
- },
-
_onmousedown: function(event)
{
var element = this._treeElementFromEvent(event);
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list