[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-34-g43a6bb2
Gustavo Noronha Silva
gustavo.noronha at collabora.co.uk
Wed Oct 7 06:26:11 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit 9ba4d9cf33ee1ebb3e69d7f48067c142bfbd0554
Author: pfeldman at chromium.org <pfeldman at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon Sep 21 22:59:00 2009 +0000
2009-09-21 Pavel Feldman <pfeldman at chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: completions are always evaluated against
window (discarding call frames).
https://bugs.webkit.org/show_bug.cgi?id=29616
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/InjectedScript.js:
(InjectedScript.getCompletions):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.selectedCallFrameId):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2debab5..86f6f47 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,1713 +1,3 @@
-2009-09-24 Carol Szabo <carol.szabo at nokia.com>
-
- Reviewed by Alexey Proskuryakov.
-
- WebKit returns "" instead of null when getting
- inexistent, forbidden or invalidly named headers.
- https://bugs.webkit.org/show_bug.cgi?id=29140
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::getResponseHeader):
- Changed to return null as it should according to the spec.
-
-2009-09-24 Jeremy Orlow <jorlow at chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Add GYP generated files to svn:ignore
- https://bugs.webkit.org/show_bug.cgi?id=29724
-
- Adding the following files to the svn:ignore list (all in the
- WebCore/WebCore.gyp directory)
-
- WebCore.xcodeproj
- WebCore.sln
- WebCore.vcproj
- WebCore_Debug.rules
- WebCore_Release.rules
- WebCore_Release - no tcmalloc.rules
- WebCore_Purify.rules
- WebCore.mk
- WebCore_Debug_rules.mk
- WebCore_Release_rules.mk
- WebCore_Release - no tcmalloc_rules.mk
- WebCore_Purify_rules.mk
- WebCore.scons
- WebCore_main.scons
-
- * WebCore.gyp: Changed property svn:ignore.
-
-2009-09-24 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
-
- Unreviewed. Mac build fix.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):
- remove unused parameter from function signature;
-
-2009-09-24 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
-
- Reviewed by Oliver Hunt.
-
- Implement correct horizontal scrollbar behavior for GTK+ also on
- styled scrollbars.
-
- https://bugs.webkit.org/show_bug.cgi?id=29348
- [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
-
- Test: platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleWheelEvent): on GTK+, when using the
- wheel with the pointer on the horizontal scrollbar, scroll
- horizontally;
- * platform/PlatformWheelEvent.h:
- * platform/gtk/WheelEventGtk.cpp:
- (WebCore::PlatformWheelEvent::swapOrientation): allow adding a
- vertical scroll to the horizontal one;
-
-2009-09-24 Jeremy Orlow <jorlow at chromium.org>
-
- Reviewed by Eric Seidel.
-
- StorageNamespace::storageArea() should take in a PassRefPtr<StorageOrigin>
- https://bugs.webkit.org/show_bug.cgi?id=29290
-
- Modified StorageNamespace::storageArea() to take in a PassRefPtr<StorageOrigin>
- per http://webkit.org/coding/RefPtr.html
-
- No behavior change, so no tests.
-
- * storage/StorageNamespace.h:
- * storage/StorageNamespaceImpl.cpp:
- (WebCore::StorageNamespaceImpl::storageArea):
- * storage/StorageNamespaceImpl.h:
-
-2009-09-24 Geoffrey Garen <ggaren at apple.com>
-
- Reviewed by Sam Weinig.
-
- Added back enable/disableSuddenTermination() functionality I accidentally
- removed in my last patch.
-
- * page/DOMWindow.cpp:
- (WebCore::addUnloadEventListener):
- (WebCore::removeUnloadEventListener):
- (WebCore::removeAllUnloadEventListeners):
- (WebCore::addBeforeUnloadEventListener):
- (WebCore::removeBeforeUnloadEventListener):
- (WebCore::removeAllBeforeUnloadEventListeners):
- (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
- (WebCore::DOMWindow::~DOMWindow):
- (WebCore::DOMWindow::addEventListener):
- (WebCore::DOMWindow::removeEventListener):
- (WebCore::DOMWindow::removeAllEventListeners):
-
-2009-09-24 Sam Weinig <sam at webkit.org>
-
- Reviewed by Steve Falkenburg and Mark Rowe.
-
- Don't pass -F to GCC on non-mac platforms since it is an darwin only.
-
- * DerivedSources.make:
-
-2009-09-24 Sam Weinig <sam at webkit.org>
-
- Fix windows build.
-
- * dom/Element.idl:
-
-2009-09-23 Stephen White <senorblanco at chromium.org>
-
- Reviewed by Eric Seidel.
-
- Revert the relevant parts of r47925, and implement an alternate
- fix (localize the coordinate check to GraphicsContext::clipPath()).
- This fixes http://crbug.com/21174.
-
- Covered by LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html.
-
- * platform/graphics/skia/GraphicsContextSkia.cpp:
- (WebCore::GraphicsContext::clipPath):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (PlatformContextSkia::currentPathInLocalCoordinates):
-
-2009-09-24 Brady Eidson <beidson at apple.com>
-
- Reviewed by Sam Weinig.
-
- Merge changes from Mozilla's FTP directory parser.
- <rdar://problem/7227620> and https://bugs.webkit.org/show_bug.cgi?id=29294
-
- FTP layout tests not possible at this time.
- https://bugs.webkit.org/show_bug.cgi?id=29719 tracks making them possible.
-
- * loader/FTPDirectoryParser.cpp:
- (WebCore::ParsingFailed):
- (WebCore::parseOneFTPLine):
-
-2009-09-24 Philippe Normand <pnormand at igalia.com>
-
- Reviewed by Gustavo Noronha.
-
- [GTK] re-enable some media tests
- https://bugs.webkit.org/show_bug.cgi?id=29716
-
- make canPlayType() return "probably" if mime-type is known
- and codecs string is not empty. If codecs is empty return
- "maybe".
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::supportsType):
-
-2009-09-24 Sam Weinig <sam at webkit.org>
-
- Reviewed by Dan Bernstein.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=29703
- Add a function to element to check whether it matches a CSS selector
-
- Implement Element.webkitMatchesSelector.
-
- * css/CSSSelectorList.cpp:
- (WebCore::forEachTagSelector):
- (WebCore::forEachSelector):
- (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- (WebCore::CSSSelectorList::selectorsNeedNamespaceResolution):
- * css/CSSSelectorList.h:
- Moved code to iterate the CSSSelectorList and determine if any
- selectors need namespace resolution from a static function in
- Node.cpp to CSSSelectorList so that it can be used by webkitMatchesSelector
- as well as querySelector/querySelectorAll.
-
- * dom/Element.cpp:
- (WebCore::Element::webkitMatchesSelector):
- * dom/Element.h:
- * dom/Element.idl:
- Implement the new function. Handles exceptional cases identically to
- querySelector/querySelectorAll.
-
- * dom/Node.cpp:
- (WebCore::Node::querySelector):
- (WebCore::Node::querySelectorAll):
- Moved selectorsNeedNamespaceResolution to CSSSelectorList from here.
-
-2009-09-24 Vitaly Repeshko <vitalyr at chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- [V8] Fixed bindings build after http://trac.webkit.org/changeset/48701
- https://bugs.webkit.org/show_bug.cgi?id=29713
-
- Got rid of isWindowEvent in function signatures:
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- (WebCore::V8AbstractEventListener::handleEvent):
- (WebCore::V8AbstractEventListener::getReceiverObject):
- * bindings/v8/V8AbstractEventListener.h:
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::callListenerFunction):
- * bindings/v8/V8LazyEventListener.h:
- * bindings/v8/V8WorkerContextEventListener.cpp:
- (WebCore::V8WorkerContextEventListener::handleEvent):
- (WebCore::V8WorkerContextEventListener::callListenerFunction):
- (WebCore::V8WorkerContextEventListener::getReceiverObject):
- * bindings/v8/V8WorkerContextEventListener.h:
- * bindings/v8/custom/V8CustomEventListener.cpp:
- (WebCore::V8EventListener::callListenerFunction):
- * bindings/v8/custom/V8CustomEventListener.h:
-
- Switched to EventTarget methods of adding/removing listeners:
- * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
- (WebCore::toEventID):
- (WebCore::ACCESSOR_SETTER):
-
- * dom/EventTarget.h: Some functions were incorrectly marked
- as JSC-specific.
-
-2009-09-24 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: Color-code watch expression errors with red.
-
- https://bugs.webkit.org/show_bug.cgi?id=29707
-
- * inspector/front-end/WatchExpressionsSidebarPane.js:
- (WebInspector.WatchExpressionsSection.prototype.update):
- (WebInspector.WatchExpressionTreeElement.prototype.update):
- * inspector/front-end/inspector.css:
-
-2009-09-24 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: Fix formatting for messages derived from resource warnings,
- couple of drive-by formatting fixes.
-
- https://bugs.webkit.org/show_bug.cgi?id=29705
-
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::addMessageToConsole):
- * inspector/front-end/ConsoleView.js:
- * inspector/front-end/InjectedScript.js:
- (InjectedScript._evaluateAndWrap):
- * inspector/front-end/WatchExpressionsSidebarPane.js:
- (WebInspector.WatchExpressionsSection.prototype.update):
-
-2009-09-22 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- WebInspector: Implement InspectorController::copyNode(id).
-
- https://bugs.webkit.org/show_bug.cgi?id=28357
-
- * inspector/InspectorBackend.cpp:
- (WebCore::InspectorBackend::copyNode):
- * inspector/InspectorBackend.h:
- * inspector/InspectorBackend.idl:
- * inspector/front-end/ElementsPanel.js:
- (WebInspector.ElementsPanel.prototype.handleCopyEvent):
-
-2009-09-24 Oliver Hunt <oliver at apple.com>
-
- Reviewed by NOBODY(rollout)
-
- Roll out r48712 as it is incorrect.
-
- Overriding getPropertyNames is incorrect.
-
- * bridge/runtime_array.cpp:
- * bridge/runtime_array.h:
-
-2009-09-24 Xan Lopez <xlopez at igalia.com>
-
- Revert r48697, since it broke key handling notification to GTK+.
-
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::keyIdentifierForGdkKeyCode):
- (WebCore::singleCharacterString):
-
-2009-09-24 Philippe Normand <pnormand at igalia.com>
-
- Reviewed by Xan Lopez.
-
- [GTK] GStreamer MediaPlayer is unable to correctly querry duration
- https://bugs.webkit.org/show_bug.cgi?id=24639
-
- check duration returned by gst_element_query_duration() only
- when using GStreamer < 0.10.23.
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivate::duration):
-
-2009-09-24 Benjamin Poulain <benjamin.poulain at nokia.com>
-
- Reviewed by Eric Seidel.
-
- The indices of RuntimeArray should be enumerated like for a regular array.
- https://bugs.webkit.org/show_bug.cgi?id=29005
-
- * bridge/runtime_array.cpp:
- (JSC::RuntimeArray::getPropertyNames):
- * bridge/runtime_array.h:
-
-2009-09-23 Alexander Pavlov <apavlov at chromium.org>
-
- Reviewed by Eric Seidel.
-
- Introduce Pasteboard::writePlaintext(const String&) so that copying
- of the inspected elements HTML will be possible in WebInspector.
- https://bugs.webkit.org/show_bug.cgi?id=29634
-
- * platform/Pasteboard.h:
- * platform/android/TemporaryLinkStubs.cpp:
- (Pasteboard::writePlainText):
- * platform/chromium/ChromiumBridge.h:
- * platform/chromium/PasteboardChromium.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/gtk/PasteboardGtk.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/haiku/PasteboardHaiku.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/mac/PasteboardMac.mm:
- (WebCore::Pasteboard::writePlainText):
- * platform/qt/PasteboardQt.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/win/PasteboardWin.cpp:
- (WebCore::Pasteboard::writeSelection):
- (WebCore::Pasteboard::writePlainText):
- * platform/wince/PasteboardWince.cpp:
- (WebCore::Pasteboard::writePlainText):
- * platform/wx/PasteboardWx.cpp:
- (WebCore::Pasteboard::writeSelection):
- (WebCore::Pasteboard::writePlainText):
- (WebCore::Pasteboard::writeURL):
-
-2009-09-24 Oswald Buddenhagen <oswald.buddenhagen at nokia.com>
-
- Reviewed by Simon Hausmann.
-
- Fix QApp::translate() calls to provide the correct class name without
- a trailing comma.
-
- * platform/qt/Localizations.cpp:
- (WebCore::localizedMediaTimeDescription):
-
-2009-09-24 Geoffrey Garen <ggaren at apple.com>
-
- More build fix: Removed JSSharedWorkerContextCustom.cpp from project
- files, since it no longer exists in the repository.
-
- * GNUmakefile.am:
- * WebCore.gypi:
- * WebCore.pro:
- * WebCore.vcproj/WebCore.vcproj:
-
-2009-09-24 Geoffrey Garen <ggaren at apple.com>
-
- Windows build fix: Declare set/unsetPendingActivity public, so
- SharedWorkerScriptLoader can call them.
-
- * dom/ActiveDOMObject.h:
-
-2009-09-24 Geoffrey Garen <ggaren at apple.com>
-
- Fixed a bit of the Windows build.
-
- * workers/SharedWorker.idl: Declare a custom mark function. (I accidentally
- removed this in my last patch.)
- * WebCore.xcodeproj/project.pbxproj: Added JSSharedWorkerCustom.cpp back
- to the build. (I accidentally removed this in my last patch.)
-
-2009-09-23 Geoffrey Garen <ggaren at apple.com>
-
- 32-bit build fix: restore previous cast that I thought was unnecessary.
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::didSendData):
- (WebCore::XMLHttpRequest::didReceiveData):
-
-2009-09-23 Geoffrey Garen <ggaren at apple.com>
-
- Reviewed by Sam Weinig.
-
- Bring a little sanity to this crazy EventTarget world of ours
- https://bugs.webkit.org/show_bug.cgi?id=29701
-
- Lots of EventTarget refactoring to achieve a single shared implementation
- that fixes some of the performance and correctness bugs of the many individual
- implementations, and makes reasoning about EventTargets and EventListeners
- much easier.
-
- The basic design is this:
- - EventTarget manages a set of EventListeners.
- - onXXX EventListener attributes forward to standard EventTarget APIs.
- - Since the onXXX code is repetitive, it is usually done with macros
- of the form DEFINE_ATTRIBUTE_EVENT_LISTENER(attributeName).
- - EventTarget provides a shared implementation of dispatchEvent,
- which subclasses with special event dispatch rules, like Node, override.
- - To support Node, which lazily instantiates its EventTarget data,
- EventTarget has no data members, and instead makes a virtual call
- to get its data from wherever its subclass chose to store it.
-
- Code that used to call dispatchEvent, passing an ExceptionCode paratmeter,
- even though no exception could be thrown, has been changed not to do so,
- to improve clarity and performance.
-
- Code that used to call a special dispatchXXXEvent function, which just
- turned around and called dispatchEvent, has been changed to call
- dispatchEvent, to improve clarity and performance.
-
- * WebCore.base.exp:
- * WebCore.xcodeproj/project.pbxproj: Another day in the life of a WebKit
- engineer.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::isObservableThroughDOM): Updated for Node API change. Added
- "is not in the document but is firing event listeners" as a condition
- that makes a Node observable in the DOM, so that event listeners firing
- on removed nodes are not destroyed midstream. (This was a long-standing
- bug that was somewhat hidden by the old implementation's habit of
- copying the RegisteredEventListener vector before firing events, which
- would keep almost all the relevant objects from being destroyed.)
-
- * bindings/js/JSEventListener.cpp:
- (WebCore::JSEventListener::handleEvent): Removed the isWindowEvent flag
- because it was one of the most elaborately planned no-ops in the history
- of software crime, and one of the reasons clients thought they needed more
- than one dispatchEvent function even though they didn't.
- * bindings/js/JSEventListener.h:
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::markChildren):
- (WebCore::JSMessagePort::markChildren):
- * bindings/js/JSNodeCustom.cpp:
- (WebCore::JSNode::markChildren):
- * bindings/js/JSAbstractWorkerCustom.cpp:
- * bindings/js/JSDOMApplicationCacheCustom.cpp:
- * bindings/js/JSDedicatedWorkerContextCustom.cpp:
- * bindings/js/JSEventSourceCustom.cpp:
- * bindings/js/JSMessagePortCustom.cpp:
- * bindings/js/JSSharedWorkerContextCustom.cpp: Removed.
- * bindings/js/JSWebSocketCustom.cpp:
- * bindings/js/JSWorkerContextCustom.cpp:
- (WebCore::JSWorkerContext::markChildren):
- * bindings/js/JSWorkerCustom.cpp:
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::markChildren):
- * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
- (WebCore::JSXMLHttpRequestUpload::markChildren): EventListener marking is
- now autogenerated. Classes that still have custom mark functions for other
- reasons now call a shared EventTarget API to mark their EventListeners.
-
- * bindings/objc/ObjCEventListener.h:
- * bindings/objc/ObjCEventListener.mm:
- (WebCore::ObjCEventListener::handleEvent): Bye bye isWindowEvent.
-
- * bindings/scripts/CodeGeneratorJS.pm: Autogeneration support for
- marking and invalidating event listeners.
-
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::dispatchModifiedEvent):
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::insertBefore):
- (WebCore::ContainerNode::replaceChild):
- (WebCore::willRemoveChild):
- (WebCore::ContainerNode::appendChild):
- (WebCore::dispatchChildInsertionEvents):
- (WebCore::dispatchChildRemovalEvents):
- * dom/Document.cpp:
- (WebCore::Document::removeAllEventListeners):
- (WebCore::Document::implicitClose):
- (WebCore::Document::setFocusedNode):
- (WebCore::Document::dispatchWindowEvent):
- (WebCore::Document::dispatchWindowLoadEvent):
- (WebCore::Document::finishedParsing):
- * dom/Document.h: Use dispatchEvent directly.
-
- * dom/Element.h: Moved a few event listener attributes down from Node,
- since they don't apply to all Nodes, only Elements.
-
- * dom/EventListener.h: Removed isWindowEvent parameter.
-
- * dom/EventNames.h: Added the "display" event name, so it works correctly
- with attribute macros, and for performance.
-
- * dom/EventTarget.cpp:
- (WebCore::forbidEventDispatch):
- (WebCore::allowEventDispatch):
- (WebCore::eventDispatchForbidden): Made this code (embarrasingly) thread
- safe, since it's now called on multiple threads. (Currently, we only forbid
- event dispatch on the main thread. If we ever want to forbid event dispatch
- on secondary threads, we can improve it then.)
-
- (WebCore::EventTarget::addEventListener):
- (WebCore::EventTarget::removeEventListener):
- (WebCore::EventTarget::setAttributeEventListener):
- (WebCore::EventTarget::getAttributeEventListener):
- (WebCore::EventTarget::clearAttributeEventListener):
- (WebCore::EventTarget::dispatchEvent):
- (WebCore::EventTarget::fireEventListeners):
- (WebCore::EventTarget::getEventListeners):
- (WebCore::EventTarget::removeAllEventListeners):
- * dom/EventTarget.h:
- (WebCore::FiringEventEndIterator::FiringEventEndIterator):
- (WebCore::EventTarget::ref):
- (WebCore::EventTarget::deref):
- (WebCore::EventTarget::markEventListeners):
- (WebCore::EventTarget::invalidateEventListeners):
- (WebCore::EventTarget::isFiringEventListeners):
- (WebCore::EventTarget::hasEventListeners): The ONE TRUE IMPLEMENTATION of
- EventTarget APIs, crafted from an amalgam of all the different versions
- we used to have. The most significant change here is that we no longer
- make a copy of an EventListener vector before firing the events in the
- vector -- instead, we use a reference to the original vector, along with
- a notification mechanism for the unlikely case when an EventListener is
- removed from the vector. This substantially reduces malloc, copying, and
- refcount overhead, and complexity.
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::setValueFromRenderer):
- * dom/MessageEvent.h:
- (WebCore::MessageEvent::create): Use dispatchEvent directly.
-
- * dom/MessagePort.cpp:
- (WebCore::MessagePort::dispatchMessages):
- (WebCore::MessagePort::eventTargetData):
- (WebCore::MessagePort::ensureEventTargetData):
- * dom/MessagePort.h:
- (WebCore::MessagePort::setOnmessage):
- (WebCore::MessagePort::onmessage):
- * dom/MessagePort.idl: Removed custom EventTarget implementation.
-
- * dom/MutationEvent.h:
- (WebCore::MutationEvent::create): Added some default values so callers
- can construct MutationEvents more easily, without calling a custom dispatch
- function.
-
- * dom/Node.cpp:
- (WebCore::Node::addEventListener):
- (WebCore::Node::removeEventListener):
- (WebCore::Node::eventTargetData):
- (WebCore::Node::ensureEventTargetData):
- (WebCore::Node::handleLocalEvents):
- (WebCore::Node::dispatchEvent):
- (WebCore::Node::dispatchGenericEvent):
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- (WebCore::Node::dispatchUIEvent):
- (WebCore::Node::dispatchKeyEvent):
- (WebCore::Node::dispatchMouseEvent):
- (WebCore::Node::dispatchWheelEvent):
- (WebCore::Node::dispatchFocusEvent):
- (WebCore::Node::dispatchBlurEvent):
- * dom/Node.h:
- (WebCore::Node::preDispatchEventHandler):
- (WebCore::Node::postDispatchEventHandler):
- * dom/Node.idl:
- * dom/NodeRareData.h:
- (WebCore::NodeRareData::eventTargetData):
- (WebCore::NodeRareData::ensureEventTargetData): Use the shared EventTarget
- interface, and call dispatchEvent directly instead of custom dispatchXXXEvent
- functions that just forwarded to dispatchEvent.
-
- * dom/RegisteredEventListener.cpp:
- * dom/RegisteredEventListener.h:
- (WebCore::RegisteredEventListener::RegisteredEventListener):
- (WebCore::operator==): This is just a simple struct now, since we no longer
- do a complicated copy / refCount / isRemoved dance just to honor the rule
- that an EventListener can be removed during event dispatch.
-
- * history/CachedFrame.cpp:
- (WebCore::CachedFrameBase::restore): Removed another custom dispatchEvent.
-
- * html/HTMLBodyElement.cpp:
- * html/HTMLBodyElement.h: Use the shared EventTarget API.
-
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
- (WebCore::HTMLFormControlElement::checkValidity):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::handleLocalEvents):
- (WebCore::HTMLFormElement::prepareSubmit):
- (WebCore::HTMLFormElement::reset):
- * html/HTMLFormElement.h: Use the standard dispatchEvent API.
-
- * html/HTMLFrameSetElement.cpp:
- * html/HTMLFrameSetElement.h: Use the shared EventTarget API.
-
- * html/HTMLImageLoader.cpp:
- (WebCore::HTMLImageLoader::dispatchLoadEvent):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::onSearch):
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::loadInternal):
- * html/HTMLScriptElement.cpp:
- (WebCore::HTMLScriptElement::dispatchLoadEvent):
- (WebCore::HTMLScriptElement::dispatchErrorEvent):
- * html/HTMLSourceElement.cpp:
- (WebCore::HTMLSourceElement::errorEventTimerFired):
- * html/HTMLTokenizer.cpp:
- (WebCore::HTMLTokenizer::notifyFinished): Use the standard dispatchEvent API.
-
- * inspector/InspectorDOMAgent.cpp:
- (WebCore::InspectorDOMAgent::handleEvent):
- * inspector/InspectorDOMAgent.h:
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::handleEvent):
- * inspector/InspectorDOMStorageResource.h:
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::stopLoading):
- (WebCore::FrameLoader::canCachePageContainingThisFrame):
- (WebCore::FrameLoader::logCanCacheFrameDecision):
- (WebCore::HashChangeEventTask::performTask):
- (WebCore::FrameLoader::pageHidden): No more isWindowEvent.
-
- * loader/ImageDocument.cpp:
- (WebCore::ImageEventListener::handleEvent):
- * loader/appcache/ApplicationCacheGroup.cpp:
- (WebCore::CallCacheListenerTask::performTask):
- * loader/appcache/ApplicationCacheHost.cpp:
- (WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
- * loader/appcache/ApplicationCacheHost.h:
- * loader/appcache/DOMApplicationCache.cpp:
- (WebCore::DOMApplicationCache::eventTargetData):
- (WebCore::DOMApplicationCache::ensureEventTargetData):
- * loader/appcache/DOMApplicationCache.h:
- * loader/appcache/DOMApplicationCache.idl: Switched to the standard
- EventTarget API. As a part of this, I switched this class from using a
- custom internal event name enumeration to using the standard EventNames.
-
- * notifications/Notification.cpp:
- (WebCore::Notification::eventTargetData):
- (WebCore::Notification::ensureEventTargetData):
- * notifications/Notification.h:
- (WebCore::Notification::scriptExecutionContext):
- * notifications/Notification.idl: Switched to the standard EventTarget API.
-
- * page/DOMWindow.cpp:
- (WebCore::PostMessageTimer::event):
- (WebCore::windowsWithUnloadEventListeners):
- (WebCore::windowsWithBeforeUnloadEventListeners):
- (WebCore::allowsBeforeUnloadListeners):
- (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
- (WebCore::DOMWindow::pendingUnloadEventListeners):
- (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Changed the "pending"
- unload / beforeunload listener tracker just to track which windows had
- such listeners, instead of actually keeping a copy of the listeners. Now,
- this code can use the standard EventTarget API.
-
- (WebCore::DOMWindow::~DOMWindow):
- (WebCore::DOMWindow::postMessageTimerFired):
- (WebCore::DOMWindow::addEventListener):
- (WebCore::DOMWindow::removeEventListener):
- (WebCore::DOMWindow::dispatchLoadEvent):
- (WebCore::DOMWindow::dispatchEvent):
- (WebCore::DOMWindow::removeAllEventListeners):
- (WebCore::DOMWindow::captureEvents):
- (WebCore::DOMWindow::releaseEvents):
- (WebCore::DOMWindow::eventTargetData):
- (WebCore::DOMWindow::ensureEventTargetData):
- * page/DOMWindow.h:
- * page/DOMWindow.idl: Use the standard EventTarget APIs.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::canMouseDownStartSelect):
- (WebCore::EventHandler::canMouseDragExtendSelect):
- (WebCore::EventHandler::sendResizeEvent):
- (WebCore::EventHandler::sendScrollEvent): Use dispatchEvent directly.
-
- * page/EventSource.cpp:
- (WebCore::EventSource::endRequest):
- (WebCore::EventSource::didReceiveResponse):
- (WebCore::EventSource::parseEventStreamLine):
- (WebCore::EventSource::stop):
- (WebCore::EventSource::createMessageEvent):
- (WebCore::EventSource::eventTargetData):
- (WebCore::EventSource::ensureEventTargetData):
- * page/EventSource.h:
- * page/EventSource.idl: Use the standard EventTarget APIs.
-
- * page/FocusController.cpp:
- (WebCore::dispatchEventsOnWindowAndFocusedNode):
- (WebCore::FocusController::setFocusedFrame):
- * page/Frame.cpp:
- (WebCore::Frame::shouldClose):
- * page/Frame.h:
- * page/Page.cpp:
- (WebCore::networkStateChanged):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
- * rendering/RenderListBox.cpp:
- (WebCore::RenderListBox::valueChanged):
- * rendering/RenderTextControl.cpp:
- (WebCore::RenderTextControl::selectionChanged):
- * rendering/RenderTextControlMultiLine.cpp:
- (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Use dispatchEvent.
-
- * svg/SVGElement.cpp:
- (WebCore::hasLoadListener): Rewritten for new EventTarget API.
-
- * svg/SVGElementInstance.cpp:
- (WebCore::dummyEventTargetData):
- (WebCore::SVGElementInstance::addEventListener):
- (WebCore::SVGElementInstance::removeEventListener):
- (WebCore::SVGElementInstance::removeAllEventListeners):
- (WebCore::SVGElementInstance::dispatchEvent):
- (WebCore::SVGElementInstance::eventTargetData):
- (WebCore::SVGElementInstance::ensureEventTargetData): Use the EventTarget API.
-
- * svg/SVGElementInstance.h:
- * svg/SVGImageLoader.cpp:
- (WebCore::SVGImageLoader::dispatchLoadEvent):
- * svg/SVGScriptElement.cpp:
- (WebCore::SVGScriptElement::dispatchErrorEvent): Use dispatchEvent directly.
-
- * svg/SVGUseElement.cpp:
- (WebCore::SVGUseElement::transferEventListenersToShadowTree): Updated for
- new EventTarget API.
-
- * svg/animation/SVGSMILElement.cpp:
- (WebCore::ConditionEventListener::handleEvent): No more isWindowEvent.
-
- * websockets/WebSocket.cpp:
- (WebCore::ProcessWebSocketEventTask::create):
- (WebCore::ProcessWebSocketEventTask::performTask):
- (WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask):
- (WebCore::WebSocket::didConnect):
- (WebCore::WebSocket::didReceiveMessage):
- (WebCore::WebSocket::didClose):
- (WebCore::WebSocket::eventTargetData):
- (WebCore::WebSocket::ensureEventTargetData):
- * websockets/WebSocket.h:
- * websockets/WebSocket.idl:
- * workers/AbstractWorker.cpp:
- (WebCore::AbstractWorker::eventTargetData):
- (WebCore::AbstractWorker::ensureEventTargetData):
- * workers/AbstractWorker.h:
- * workers/AbstractWorker.idl:
- * workers/DedicatedWorkerContext.cpp:
- * workers/DedicatedWorkerContext.h:
- * workers/DedicatedWorkerContext.idl:
- * workers/DefaultSharedWorkerRepository.cpp:
- (WebCore::SharedWorkerConnectTask::performTask):
- (WebCore::SharedWorkerScriptLoader::load):
- (WebCore::SharedWorkerScriptLoader::notifyFinished):
- * workers/SharedWorker.idl:
- * workers/SharedWorkerContext.cpp:
- (WebCore::createConnectEvent):
- * workers/SharedWorkerContext.h:
- * workers/SharedWorkerContext.idl:
- * workers/Worker.cpp:
- (WebCore::Worker::notifyFinished):
- * workers/Worker.h:
- * workers/Worker.idl:
- * workers/WorkerContext.cpp:
- (WebCore::WorkerContext::eventTargetData):
- (WebCore::WorkerContext::ensureEventTargetData):
- * workers/WorkerContext.h:
- * workers/WorkerContext.idl:
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::MessageWorkerContextTask::performTask):
- (WebCore::MessageWorkerTask::performTask):
- (WebCore::WorkerExceptionTask::performTask):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- (WebCore::XMLHttpRequest::createRequest):
- (WebCore::XMLHttpRequest::abort):
- (WebCore::XMLHttpRequest::networkError):
- (WebCore::XMLHttpRequest::abortError):
- (WebCore::XMLHttpRequest::didSendData):
- (WebCore::XMLHttpRequest::didReceiveData):
- (WebCore::XMLHttpRequest::eventTargetData):
- (WebCore::XMLHttpRequest::ensureEventTargetData):
- * xml/XMLHttpRequest.h:
- * xml/XMLHttpRequest.idl:
- * xml/XMLHttpRequestProgressEvent.h:
- (WebCore::XMLHttpRequestProgressEvent::create):
- * xml/XMLHttpRequestUpload.cpp:
- (WebCore::XMLHttpRequestUpload::eventTargetData):
- (WebCore::XMLHttpRequestUpload::ensureEventTargetData):
- * xml/XMLHttpRequestUpload.h:
- * xml/XMLHttpRequestUpload.idl: Use new EventTarget API.
-
-2009-09-23 Kent Tamura <tkent at chromium.org>
-
- Reviewed by Darin Adler.
-
- - Support for maxLength of <textarea>
- - Move numGraphemeClusters() and numCharactersInGraphemeClusters() from InputElement to String.
- https://bugs.webkit.org/show_bug.cgi?id=29292
-
- Test: fast/forms/textarea-maxlength.html
-
- * dom/InputElement.cpp:
- (WebCore::InputElement::sanitizeUserInputValue):
- (WebCore::InputElement::handleBeforeTextInsertedEvent):
- * html/HTMLTextAreaElement.cpp:
- (WebCore::HTMLTextAreaElement::defaultEventHandler):
- (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
- (WebCore::HTMLTextAreaElement::sanitizeUserInputValue):
- (WebCore::HTMLTextAreaElement::maxLength):
- (WebCore::HTMLTextAreaElement::setMaxLength):
- * html/HTMLTextAreaElement.h:
- * html/HTMLTextAreaElement.idl:
- * platform/text/PlatformString.h:
- * platform/text/String.cpp:
- (WebCore::String::numGraphemeClusters):
- (WebCore::String::numCharactersInGraphemeClusters):
-
-2009-09-23 Martin Robinson <martin.james.robinson at gmail.com>
-
- Reviewed by Xan Lopez.
-
- [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
- https://bugs.webkit.org/show_bug.cgi?id=29654
-
- Give GDK_Backspace key events the proper text properties.
-
- Instead of adding new tests, this change removes existing tests
- from Gtk's skipped list.
-
- * platform/gtk/KeyEventGtk.cpp:
- (WebCore::keyIdentifierForGdkKeyCode):
- (WebCore::singleCharacterString):
-
-2009-09-23 Sam Weinig <sam at webkit.org>
-
- Reviewed by Adam Barth.
-
- Fix for https://bugs.webkit.org/show_bug.cgi?id=26989
- Should allow navigation of top-level openers
- <rdar://problem/7034025>
-
- Allow navigation of cross-origin window.opener if it is top-level frame.
-
- Test: http/tests/security/frameNavigation/cross-origin-opener.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::shouldAllowNavigation):
-
-2009-09-23 Marshall Culpepper <mculpepper at appcelerator.com>
-
- Reviewed by Eric Seidel.
-
- Added $(WebKitLibrariesDir)/include/cairo so cairo.h is found by
- default when the necessary dependencies are extracted into the
- WebKitLibrariesDir.
- https://bugs.webkit.org/show_bug.cgi?id=29661
-
- * WebCore.vcproj/WebCoreCairo.vsprops:
-
-2009-09-23 Darin Adler <darin at apple.com>
-
- Reviewed by Sam Weinig.
-
- Crash when website does a history.back() followed by an alert()
- https://bugs.webkit.org/show_bug.cgi?id=29686
- rdar://problem/6984996
-
- When loading is deferred, we need to defer timer-based loads
- too, not just networking-driven loads. Otherwise we can get
- syncronouse navigation while running a script, which leads to
- crashes and other badness.
-
- This patch includes a manual test; an automated test may be
- possible some time in the future.
-
- * dom/Document.cpp:
- (WebCore::Document::processHttpEquiv): Use scheduleLocationChange
- instead of scheduleHTTPRedirection to implement the navigation
- needed for x-frame-options.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::FrameLoader): Updated for data members with
- new names and new data members.
- (WebCore::FrameLoader::setDefersLoading): When turning deferral
- off, call startRedirectionTimer and startCheckCompleteTimer, since
- either of them might have been fired and ignored while defersLoading
- was true.
- (WebCore::FrameLoader::clear): Updated for replacement of the
- m_checkCompletedTimer and m_checkLoadCompleteTimer timers.
- (WebCore::FrameLoader::allAncestorsAreComplete): Added.
- (WebCore::FrameLoader::checkCompleted): Added code to set
- m_shouldCallCheckCompleted to false. Changed code that calls
- startRedirectionTimer to call it unconditionally, since that
- function now knows when to do work and doesn't expect callers
- to handle that any more.
- (WebCore::FrameLoader::checkTimerFired): Added. Replaces the old
- timer fired callbacks. Calls checkCompleted and checkLoadComplete
- as appropriate, but not when defersLoading is true.
- (WebCore::FrameLoader::startCheckCompleteTimer): Added. Replaces
- the two different calls to start timers before. Only starts the
- timers if they are needed.
- (WebCore::FrameLoader::scheduleCheckCompleted): Changed to call
- startCheckCompleteTimer after setting boolean.
- (WebCore::FrameLoader::scheduleCheckLoadComplete): Ditto.
- (WebCore::FrameLoader::scheduleHistoryNavigation): Removed
- canGoBackOrForward check. The logic works more naturally when
- we don't do anything until the timer fires.
- (WebCore::FrameLoader::redirectionTimerFired): Do nothing if
- defersLoading is true. Also moved canGoBackOrForward check here.
- (WebCore::FrameLoader::scheduleRedirection): Changed code that
- calls startRedirectionTimer to do so unconditionally. That
- function now handles the rules about when to start the timer
- rather than expecting the caller to do so.
- (WebCore::FrameLoader::startRedirectionTimer): Added code to
- handle the case where there is no redirection scheduled,
- where the timer is already active, or where this is a classic
- redirection and there is an ancestor that has not yet completed
- loading.
- (WebCore::FrameLoader::completed): Call startRedirectionTimer
- here directly instead of calling a cover named parentCompleted.
- Hooray! One less function in the giant FrameLoader class!
- (WebCore::FrameLoader::checkLoadComplete): Added code to set
- m_shouldCallCheckLoadComplete to false.
-
- * loader/FrameLoader.h: Replaced the two functions
- checkCompletedTimerFired and checkLoadCompleteTimerFired with
- one function, checkTimerFired. Removed the parentCompleted
- function. Added the startCheckCompleteTimer and
- allAncestorsAreComplete functions. Replaced the
- m_checkCompletedTimer and m_checkLoadCompleteTimer data
- members with m_checkTimer, m_shouldCallCheckCompleted, and
- m_shouldCallCheckLoadComplete.
-
- * manual-tests/go-back-after-alert.html: Added.
- * manual-tests/resources/alert-and-go-back.html: Added.
-
-2009-09-23 David Kilzer <ddkilzer at apple.com>
-
- <http://webkit.org/b/29660> Move "Generate 64-bit Export File" build phase script into DerivedSources.make
-
- Reviewed by Mark Rowe.
-
- The "Generate 64-bit Export File" build phase script generated
- the WebCore.LP64.exp export file used to link 64-bit WebCore.
- Instead of having a separate build phase script, move its
- generation into DerivedSources.make where WebCore.exp is
- generated.
-
- * DerivedSources.make: Added a rule to make WebCore.LP64.exp.
- Added code to append WebCore.PluginHostProcess.exp to
- $(WEBCORE_EXPORT_DEPENDENCIES) when WTF_USE_PLUGIN_HOST_PROCESS
- is set to 1.
- * WebCore.PluginHostProcess.exp: Renamed from WebCore/WebCore.LP64.exp.
- * WebCore.xcodeproj/project.pbxproj: Removed the "Generate
- 64-bit Export File" build phase script. Renamed WebCore.LP64.exp
- to WebCore.PluginHostProcess.exp.
-
-2009-09-23 Peter Kasting <pkasting at google.com>
-
- Reviewed by Dimitri Glazkov.
-
- https://bugs.webkit.org/show_bug.cgi?id=29694
- [Chromium] Eliminate dependency on gfx::Rect from ImageSkia.
-
- * platform/graphics/skia/ImageSkia.cpp:
- (WebCore::drawResampledBitmap):
-
-2009-09-22 Timothy Hatcher <timothy at apple.com>
-
- Prevent scrolling multiple elements during latched wheel events.
-
- Reviewed by Anders Carlsson.
-
- * page/EventHandler.cpp:
- (WebCore::scrollAndAcceptEvent):
- (WebCore::EventHandler::clear):
- (WebCore::EventHandler::handleWheelEvent):
- * page/EventHandler.h:
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::scroll):
- * rendering/RenderBox.h:
-
-2009-09-23 Daniel Bates <dbates at webkit.org>
-
- Reviewed by Adam Barth.
-
- https://bugs.webkit.org/show_bug.cgi?id=29523
-
- Fixes an issue where a JavaScript URL that was URL-encoded twice can bypass the
- XSSAuditor.
-
- The method FrameLoader::executeIfJavaScriptURL decodes the URL escape
- sequences in a JavaScript URL before it is eventually passed to the XSSAuditor.
- Because the XSSAuditor also decodes the URL escape sequences as part of its
- canonicalization, the double decoding of a JavaScript URL would
- not match the canonicalization of the input parameters.
-
- Tests: http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html
- http/tests/security/xssAuditor/javascript-link-url-encoded.html
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::evaluate): Moved call to
- XSSAuditor::canEvaluateJavaScriptURL into FrameLoader::executeIfJavaScriptURL.
- * bindings/v8/ScriptController.cpp:
- (WebCore::ScriptController::evaluate): Ditto.
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::executeIfJavaScriptURL): Modified to call
- XSSAuditor::canEvaluateJavaScriptURL on the JavaScript URL before it is
- decoded.
-
-2009-09-22 Dave Hyatt <hyatt at apple.com>
-
- Reviewed by John Sullivan.
-
- https://bugs.webkit.org/show_bug.cgi?id=29657
- Columns don't break properly in positioned elements with a fixed height. Make sure that
- a block is still considered to have columns even when the column count is 1 if the column
- width is non-auto.
-
- Added fast/multicol/positioned-with-constrained-height.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
-
-2009-09-23 Holger Hans Peter Freyther <zecke at selfish.org>
-
- Rubber-stamped by Simon Hausmann.
-
- Add a null check for the Document*. In the mirror benchmarking
- application a crash from a call from JavaScript was observed.
-
- I was not able to come up with a test case for this issue.
-
- * platform/qt/CookieJarQt.cpp:
- (WebCore::cookieJar):
-
-2009-09-23 Simon Hausmann <simon.hausmann at nokia.com>
-
- Reviewed by Tor Arne Vestbø.
-
- Fix the Qt/Windows build, after the introduction of
- the page client.
-
- * plugins/win/PluginViewWin.cpp:
- (windowHandleForPageClient):
- (WebCore::PluginView::getValue):
- (WebCore::PluginView::forceRedraw):
- (WebCore::PluginView::platformStart):
-
-2009-09-23 Gustavo Noronha Silva <gns at gnome.org>
-
- Reviewed by Xan Lopez.
-
- [GTK] media tests failing after their rework
- https://bugs.webkit.org/show_bug.cgi?id=29532
-
- Correctly advertise the mime types used by the common formats used
- in the tests.
-
- Tests that regressed, and will pass again:
-
- media/video-canvas-source.html
- media/video-controls.html
- media/video-currentTime-set2.html
- media/video-dom-autoplay.html
- media/video-dom-src.html
- media/video-error-abort.html
- media/video-load-networkState.html
- media/video-load-readyState.html
- media/video-muted.html
- media/video-no-autoplay.html
- media/video-pause-empty-events.html
- media/video-play-empty-events.html
- media/video-seekable.html
- media/video-seeking.html
- media/video-size.html
- media/video-source-type-params.html
- media/video-source-type.html
- media/video-source.html
- media/video-src-change.html
- media/video-src-invalid-remove.html
- media/video-src-remove.html
- media/video-src-set.html
- media/video-src-source.html
- media/video-src.html
- media/video-timeupdate-during-playback.html
- media/video-volume.html
-
- * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::mimeTypeCache):
-
-2009-09-22 Charles Wei <charles.wei at torchmobile.com.cn>
-
- Reviewed by Eric Seidel.
-
- Fix the crash problem with absolte positioned children in foreignobject
- htts://bugs.webkit.org/show_bug.cgi?id=26342
-
- Test: svg/custom/foreignobject-crash-with-absolute-positioned-children.svg
-
- * rendering/RenderForeignObject.h:
- (WebCore::RenderForeignObject::isSVGForeignObject):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containingBlock):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isSVGForeignObject):
-
-2009-09-22 Drew Wilson <atwilson at google.com>
-
- Reviewed by David Levin.
-
- SharedWorkers "name" attribute is now optional.
- https://bugs.webkit.org/show_bug.cgi?id=28897
-
- Test: fast/workers/shared-worker-name.html
-
- * bindings/js/JSSharedWorkerConstructor.cpp:
- (WebCore::constructSharedWorker):
- Default 'name' attribute to empty string if it is not provided.
- * bindings/v8/custom/V8SharedWorkerCustom.cpp:
- (WebCore::CALLBACK_FUNC_DECL):
- Default 'name' attribute to empty string if it is not provided.
- * workers/DefaultSharedWorkerRepository.cpp:
- (WebCore::SharedWorkerProxy::matches):
- Now matches URLs if names are empty strings.
- (WebCore::DefaultSharedWorkerRepository::getProxy):
- Pass URL in to SharedWorkerProxy::matches().
-
-2009-09-22 Dimitri Glazkov <dglazkov at chromium.org>
-
- Unreviewed, another build fix.
-
- [Chromium] Add another missing include.
- https://bugs.webkit.org/show_bug.cgi?id=29536
-
- * inspector/InspectorController.cpp: Added DOMWindow.h include.
-
-2009-09-22 Dimitri Glazkov <dglazkov at chromium.org>
-
- Unreviewed, build fix.
-
- [Chromium] Add missing include.
- https://bugs.webkit.org/show_bug.cgi?id=29536
-
- * inspector/InspectorDOMStorageResource.cpp: Added DOMWindow.h include.
-
-2009-09-22 Darin Adler <darin at apple.com>
-
- Reviewed by Sam Weinig.
-
- Tighten up the ScheduledRedirection machinery to prepare for a bug fix
- https://bugs.webkit.org/show_bug.cgi?id=29663
-
- * loader/FrameLoader.cpp:
- (WebCore::ScheduledRedirection::ScheduledRedirection): Added a boolean,
- initialized to false, to keep track if the redirection has been
- communicated to the client.
- (WebCore::FrameLoader::stopLoading): Tweaked a comment.
- (WebCore::FrameLoader::cancelRedirection): Removed code to clear
- m_scheduledRedirection.clear since stopRedirectionTimer does that now.
- (WebCore::FrameLoader::allChildrenAreComplete): Added.
- (WebCore::FrameLoader::checkCompleted): Use allChildrenAreComplete
- function for clarity.
- (WebCore::FrameLoader::checkCallImplicitClose): Ditto.
- (WebCore::FrameLoader::scheduleRedirection): Changed to take a PassOwnPtr.
- (WebCore::FrameLoader::startRedirectionTimer): Added code to set the
- toldClient flag and not call clientRedirected a second time if it is set.
- (WebCore::FrameLoader::stopRedirectionTimer): Changed so this can be safely
- called multiple times and it will call clientRedirectCancelledOrFinished
- only once.
-
- * loader/FrameLoader.h: Changed scheduleRedirection to be a PassOwnPtr.
- Added allChildrenAreComplete function.
-
-2009-09-22 Yury Semikhatsky <yurys at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- WebInspector: Migrate Databases tab to InjectedScript /
- serialized interaction.
-
- DOMStorage interaction is now serialized into JSON messages
- and doesn't require quarantined objects.
-
- https://bugs.webkit.org/show_bug.cgi?id=28873
-
- * dom/EventListener.h:
- (WebCore::EventListener::):
- * inspector/InspectorBackend.cpp:
- (WebCore::InspectorBackend::selectDOMStorage):
- (WebCore::InspectorBackend::getDOMStorageEntries):
- (WebCore::InspectorBackend::setDOMStorageItem):
- (WebCore::InspectorBackend::removeDOMStorageItem):
- * inspector/InspectorBackend.h:
- * inspector/InspectorBackend.idl:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::didCommitLoad):
- (WebCore::InspectorController::selectDOMStorage):
- (WebCore::InspectorController::getDOMStorageEntries):
- (WebCore::InspectorController::setDOMStorageItem):
- (WebCore::InspectorController::removeDOMStorageItem):
- (WebCore::InspectorController::getDOMStorageResourceForId):
- * inspector/InspectorController.h:
- * inspector/InspectorDOMStorageResource.cpp:
- (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
- (WebCore::InspectorDOMStorageResource::bind):
- (WebCore::InspectorDOMStorageResource::unbind):
- (WebCore::InspectorDOMStorageResource::startReportingChangesToFrontend):
- (WebCore::InspectorDOMStorageResource::handleEvent):
- (WebCore::InspectorDOMStorageResource::operator==):
- * inspector/InspectorDOMStorageResource.h:
- (WebCore::InspectorDOMStorageResource::cast):
- (WebCore::InspectorDOMStorageResource::id):
- (WebCore::InspectorDOMStorageResource::domStorage):
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::selectDOMStorage):
- (WebCore::InspectorFrontend::didGetDOMStorageEntries):
- (WebCore::InspectorFrontend::didSetDOMStorageItem):
- (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
- (WebCore::InspectorFrontend::updateDOMStorage):
- * inspector/InspectorFrontend.h:
- * inspector/front-end/DOMStorage.js:
- (WebInspector.DOMStorage):
- (WebInspector.DOMStorage.prototype.get id):
- (WebInspector.DOMStorage.prototype.get domStorage):
- (WebInspector.DOMStorage.prototype.get isLocalStorage):
- (WebInspector.DOMStorage.prototype.getEntriesAsync):
- (WebInspector.DOMStorage.prototype.setItemAsync):
- (WebInspector.DOMStorage.prototype.removeItemAsync):
- * inspector/front-end/DOMStorageDataGrid.js:
- (WebInspector.DOMStorageDataGrid):
- (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode):
- (WebInspector.DOMStorageDataGrid.prototype._startEditing):
- (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
- (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
- (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
- * inspector/front-end/DOMStorageItemsView.js:
- (WebInspector.DOMStorageItemsView.prototype.update):
- (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
- (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- * inspector/front-end/StoragePanel.js:
- (WebInspector.StoragePanel.prototype.show):
- (WebInspector.StoragePanel.prototype.reset):
- (WebInspector.StoragePanel.prototype.selectDOMStorage):
- (WebInspector.StoragePanel.prototype.updateDOMStorage):
- (WebInspector.StoragePanel.prototype._domStorageForId):
- * inspector/front-end/inspector.js:
- (WebInspector.addDOMStorage):
- (WebInspector.updateDOMStorage):
-
-2009-09-22 Sam Weinig <sam at webkit.org>
-
- Reviewed by Alexey Proskuryakov.
-
- Fix for XMLHttpRequest.abort() should destroy the response text.
- https://bugs.webkit.org/show_bug.cgi?id=29658
- <rdar://problem/5301430>
-
- Clearing the response text after calling XMLHttpRequest.abort() is necessary
- per spec and matches Firefox. It is also a potential memory win.
-
- Test: http/tests/xmlhttprequest/abort-should-destroy-responseText.html
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::abort): Clear the response text making sure to
- keep the actual ResourceReponse around so that the response status and response
- status text are kept around.
-
-2009-09-22 Dimitri Glazkov <dglazkov at chromium.org>
-
- No review, rolling out r48639.
- http://trac.webkit.org/changeset/48639
-
- * bindings/v8/V8GCController.cpp:
- (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
-
-2009-09-22 Dumitru Daniliuc <dumi at chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Changing the transaction coordinator to (re-)allow multiple read
- transactions on the same database to run concurrently (without
- risking a deadlock this time).
-
- https://bugs.webkit.org/show_bug.cgi?id=29115
-
- Tests: storage/read-and-write-transactions-dont-run-together.html
- storage/read-transactions-running-concurrently.html
-
- * storage/SQLTransaction.h:
- (WebCore::SQLTransaction::isReadOnly): Returns the type of the
- transaction.
- * storage/SQLTransactionCoordinator.cpp:
- (WebCore::SQLTransactionCoordinator::acquireLock): Changed to
- allow multiple read transactions on the same DB to run
- concurrently.
- (WebCore::SQLTransactionCoordinator::releaseLock): Changed to
- allow multiple read transactions on the same DB to run
- concurrently.
- (WebCore::SQLTransactionCoordinator::shutdown): Renamed the map.
- * storage/SQLTransactionCoordinator.h:
-
-2009-09-22 Peter Kasting <pkasting at google.com>
-
- Reviewed by David Levin.
-
- https://bugs.webkit.org/show_bug.cgi?id=29652
- Support true system colors for CSS system colors in Chromium/Win.
-
- * rendering/RenderThemeChromiumWin.cpp:
- (WebCore::cssValueIdToSysColorIndex):
- (WebCore::RenderThemeChromiumWin::systemColor):
- * rendering/RenderThemeChromiumWin.h:
-
-2009-09-22 Beth Dakin <bdakin at apple.com>
-
- Reviewed by Dave Hyatt.
-
- Fix for <rdar://problem/6925121> SAP: Wrong width calculation in
- table with fixed layout
- -and corresponding-
- https://bugs.webkit.org/show_bug.cgi?id=29501
-
- New Tests:
- * fast/table/fixed-table-with-percent-inside-percent-table.html: Added.
- * fast/table/fixed-table-with-percent-width-inside-auto-table.html: Added.
- * fast/table/fixed-table-with-percent-width-inside-div.html: Added.
- * fast/table/fixed-table-with-percent-width-inside-extra-large-div.html: Added.
- * fast/table/fixed-table-with-percent-width-inside-fixed-width-table.html: Added.
- * fast/table/fixed-table-with-small-percent-width.html: Added.
-
- This new quirk is very similar to an existing one that was
- implemented in revision 4316.
- * rendering/FixedTableLayout.cpp:
- (WebCore::FixedTableLayout::calcPrefWidths):
-
-2009-09-22 Brian Weinstein <bweinstein at apple.com>
-
- Reviewed by Timothy Hatcher.
-
- List HTTP status code with response headers in resources tab of Web Inspector.
- http://webkit.org/b/19945
-
- This patch adds a new top level list in the resources tab, HTTP Information, that
- for now, contains the Request Method (GET, POST, etc.) and the Status Code (200, 404, etc.).
- Additionally, it adds a colored dot next to the requested URL to show the status
- (green for success, orange for redirect, red for error).
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/ImageView.js:
- (WebInspector.ImageView):
- * inspector/front-end/Images/errorRedDot.png: Added.
- * inspector/front-end/Images/successGreenDot.png: Added.
- * inspector/front-end/Images/warningOrangeDot.png: Added.
- * inspector/front-end/Resource.js:
- (WebInspector.Resource.StatusTextForCode):
- * inspector/front-end/ResourceView.js:
- (WebInspector.ResourceView):
- (WebInspector.ResourceView.prototype._refreshURL):
- (WebInspector.ResourceView.prototype._refreshHTTPInformation):
- * inspector/front-end/inspector.css:
-
-2009-09-22 Brady Eidson <beidson at apple.com>
-
- Reviewed by Darin Adler.
-
- Back list isn't properly updated for fragment changes after a redirect.
- <rdar://problem/6142803> and https://bugs.webkit.org/show_bug.cgi?id=20355
-
- Test: fast/loader/fragment-after-redirect-gets-back-entry.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::loadURL): Properly reset the policy FrameLoadType before
- consulting the policy delegate for fragment scrolling.
-
-2009-09-22 Darin Fisher <darin at chromium.org>
-
- Reviewed by Dimitri Glazkov.
-
- Drop down selects get stuck in the non-visible state and cannot be opened.
- https://bugs.webkit.org/show_bug.cgi?id=29645
-
- All paths that lead to hiding the popup menu must call popupDidHide on
- the PopupMenuClient. This change makes it so by moving all of the
- hiding logic to PopupListBox::hidePopup.
-
- * platform/chromium/PopupMenuChromium.cpp:
- (WebCore::PopupContainer::hidePopup):
- (WebCore::PopupListBox::hidePopup):
- * platform/chromium/PopupMenuChromium.h:
-
-2009-09-22 Patrick Mueller <Patrick_Mueller at us.ibm.com>
-
- Reviewed by Timothy Hatcher.
-
- WebInspector.log() function not protected if console not yet created
- https://bugs.webkit.org/show_bug.cgi?id=29336
-
- No new tests. Only affects Web Inspector developers adding logging
- to their code during development.
-
- * inspector/front-end/inspector.js:
- (WebInspector.log.isLogAvailable):
- (WebInspector.log.flushQueue):
- (WebInspector.log.flushQueueIfAvailable):
- (WebInspector.log.logMessage):
- (WebInspector.log):
-
-2009-09-22 Yaar Schnitman <yaar at chromium.org>
-
- Reviewed by David Levin.
-
- Ported chromium.org's webcore.gyp for the webkit chromium port.
-
- https://bugs.webkit.org/show_bug.cgi?id=29617
-
- * WebCore.gyp/WebCore.gyp: Added.
-
-2009-09-22 Christian Plesner Hansen <christian.plesner.hansen at gmail.com>
-
- Reviewed by Adam Barth.
-
- [v8] Don't keep clean wrappers artificially alive
- We currently keep all DOM node wrappers alive, even when there are
- no more references to them from JS, in case they have properties
- that we need to keep around if new JS references are created.
- This changes the policy to only keep wrappers artificially alive
- if they have changed since they were created. Empty wrappers are
- discarded and recreated as needed.
- https://bugs.webkit.org/show_bug.cgi?id=29330
-
- * bindings/v8/V8GCController.cpp:
- (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
-
-2009-09-22 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: console.count and console.timeEnd
- crash when inspector is opened.
-
- https://bugs.webkit.org/show_bug.cgi?id=29632
-
- * inspector/InspectorFrontend.cpp:
- (WebCore::InspectorFrontend::addMessageToConsole):
-
-2009-09-22 Adam Barth <abarth at webkit.org>
-
- Unreviewed.
-
- Fix bogus build fix I did last night.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetTimeoutImpl):
-
-2009-09-22 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
-
- Reviewed by Simon Hausmann.
-
- NPAPI/Mac: Don't paint plugins if we don't have a CGContextRef
-
- * plugins/mac/PluginViewMac.cpp:
-
-2009-09-22 Tor Arne Vestbø <tor.arne.vestbo at nokia.com>
-
- Reivewed by Simon Hausmann.
-
- Fix the Qt/Mac build after r48604 (Implement new QWebPageClient class)
-
- There's no QWidget::x11Info() on Mac, and setPlatformPluginWidget()
- takes a QWidget*, not a QWebPageClient*
-
- * plugins/mac/PluginViewMac.cpp:
- (WebCore::PluginView::platformStart):
-
-2009-09-21 Adam Barth <abarth at webkit.org>
-
- Attempted fix for the V8 build.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetTimeoutImpl):
-
-2009-09-21 Adam Barth <abarth at webkit.org>
-
- Reviewed by Sam Weinig.
-
- Don't re-enter JavaScript after performing access checks
- https://bugs.webkit.org/show_bug.cgi?id=29531
-
- Moved the access check slightly later in this functions to avoid
- re-entering the JavaScript interpreter (typically via toString)
- after performing the access check.
-
- I can't really think of a meaningful test for this change. It's more
- security hygiene.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::JSDOMWindow::setLocation):
- (WebCore::JSDOMWindow::open):
- (WebCore::JSDOMWindow::showModalDialog):
- * bindings/js/JSLocationCustom.cpp:
- (WebCore::JSLocation::setHref):
- (WebCore::JSLocation::replace):
- (WebCore::JSLocation::assign):
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::V8Custom::WindowSetTimeoutImpl):
- (WebCore::if):
- (CALLBACK_FUNC_DECL):
- (V8Custom::WindowSetLocation):
- (V8Custom::ClearTimeoutImpl):
- * bindings/v8/custom/V8LocationCustom.cpp:
- (WebCore::ACCESSOR_SETTER):
- (WebCore::CALLBACK_FUNC_DECL):
-
-2009-09-21 Dumitru Daniliuc <dumi at chromium.org>
-
- Reviewed by Eric Seidel.
-
- Make all write transaction start with a BEGIN IMMEDIATE command
- instead of BEGIN.
-
- We cannot test this change in a layout test, because in order to
- test it we need to spawn two database threads and execute
- transaction steps on these two threads in a very specific order,
- which seems impossible to do when they share the same main thread
- (as they would in a layout test). The SQLite docs and the case
- described in the bug though should be enough proof that we do have
- a problem here and that this patch will fix it.
-
- Relevant SQLite documentation:
- http://www.sqlite.org/lang_transaction.html
- http://www.sqlite.org/lockingv3.html#locking
-
- https://bugs.webkit.org/show_bug.cgi?id=29218
-
- * platform/sql/SQLiteTransaction.cpp:
- (WebCore::SQLiteTransaction::SQLiteTransaction): Added a readOnly
- parameter.
- (WebCore::SQLiteTransaction::begin): Changed to BEGIN IMMEDIATE
- for write transactions.
- * platform/sql/SQLiteTransaction.h:
- * storage/SQLTransaction.cpp:
- (WebCore::SQLTransaction::openTransactionAndPreflight): Passing
- the read-only flag to the SQLiteTransaction instance.
-
-2009-09-21 Brady Eidson <beidson at apple.com>
-
- Rubberstamped by Mark Rowe.
-
- * DerivedSources.make: Fix the Xcode build on SnowLeopard.
-
-2009-09-15 John Abd-El-Malek <jam at chromium.org>
-
- Reviewed by Darin Fisher.
-
- Prevent sleeps in unload handlers.
- https://bugs.webkit.org/show_bug.cgi?id=29193
-
- Test: fast/dom/Window/slow_unload_handler.html
-
- * WebCore.gypi:
- * bindings/v8/DateExtension.cpp: Added.
- (WebCore::DateExtension::DateExtension):
- (WebCore::DateExtension::get):
- (WebCore::DateExtension::setAllowSleep):
- (WebCore::DateExtension::GetNativeFunction):
- (WebCore::DateExtension::weakCallback):
- (WebCore::DateExtension::GiveEnableSleepDetectionFunction):
- (WebCore::DateExtension::OnSleepDetected):
- * bindings/v8/DateExtension.h: Added.
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- * bindings/v8/V8Proxy.cpp:
- (WebCore::V8Proxy::createNewContext):
- (WebCore::V8Proxy::registerExtensionWithV8):
- (WebCore::V8Proxy::registeredExtensionWithV8):
- * bindings/v8/V8Proxy.h:
-
-2009-09-21 Jian Li <jianli at chromium.org>
-
- Reviewed by David Levin.
-
- [V8] Run-time exception in onmessage handler is not forwarded to the
- worker object.
- https://bugs.webkit.org/show_bug.cgi?id=28980
-
- The previous fix was partially reverted due to a reliability build break
- in chromium. The break happens when an exception is thrown without
- setting a message. We need to check for this scenario and handle it.
-
- Tested by worker-close.html.
-
- * bindings/v8/V8AbstractEventListener.cpp:
- (WebCore::V8AbstractEventListener::invokeEventHandler):
- * bindings/v8/V8Utilities.cpp:
- (WebCore::reportException):
-
-2009-09-21 Greg Bolsinga <bolsinga at apple.com>
-
- Reviewed by Simon Fraser & Sam Weinig.
-
- Add ENABLE(ORIENTATION_EVENTS)
- https://bugs.webkit.org/show_bug.cgi?id=29508
-
- See documentation here:
- http://developer.apple.com/safari/library/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html#//apple_ref/doc/uid/TP40006511-SW16
-
- * DerivedSources.make: Use new WebCore.OrientationEvents.exp file if ENABLE_ORIENTATION_EVENTS.
- Add ENABLE_ORIENTATION_EVENTS to the new ADDITIONAL_IDL_DEFINES variable that is passed to the IDL
- code generator. This is because ENABLE_ORIENTATION_EVENTS is not in FEATURE_DEFINES.
- * WebCore.OrientationEvents.exp: Added.
- * WebCore.xcodeproj/project.pbxproj: Add WebCore.OrientationEvents.exp.
- * dom/EventNames.h: Add onorientationchange.
- * html/HTMLAttributeNames.in: Ditto.
- * html/HTMLBodyElement.cpp: Handle onorientationchange properly.
- (WebCore::HTMLBodyElement::parseMappedAttribute):
- (WebCore::HTMLBodyElement::onorientationchange):
- (WebCore::HTMLBodyElement::setOnorientationchange):
- * html/HTMLBodyElement.h: Ditto.
- * html/HTMLBodyElement.idl: Ditto.
- * html/HTMLFrameSetElement.cpp: Ditto.
- (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- (WebCore::HTMLFrameSetElement::onorientationchange):
- (WebCore::HTMLFrameSetElement::setOnorientationchange):
- * html/HTMLFrameSetElement.h: Ditto.
- * html/HTMLFrameSetElement.idl: Ditto.
- * page/DOMWindow.cpp: Ditto.
- (WebCore::DOMWindow::orientation): Calls up the to the Frame for the orientation value.
- (WebCore::DOMWindow::onorientationchange):
- (WebCore::DOMWindow::setOnorientationchange):
- * page/DOMWindow.h: Handle onorientationchange properly.
- * page/DOMWindow.idl: Ditto.
- * page/Frame.cpp: Ditto.
- (WebCore::Frame::Frame):
- (WebCore::Frame::sendOrientationChangeEvent):
- * page/Frame.h: Ditto.
- (WebCore::Frame::orientation):
-
-2009-09-18 Anders Carlsson <andersca at apple.com>
-
- Try fixing the build again.
-
- * platform/win/PopupMenuWin.cpp:
- (WebCore::PopupMenu::wndProc):
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: completions are always evaluated against
- window (discarding call frames).
-
- https://bugs.webkit.org/show_bug.cgi?id=29616
-
- * inspector/front-end/ConsoleView.js:
- (WebInspector.ConsoleView.prototype.completions):
- * inspector/front-end/InjectedScript.js:
- (InjectedScript.getCompletions):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.selectedCallFrameId):
-
-2009-09-21 Brent Fulgham <bfulgham at webkit.org>
-
- Unreviewed build fix for Windows (Cairo) target.
-
- Add stubs for SocketStream classes added in @r47788, which
- broke the WinCairo build.
-
- No new tests. (Build failure).
-
- * WebCore.vcproj/WebCore.vcproj: Add references to new files
- to Cairo build, exclude from standard Apple build.
- * platform/network/curl/SocketStreamError.h: Added.
- * platform/network/curl/SocketStreamHandle.h: Added.
- * platform/network/curl/SocketStreamHandleCurl.cpp: Added.
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: Expose InspectorResource fields.
-
- https://bugs.webkit.org/show_bug.cgi?id=29537
-
- * inspector/InspectorResource.cpp:
- (WebCore::InspectorResource::sourceString):
- (WebCore::InspectorResource::resourceData):
- * inspector/InspectorResource.h:
- (WebCore::InspectorResource::requestHeaderFields):
- (WebCore::InspectorResource::responseHeaderFields):
- (WebCore::InspectorResource::responseStatusCode):
- (WebCore::InspectorResource::requestMethod):
- (WebCore::InspectorResource::requestFormData):
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: JS error drilling down childless node.
- No need to dispatch double click twice - it is already handled
- in TreeElement.treeElementDoubleClicked.
-
- https://bugs.webkit.org/show_bug.cgi?id=22144
-
- * inspector/front-end/ElementsTreeOutline.js:
- (WebInspector.ElementsTreeOutline):
-
2009-09-21 Kenneth Rohde Christiansen <kenneth at webkit.org>
Reviewed by Simon Hausmann.
@@ -1782,47 +72,6 @@
Reviewed by Timothy Hatcher.
- Web Inspector: Evaluating on call frame always returns "undefined".
-
- https://bugs.webkit.org/show_bug.cgi?id=29613
-
- * inspector/front-end/InjectedScript.js:
- (InjectedScript.evaluate):
- (InjectedScript._evaluateAndWrap):
- (InjectedScript._evaluateOn):
- (InjectedScript.evaluateInCallFrame):
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: Exception formatting is broken in console.
-
- https://bugs.webkit.org/show_bug.cgi?id=29608
-
- * inspector/front-end/ConsoleView.js:
- (WebInspector.ConsoleCommandResult):
- * inspector/front-end/InjectedScript.js:
- (InjectedScript.evaluate):
- (InjectedScript.createProxyObject):
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
- Web Inspector: Console object formatting is broken.
-
- https://bugs.webkit.org/show_bug.cgi?id=29607
-
- * inspector/front-end/ConsoleView.js:
- (WebInspector.ConsoleMessage.prototype._format):
- * inspector/front-end/ObjectProxy.js:
- (WebInspector.ObjectProxy.wrapPrimitiveValue):
-
-2009-09-21 Pavel Feldman <pfeldman at chromium.org>
-
- Reviewed by Timothy Hatcher.
-
Web Inspector: Crash When Logging an Element Before Opening Inspector
https://bugs.webkit.org/show_bug.cgi?id=29514
diff --git a/WebCore/inspector/front-end/ConsoleView.js b/WebCore/inspector/front-end/ConsoleView.js
index abda4b5..575b13a 100644
--- a/WebCore/inspector/front-end/ConsoleView.js
+++ b/WebCore/inspector/front-end/ConsoleView.js
@@ -303,7 +303,9 @@ WebInspector.ConsoleView.prototype = {
}
var includeInspectorCommandLineAPI = (!dotNotation && !bracketNotation);
- InjectedScriptAccess.getCompletions(expressionString, includeInspectorCommandLineAPI, reportCompletions);
+ if (WebInspector.panels.scripts && WebInspector.panels.scripts.paused)
+ var callFrameId = WebInspector.panels.scripts.selectedCallFrameId();
+ InjectedScriptAccess.getCompletions(expressionString, includeInspectorCommandLineAPI, callFrameId, reportCompletions);
},
_reportCompletions: function(bestMatchOnly, completionsReadyCallback, dotNotation, bracketNotation, prefix, result, isException) {
diff --git a/WebCore/inspector/front-end/InjectedScript.js b/WebCore/inspector/front-end/InjectedScript.js
index 4d96f68..726c7cc 100644
--- a/WebCore/inspector/front-end/InjectedScript.js
+++ b/WebCore/inspector/front-end/InjectedScript.js
@@ -499,11 +499,20 @@ InjectedScript.setPropertyValue = function(objectProxy, propertyName, expression
}
-InjectedScript.getCompletions = function(expression, includeInspectorCommandLineAPI)
+InjectedScript.getCompletions = function(expression, includeInspectorCommandLineAPI, callFrameId)
{
var props = {};
try {
- var expressionResult = InjectedScript._evaluateOn(InjectedScript._window().eval, InjectedScript._window(), expression);
+ var expressionResult;
+ // Evaluate on call frame if call frame id is available.
+ if (typeof callFrameId === "number") {
+ var callFrame = InjectedScript._callFrameForId(callFrameId);
+ if (!callFrame)
+ return props;
+ expressionResult = InjectedScript._evaluateOn(callFrame.evaluate, callFrame, expression);
+ } else {
+ expressionResult = InjectedScript._evaluateOn(InjectedScript._window().eval, InjectedScript._window(), expression);
+ }
for (var prop in expressionResult)
props[prop] = true;
if (includeInspectorCommandLineAPI)
diff --git a/WebCore/inspector/front-end/ScriptsPanel.js b/WebCore/inspector/front-end/ScriptsPanel.js
index 04f27bb..ae918d1 100644
--- a/WebCore/inspector/front-end/ScriptsPanel.js
+++ b/WebCore/inspector/front-end/ScriptsPanel.js
@@ -351,6 +351,14 @@ WebInspector.ScriptsPanel.prototype = {
sourceFrame.removeBreakpoint(breakpoint);
},
+ selectedCallFrameId: function()
+ {
+ var selectedCallFrame = this.sidebarPanes.callstack.selectedCallFrame;
+ if (!selectedCallFrame)
+ return null;
+ return selectedCallFrame.id;
+ },
+
evaluateInSelectedCallFrame: function(code, updateInterface, callback)
{
var selectedCallFrame = this.sidebarPanes.callstack.selectedCallFrame;
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list