[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75

simon.fraser at apple.com simon.fraser at apple.com
Thu Oct 29 20:41:22 UTC 2009


The following commit has been merged in the webkit-1.1 branch:
commit 169fd5e9bb334d4a86b092ee6e738157510c6d41
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Oct 7 22:29:25 2009 +0000

    2009-10-07  Simon Fraser  <simon.fraser at apple.com>
    
            Reviewed by Dan Bernstein.
    
            Animation stalls for a few seconds partway through
            https://bugs.webkit.org/show_bug.cgi?id=30182
    
            Make sure that we only call -disableScreenUpdatesUntilFlush when a window
            update is actually going to happen, otherwise screen updates are disabled
            for too long.
    
            * WebView/WebHTMLView.mm:
            (-[WebHTMLView drawRect:]):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index 556ce7b..8fb0abc 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,17 @@
+2009-10-07  Simon Fraser  <simon.fraser at apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Animation stalls for a few seconds partway through
+        https://bugs.webkit.org/show_bug.cgi?id=30182
+        
+        Make sure that we only call -disableScreenUpdatesUntilFlush when a window
+        update is actually going to happen, otherwise screen updates are disabled
+        for too long.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView drawRect:]):
+
 2009-10-06  Pavel Feldman  <pfeldman at chromium.org>
 
         Reviewed by Timothy Hatcher.
diff --git a/WebKit/mac/WebView/WebHTMLView.mm b/WebKit/mac/WebView/WebHTMLView.mm
index 2ed0ba8..5f7e4cf 100644
--- a/WebKit/mac/WebView/WebHTMLView.mm
+++ b/WebKit/mac/WebView/WebHTMLView.mm
@@ -3196,8 +3196,10 @@ WEBCORE_COMMAND(yankAndSelect)
     if ([[self _webView] _needsOneShotDrawingSynchronization]) {
         // Disable screen updates so that any layer changes committed here
         // don't show up on the screen before the window flush at the end
-        // of the current window display.
-        [[self window] disableScreenUpdatesUntilFlush];
+        // of the current window display, but only if a window flush is actually
+        // going to happen.
+        if ([[self window] viewsNeedDisplay])
+            [[self window] disableScreenUpdatesUntilFlush];
         
         // Make sure any layer changes that happened as a result of layout
         // via -viewWillDraw are committed.

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list