[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.15.1-1414-gc69ee75
simon.fraser at apple.com
simon.fraser at apple.com
Thu Oct 29 20:41:23 UTC 2009
The following commit has been merged in the webkit-1.1 branch:
commit c92291fe67d130c56cc1752530abafcf9cba72bd
Author: simon.fraser at apple.com <simon.fraser at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Oct 7 22:38:11 2009 +0000
2009-10-07 Simon Fraser <simon.fraser at apple.com>
Reviewed by Dan Bernstein.
Avoid Obj-C message dispatch when possible by storing accessed objects
in local variables.
* WebView/WebHTMLView.mm:
(-[WebHTMLView drawRect:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index 8fb0abc..6e2bc1a 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -2,6 +2,16 @@
Reviewed by Dan Bernstein.
+ Avoid Obj-C message dispatch when possible by storing accessed objects
+ in local variables.
+
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView drawRect:]):
+
+2009-10-07 Simon Fraser <simon.fraser at apple.com>
+
+ Reviewed by Dan Bernstein.
+
Animation stalls for a few seconds partway through
https://bugs.webkit.org/show_bug.cgi?id=30182
diff --git a/WebKit/mac/WebView/WebHTMLView.mm b/WebKit/mac/WebView/WebHTMLView.mm
index 5f7e4cf..2143dfe 100644
--- a/WebKit/mac/WebView/WebHTMLView.mm
+++ b/WebKit/mac/WebView/WebHTMLView.mm
@@ -3178,7 +3178,8 @@ WEBCORE_COMMAND(yankAndSelect)
double start = CFAbsoluteTimeGetCurrent();
#endif
- if ([[self _webView] _mustDrawUnionedRect:rect singleRects:rects count:count])
+ WebView* webView = [self _webView];
+ if ([webView _mustDrawUnionedRect:rect singleRects:rects count:count])
[self drawSingleRect:rect];
else
for (int i = 0; i < count; ++i)
@@ -3193,18 +3194,19 @@ WEBCORE_COMMAND(yankAndSelect)
[self _setAsideSubviews];
#if USE(ACCELERATED_COMPOSITING)
- if ([[self _webView] _needsOneShotDrawingSynchronization]) {
+ if ([webView _needsOneShotDrawingSynchronization]) {
// Disable screen updates so that any layer changes committed here
// don't show up on the screen before the window flush at the end
// of the current window display, but only if a window flush is actually
// going to happen.
- if ([[self window] viewsNeedDisplay])
- [[self window] disableScreenUpdatesUntilFlush];
+ NSWindow* window = [self window];
+ if ([window viewsNeedDisplay])
+ [window disableScreenUpdatesUntilFlush];
// Make sure any layer changes that happened as a result of layout
// via -viewWillDraw are committed.
[CATransaction flush];
- [[self _webView] _setNeedsOneShotDrawingSynchronization:NO];
+ [webView _setNeedsOneShotDrawingSynchronization:NO];
}
#endif
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list