[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

[commit-queue at webkit.org]

The following commit has been merged in the debian/experimental branch:
commit 9a8f2ab882206efe64140f5ca214a7e8914acb43
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Jul 14 14:10:29 2010 +0000

    2010-07-14  Lucas De Marchi  <lucas.demarchi at profusion.mobi>
    
            Reviewed by Kent Tamura.
    
            Notify browser about popup being deleted. In EFL and BREW ports, the
            WebCore::Popup object was being deleted leaving the popup in browser
            alive. Popups can be deleted in two ways: either from browser to webcore or
            from webcore to browser. The first path was ok. The problem was when the
            user changed the page with a popup still opened. This would trigger the
            second path and would cause WebCore::Popup to be deleted without
            notifying browser.
            https://bugs.webkit.org/show_bug.cgi?id=41877
    
            No new functionality so no new tests.
    
            * platform/brew/PopupMenuBrew.cpp:
            (WebCore::PopupMenu::~PopupMenu): call hide() when object is
            destroyed.
            * platform/efl/PopupMenuEfl.cpp:
            (WebCore::PopupMenu::~PopupMenu): ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1acfacd..f3c10dc 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,24 @@
+2010-07-14  Lucas De Marchi  <lucas.demarchi at profusion.mobi>
+
+        Reviewed by Kent Tamura.
+
+        Notify browser about popup being deleted. In EFL and BREW ports, the
+        WebCore::Popup object was being deleted leaving the popup in browser
+        alive. Popups can be deleted in two ways: either from browser to webcore or
+        from webcore to browser. The first path was ok. The problem was when the
+        user changed the page with a popup still opened. This would trigger the
+        second path and would cause WebCore::Popup to be deleted without
+        notifying browser.
+        https://bugs.webkit.org/show_bug.cgi?id=41877
+
+        No new functionality so no new tests.
+
+        * platform/brew/PopupMenuBrew.cpp:
+        (WebCore::PopupMenu::~PopupMenu): call hide() when object is
+        destroyed.
+        * platform/efl/PopupMenuEfl.cpp:
+        (WebCore::PopupMenu::~PopupMenu): ditto.
+
 2010-07-14  Satish Sampath  <satish at chromium.org>
 
         Reviewed by Kent Tamura.
diff --git a/WebCore/platform/brew/PopupMenuBrew.cpp b/WebCore/platform/brew/PopupMenuBrew.cpp
index 89f3fa1..eb03c66 100644
--- a/WebCore/platform/brew/PopupMenuBrew.cpp
+++ b/WebCore/platform/brew/PopupMenuBrew.cpp
@@ -40,6 +40,9 @@ PopupMenu::PopupMenu(PopupMenuClient* menuList)
 
 PopupMenu::~PopupMenu()
 {
+    // Tell client to destroy data related to this popup since this object is
+    // going away.
+    hide();
 }
 
 void PopupMenu::show(const IntRect& rect, FrameView* view, int index)
diff --git a/WebCore/platform/efl/PopupMenuEfl.cpp b/WebCore/platform/efl/PopupMenuEfl.cpp
index 4d9677b..9dc6986 100644
--- a/WebCore/platform/efl/PopupMenuEfl.cpp
+++ b/WebCore/platform/efl/PopupMenuEfl.cpp
@@ -39,6 +39,9 @@ PopupMenu::PopupMenu(PopupMenuClient* client)
 
 PopupMenu::~PopupMenu()
 {
+    // Tell client to destroy data related to this popup since this object is
+    // going away.
+    hide();
 }
 
 void PopupMenu::show(const IntRect& rect, FrameView* view, int index)

-- 
WebKit Debian packaging