[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc
kov at webkit.org
kov at webkit.org
Wed Dec 22 11:56:43 UTC 2010
The following commit has been merged in the debian/experimental branch:
commit ff24bcb2a3c44c02fa6640a9316b99c30db67764
Author: kov at webkit.org <kov at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Aug 11 23:25:59 2010 +0000
2010-08-11 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
Reviewed by Martin Robinson.
Small improvement to the documentation of the geolocation-policy-decision-requested
signal, stating more clearly what is expected from the handler.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 322c7a1..422abd5 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -2,6 +2,16 @@
Reviewed by Martin Robinson.
+ Small improvement to the documentation of the geolocation-policy-decision-requested
+ signal, stating more clearly what is expected from the handler.
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_class_init):
+
+2010-08-11 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
+
+ Reviewed by Martin Robinson.
+
[GTK] Geolocation policy decision object leaking
https://bugs.webkit.org/show_bug.cgi?id=43884
diff --git a/WebKit/gtk/webkit/webkitwebview.cpp b/WebKit/gtk/webkit/webkitwebview.cpp
index 58d91ea..45ff3db 100644
--- a/WebKit/gtk/webkit/webkitwebview.cpp
+++ b/WebKit/gtk/webkit/webkitwebview.cpp
@@ -2395,10 +2395,12 @@ static void webkit_web_view_class_init(WebKitWebViewClass* webViewClass)
* @frame: the frame that requests permission
* @policy_decision: a WebKitGeolocationPolicyDecision
*
- * When a @frame wants to get its geolocation permission.
- * The receiver must reply with a boolean wether it handled or not the
- * request. If the request is not handled, default behaviour is to deny
- * geolocation.
+ * This signal is emitted when a @frame wants to obtain the user's
+ * location. The decision can be made asynchronously, but you must
+ * call g_object_ref() the @policy_decision, and return %TRUE if
+ * you are going to handle the request. To actually make the
+ * decision you need to call webkit_geolocation_policy_allow() or
+ * webkit_geolocation_policy_deny() on @policy_decision.
*
* Since: 1.1.23
*/
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list