[SCM] WebKit Debian packaging branch, debian/experimental, updated. upstream/1.3.3-9427-gc2be6fc

kov at webkit.org kov at webkit.org
Wed Dec 22 11:56:42 UTC 2010


The following commit has been merged in the debian/experimental branch:
commit 998ff08900fbc6a087a69cd9a5bc7c84191b18b0
Author: kov at webkit.org <kov at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Wed Aug 11 23:25:46 2010 +0000

    2010-08-11 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
    
            Reviewed by Martin Robinson.
    
            [GTK] Geolocation policy decision object leaking
            https://bugs.webkit.org/show_bug.cgi?id=43884
    
            Use GRefPtr on the policy decision object to fix the leak.
    
            * WebCoreSupport/ChromeClientGtk.cpp:
            (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 4cde462..322c7a1 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,15 @@
+2010-08-11  Gustavo Noronha Silva  <gustavo.noronha at collabora.co.uk>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Geolocation policy decision object leaking
+        https://bugs.webkit.org/show_bug.cgi?id=43884
+
+        Use GRefPtr on the policy decision object to fix the leak.
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
+
 2010-08-10  Chris Marrin  <cmarrin at apple.com>
 
         Reviewed by Oliver Hunt.
diff --git a/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp b/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
index a06d637..185ac16 100644
--- a/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
+++ b/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
@@ -611,12 +611,12 @@ void ChromeClient::requestGeolocationPermissionForFrame(Frame* frame, Geolocatio
     WebKitWebFrame* webFrame = kit(frame);
     WebKitWebView* webView = getViewFromFrame(webFrame);
 
-    WebKitGeolocationPolicyDecision* policyDecision = webkit_geolocation_policy_decision_new(webFrame, geolocation);
+    GRefPtr<WebKitGeolocationPolicyDecision> policyDecision(adoptGRef(webkit_geolocation_policy_decision_new(webFrame, geolocation)));
 
     gboolean isHandled = FALSE;
-    g_signal_emit_by_name(webView, "geolocation-policy-decision-requested", webFrame, policyDecision, &isHandled);
+    g_signal_emit_by_name(webView, "geolocation-policy-decision-requested", webFrame, policyDecision.get(), &isHandled);
     if (!isHandled)
-        webkit_geolocation_policy_deny(policyDecision);
+        webkit_geolocation_policy_deny(policyDecision.get());
 }
 
 void ChromeClient::cancelGeolocationPermissionRequestForFrame(WebCore::Frame* frame, WebCore::Geolocation*)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list